[Bug middle-end/77671] missing -Wformat-overflow warning on sprintf overflow with "%s"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77671 Martin Sebor changed: What|Removed |Added Summary|missing -Wformat-length |missing -Wformat-overflow |warning on sprintf overflow |warning on sprintf overflow |with "%s" |with "%s" --- Comment #3 from Martin Sebor --- The warning has been renamed to -Wformat-overflow (and -Wformat-truncation). Adjusting Summary.
[Bug middle-end/77671] missing -Wformat-overflow warning on sprintf overflow with "%s"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77671 Martin Sebor changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2017-04-11 Assignee|unassigned at gcc dot gnu.org |msebor at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #4 from Martin Sebor --- Testing a patch.
[Bug middle-end/77671] missing -Wformat-overflow warning on sprintf overflow with "%s"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77671 --- Comment #5 from Martin Sebor --- Patch posted for review: https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00968.html
[Bug middle-end/77671] missing -Wformat-overflow warning on sprintf overflow with "%s"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77671 Martin Sebor changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Sebor --- Author: msebor Date: Sun May 14 17:50:28 2017 New Revision: 248035 URL: https://gcc.gnu.org/viewcvs?rev=248035&root=gcc&view=rev Log: PR middle-end/77671 - missing -Wformat-overflow warning on sprintf overflow with %s gcc/ChangeLog: PR middle-end/77671 * gimple-fold.c (gimple_fold_builtin_sprintf): Make extern. (gimple_fold_builtin_snprintf): Same. * gimple-fold.h (gimple_fold_builtin_sprintf): Declare. (gimple_fold_builtin_snprintf): Same. * gimple-ssa-sprintf.c (get_format_string): Correct the detection of character types. (is_call_safe): New function. (try_substitute_return_value): Call it. (try_simplify_call): New function. (pass_sprintf_length::handle_gimple_call): Call it. gcc/testsuite/ChangeLog: PR middle-end/77671 * gcc.dg/tree-ssa/builtin-sprintf-7.c: New test. * gcc.dg/tree-ssa/builtin-sprintf-8.c: New test. * gcc.dg/tree-ssa/builtin-sprintf-warn-1.c: Adjust. * gcc.dg/tree-ssa/builtin-sprintf-warn-2.c: Adjust. * gcc.dg/tree-ssa/builtin-sprintf-warn-3.c: Adjust. Added: trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-7.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-8.c Modified: trunk/gcc/ChangeLog trunk/gcc/gimple-fold.c trunk/gcc/gimple-fold.h trunk/gcc/gimple-ssa-sprintf.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-1.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-2.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-3.c --- Comment #7 from Martin Sebor --- Implemented in r248035.
[Bug middle-end/77671] missing -Wformat-overflow warning on sprintf overflow with "%s"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77671 Martin Sebor changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Sebor --- Author: msebor Date: Sun May 14 17:50:28 2017 New Revision: 248035 URL: https://gcc.gnu.org/viewcvs?rev=248035&root=gcc&view=rev Log: PR middle-end/77671 - missing -Wformat-overflow warning on sprintf overflow with %s gcc/ChangeLog: PR middle-end/77671 * gimple-fold.c (gimple_fold_builtin_sprintf): Make extern. (gimple_fold_builtin_snprintf): Same. * gimple-fold.h (gimple_fold_builtin_sprintf): Declare. (gimple_fold_builtin_snprintf): Same. * gimple-ssa-sprintf.c (get_format_string): Correct the detection of character types. (is_call_safe): New function. (try_substitute_return_value): Call it. (try_simplify_call): New function. (pass_sprintf_length::handle_gimple_call): Call it. gcc/testsuite/ChangeLog: PR middle-end/77671 * gcc.dg/tree-ssa/builtin-sprintf-7.c: New test. * gcc.dg/tree-ssa/builtin-sprintf-8.c: New test. * gcc.dg/tree-ssa/builtin-sprintf-warn-1.c: Adjust. * gcc.dg/tree-ssa/builtin-sprintf-warn-2.c: Adjust. * gcc.dg/tree-ssa/builtin-sprintf-warn-3.c: Adjust. Added: trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-7.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-8.c Modified: trunk/gcc/ChangeLog trunk/gcc/gimple-fold.c trunk/gcc/gimple-fold.h trunk/gcc/gimple-ssa-sprintf.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-1.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-2.c trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-3.c --- Comment #7 from Martin Sebor --- Implemented in r248035.
