[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

Jakub Jelinek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Jakub Jelinek  ---
Fixed.

[Bug middle-end/78419] ICE with target_clone on invalid target

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

Markus Trippelsdorf  changed:

   What|Removed |Added

 CC||steven at uplinklabs dot net

--- Comment #8 from Markus Trippelsdorf  ---
*** Bug 78844 has been marked as a duplicate of this bug. ***

[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

--- Comment #7 from Jakub Jelinek  ---
Fixed for 6.3+ as well.

[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

--- Comment #6 from Jakub Jelinek  ---
Author: jakub
Date: Wed Dec  7 22:52:39 2016
New Revision: 243404

URL: https://gcc.gnu.org/viewcvs?rev=243404=gcc=rev
Log:
Backported from mainline
2016-11-18  Jakub Jelinek  

PR middle-end/78419
* multiple_target.c (get_attr_len): Start with argnum and increment
argnum on every arg.  Use strchr in a loop instead of counting commas
manually.
(get_attr_str): Increment argnum for every comma in the string.
(separate_attrs): Use for instead of while loop, simplify.
(expand_target_clones): Rename defenition argument to definition.
Free attrs and attr_str even when diagnosing errors.  Temporarily
change input_location around targetm.target_option.valid_attribute_p
calls.  Don't emit warning or errors if that function fails.

* gcc.target/i386/pr78419.c: New test.

Added:
branches/gcc-6-branch/gcc/testsuite/gcc.target/i386/pr78419.c
Modified:
branches/gcc-6-branch/gcc/ChangeLog
branches/gcc-6-branch/gcc/multiple_target.c
branches/gcc-6-branch/gcc/testsuite/ChangeLog

[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

--- Comment #5 from Jakub Jelinek  ---
Fixed on the trunk, keeping it open for backport to 6.x.

[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

--- Comment #4 from Jakub Jelinek  ---
Author: jakub
Date: Fri Nov 18 22:21:31 2016
New Revision: 242608

URL: https://gcc.gnu.org/viewcvs?rev=242608=gcc=rev
Log:
PR middle-end/78419
* multiple_target.c (get_attr_len): Start with argnum and increment
argnum on every arg.  Use strchr in a loop instead of counting commas
manually.
(get_attr_str): Increment argnum for every comma in the string.
(separate_attrs): Use for instead of while loop, simplify.
(expand_target_clones): Rename defenition argument to definition.
Free attrs and attr_str even when diagnosing errors.  Temporarily
change input_location around targetm.target_option.valid_attribute_p
calls.  Don't emit warning or errors if that function fails.

* gcc.target/i386/pr78419.c: New test.

Added:
trunk/gcc/testsuite/gcc.target/i386/pr78419.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/multiple_target.c
trunk/gcc/testsuite/ChangeLog

[Bug middle-end/78419] ICE with target_clone on invalid target

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78419

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek  ---
Created attachment 40083
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40083=edit
gcc7-pr78419.patch

Untested fix.