[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[jakub at gcc dot gnu dot org]

--- Comment #8 from jakub at gcc dot gnu dot org  2009-11-28 12:12 ---
Subject: Bug 42156

Author: jakub
Date: Sat Nov 28 12:12:32 2009
New Revision: 154721

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=154721
Log:
PR obj-c++/42156
* objc-act.c (objc_build_struct): INIT_TYPE_OBJC_INFO for
type variants that don't have it initialized yet.

Modified:
trunk/gcc/objc/ChangeLog
trunk/gcc/objc/objc-act.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[jakub at gcc dot gnu dot org]

--- Comment #9 from jakub at gcc dot gnu dot org  2009-11-28 16:27 ---
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

   Priority|P3  |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[jakub at gcc dot gnu dot org]

--- Comment #4 from jakub at gcc dot gnu dot org  2009-11-26 09:31 ---
Caused by http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01059.html aka r154354.


-- 

jakub at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||jason at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[jakub at gcc dot gnu dot org]

--- Comment #5 from jakub at gcc dot gnu dot org  2009-11-26 09:42 ---
The problem seems to be the new set_underlying_type call called from
build_self_reference.  Apparently the objc-act.c expects that type variants at
that point are only created for some other purpose (don't know objc, so have no
idea for what), and that they have TYPE_OBJC_INFO allocated, which is not the
case for these self reference variants.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[jakub at gcc dot gnu dot org]

--- Comment #6 from jakub at gcc dot gnu dot org  2009-11-26 09:47 ---
Created an attachment (id=19152)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19152action=view)
gcc45-pr42156.patch

Untested patch.  I'm not familiary with ObjC/ObjC++, so have no idea whether it
is the right fix or not.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[howarth at nitro dot med dot uc dot edu]

--- Comment #7 from howarth at nitro dot med dot uc dot edu  2009-11-26 
19:29 ---
This patch on x86_64-apple-darwin10 returns the obj-c++ testsuite results back
to their previous results of...

=== obj-c++ Summary ===

# of expected passes398
# of unexpected failures52
# of unexpected successes   3
# of expected failures  15
# of unresolved testcases   1
# of unsupported tests  1

so it seems to be working fine.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156

[Bug objc++/42156] [4.5 Regression] Hundreds of objc++ testsuite regressions

[rguenth at gcc dot gnu dot org]

--- Comment #3 from rguenth at gcc dot gnu dot org  2009-11-24 10:49 ---
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2009-11-24 10:49:09
   date||
Summary|Hundreds of objc++ testsuite|[4.5 Regression] Hundreds of
   |regressions |objc++ testsuite regressions
   Target Milestone|--- |4.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42156