[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 sandra at gcc dot gnu.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #16 from sandra at gcc dot gnu.org --- I'm marking this issue as fixed, although there are still instances of "can not" in files maintained outside the normal GCC process. See the mailing list discussion for details. Also, I copied the changes to libiberty/ and include/ to the binutils-gdb copy of those directories.
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #15 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed Jan 9 21:46:45 2019 New Revision: 267787 URL: https://gcc.gnu.org/viewcvs?rev=267787=gcc=rev Log: 2019-01-09 Sandra Loosemore PR other/16615 [5/5] gcc/po/ * gcc.pot: Regenerate. Modified: trunk/gcc/po/ChangeLog trunk/gcc/po/gcc.pot
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #14 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed Jan 9 21:44:56 2019 New Revision: 267786 URL: https://gcc.gnu.org/viewcvs?rev=267786=gcc=rev Log: 2019-01-09 Sandra Loosemore PR other/16615 [4/5] gcc/ * config/pa/pa.c: Change "can not" to "cannot". * gimple-ssa-evrp-analyze.c: Likewise. * ipa-icf.c: Likewise. * ipa-polymorphic-call.c: Likewise. * ipa-pure-const.c: Likewise. * lra-constraints.c: Likewise. * lra-remat.c: Likewise. * reload1.c: Likewise. * reorg.c: Likewise. * tree-ssa-uninit.c: Likewise. gcc/ada/ * exp_ch11.adb: Change "can not" to "cannot". * sem_ch4.adb: Likewise. gcc/fortran/ * expr.c: Change "can not" to "cannot". libobjc/ * objc/runtime.h: Change "can not" to "cannot". Modified: trunk/gcc/ChangeLog trunk/gcc/ada/ChangeLog trunk/gcc/ada/exp_ch11.adb trunk/gcc/ada/sem_ch4.adb trunk/gcc/config/pa/pa.c trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/expr.c trunk/gcc/gimple-ssa-evrp-analyze.c trunk/gcc/ipa-icf.c trunk/gcc/ipa-polymorphic-call.c trunk/gcc/ipa-pure-const.c trunk/gcc/lra-constraints.c trunk/gcc/lra-remat.c trunk/gcc/reload1.c trunk/gcc/reorg.c trunk/gcc/tree-ssa-uninit.c trunk/libobjc/ChangeLog trunk/libobjc/objc/runtime.h
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #13 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed Jan 9 21:41:36 2019 New Revision: 267785 URL: https://gcc.gnu.org/viewcvs?rev=267785=gcc=rev Log: 2019-01-09 Sandra Loosemore PR other/16615 [3/5] gcc/testsuite/ * g++.dg/lto/odr-1_1.C: Update diagnostic message patterns to replace "can not" with "cannot". * gfortran.dg/common_15.f90: Likewise. * gfortran.dg/derived_result_2.f90: Likewise. * gfortran.dg/do_check_6.f90: Likewise. * gfortran.dg/namelist_args.f90: Likewise. * gfortran.dg/negative_unit_check.f90: Likewise. * gfortran.dg/pure_formal_3.f90: Likewise. * obj-c++.dg/attributes/method-attribute-2.mm: Likewise. * obj-c++.dg/exceptions-3.mm: Likewise. * obj-c++.dg/exceptions-4.mm: Likewise. * obj-c++.dg/exceptions-5.mm: Likewise. * obj-c++.dg/property/at-property-23.mm: Likewise. * obj-c++.dg/property/dotsyntax-17.mm: Likewise. * obj-c++.dg/property/property-neg-7.mm: Likewise. * objc.dg/attributes/method-attribute-2.m: Likewise. * objc.dg/exceptions-3.m: Likewise. * objc.dg/exceptions-4.m: Likewise. * objc.dg/exceptions-5.m: Likewise. * objc.dg/param-1.m: Likewise. * objc.dg/property/at-property-23.m: Likewise. * objc.dg/property/dotsyntax-17.m: Likewise. * objc.dg/property/property-neg-7.m: Likewise. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/g++.dg/lto/odr-1_1.C trunk/gcc/testsuite/gfortran.dg/common_15.f90 trunk/gcc/testsuite/gfortran.dg/derived_result_2.f90 trunk/gcc/testsuite/gfortran.dg/do_check_6.f90 trunk/gcc/testsuite/gfortran.dg/namelist_args.f90 trunk/gcc/testsuite/gfortran.dg/negative_unit_check.f90 trunk/gcc/testsuite/gfortran.dg/pure_formal_3.f90 trunk/gcc/testsuite/obj-c++.dg/attributes/method-attribute-2.mm trunk/gcc/testsuite/obj-c++.dg/exceptions-3.mm trunk/gcc/testsuite/obj-c++.dg/exceptions-4.mm trunk/gcc/testsuite/obj-c++.dg/exceptions-5.mm trunk/gcc/testsuite/obj-c++.dg/property/at-property-23.mm trunk/gcc/testsuite/obj-c++.dg/property/dotsyntax-17.mm trunk/gcc/testsuite/obj-c++.dg/property/property-neg-7.mm trunk/gcc/testsuite/objc.dg/attributes/method-attribute-2.m trunk/gcc/testsuite/objc.dg/exceptions-3.m trunk/gcc/testsuite/objc.dg/exceptions-4.m trunk/gcc/testsuite/objc.dg/exceptions-5.m trunk/gcc/testsuite/objc.dg/param-1.m trunk/gcc/testsuite/objc.dg/property/at-property-23.m trunk/gcc/testsuite/objc.dg/property/dotsyntax-17.m trunk/gcc/testsuite/objc.dg/property/property-neg-7.m
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #12 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed Jan 9 21:39:49 2019 New Revision: 267784 URL: https://gcc.gnu.org/viewcvs?rev=267784=gcc=rev Log: 2019-01-09 Sandra Loosemore PR other/16615 [2/5] include/ * libiberty.h: Mechanically replace "can not" with "cannot". * plugin-api.h: Likewise. libiberty/ * cp-demangle.c: Mechanically replace "can not" with "cannot". * floatformat.c: Likewise. * strerror.c: Likewise. Modified: trunk/include/ChangeLog trunk/include/libiberty.h trunk/include/plugin-api.h trunk/libiberty/ChangeLog trunk/libiberty/cp-demangle.c trunk/libiberty/floatformat.c trunk/libiberty/strerror.c
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #11 from sandra at gcc dot gnu.org --- Author: sandra Date: Wed Jan 9 21:37:45 2019 New Revision: 267783 URL: https://gcc.gnu.org/viewcvs?rev=267783=gcc=rev Log: 2019-01-09 Sandra Loosemore PR other/16615 [1/5] contrib/ * mklog: Mechanically replace "can not" with "cannot". gcc/ * Makefile.in: Mechanically replace "can not" with "cannot". * alias.c: Likewise. * builtins.c: Likewise. * calls.c: Likewise. * cgraph.c: Likewise. * cgraph.h: Likewise. * cgraphclones.c: Likewise. * cgraphunit.c: Likewise. * combine-stack-adj.c: Likewise. * combine.c: Likewise. * common/config/i386/i386-common.c: Likewise. * config/aarch64/aarch64.c: Likewise. * config/alpha/sync.md: Likewise. * config/arc/arc.c: Likewise. * config/arc/predicates.md: Likewise. * config/arm/arm-c.c: Likewise. * config/arm/arm.c: Likewise. * config/arm/arm.h: Likewise. * config/arm/arm.md: Likewise. * config/arm/cortex-r4f.md: Likewise. * config/csky/csky.c: Likewise. * config/csky/csky.h: Likewise. * config/darwin-f.c: Likewise. * config/epiphany/epiphany.md: Likewise. * config/i386/i386.c: Likewise. * config/i386/sol2.h: Likewise. * config/m68k/m68k.c: Likewise. * config/mcore/mcore.h: Likewise. * config/microblaze/microblaze.md: Likewise. * config/mips/20kc.md: Likewise. * config/mips/sb1.md: Likewise. * config/nds32/nds32.c: Likewise. * config/nds32/predicates.md: Likewise. * config/pa/pa.c: Likewise. * config/rs6000/e300c2c3.md: Likewise. * config/rs6000/rs6000.c: Likewise. * config/s390/s390.h: Likewise. * config/sh/sh.c: Likewise. * config/sh/sh.md: Likewise. * config/spu/vmx2spu.h: Likewise. * cprop.c: Likewise. * dbxout.c: Likewise. * df-scan.c: Likewise. * doc/cfg.texi: Likewise. * doc/extend.texi: Likewise. * doc/fragments.texi: Likewise. * doc/gty.texi: Likewise. * doc/invoke.texi: Likewise. * doc/lto.texi: Likewise. * doc/md.texi: Likewise. * doc/objc.texi: Likewise. * doc/rtl.texi: Likewise. * doc/tm.texi: Likewise. * dse.c: Likewise. * emit-rtl.c: Likewise. * emit-rtl.h: Likewise. * except.c: Likewise. * expmed.c: Likewise. * expr.c: Likewise. * fold-const.c: Likewise. * genautomata.c: Likewise. * gimple-fold.c: Likewise. * hard-reg-set.h: Likewise. * ifcvt.c: Likewise. * ipa-comdats.c: Likewise. * ipa-cp.c: Likewise. * ipa-devirt.c: Likewise. * ipa-fnsummary.c: Likewise. * ipa-icf.c: Likewise. * ipa-inline-transform.c: Likewise. * ipa-inline.c: Likewise. * ipa-polymorphic-call.c: Likewise. * ipa-profile.c: Likewise. * ipa-prop.c: Likewise. * ipa-pure-const.c: Likewise. * ipa-reference.c: Likewise. * ipa-split.c: Likewise. * ipa-visibility.c: Likewise. * ipa.c: Likewise. * ira-build.c: Likewise. * ira-color.c: Likewise. * ira-conflicts.c: Likewise. * ira-costs.c: Likewise. * ira-int.h: Likewise. * ira-lives.c: Likewise. * ira.c: Likewise. * ira.h: Likewise. * loop-invariant.c: Likewise. * loop-unroll.c: Likewise. * lower-subreg.c: Likewise. * lra-assigns.c: Likewise. * lra-constraints.c: Likewise. * lra-eliminations.c: Likewise. * lra-lives.c: Likewise. * lra-remat.c: Likewise. * lra-spills.c: Likewise. * lra.c: Likewise. * lto-cgraph.c: Likewise. * lto-streamer-out.c: Likewise. * postreload-gcse.c: Likewise. * predict.c: Likewise. * profile-count.h: Likewise. * profile.c: Likewise. * recog.c: Likewise. * ree.c: Likewise. * reload.c: Likewise. * reload1.c: Likewise. * reorg.c: Likewise. * resource.c: Likewise. * rtl.def: Likewise. * rtl.h: Likewise. * rtlanal.c: Likewise. * sched-deps.c: Likewise. * sched-ebb.c: Likewise. * sched-rgn.c: Likewise. * sel-sched-ir.c: Likewise. * sel-sched.c: Likewise. * shrink-wrap.c: Likewise. * simplify-rtx.c: Likewise. * symtab.c: Likewise. * target.def: Likewise. * toplev.c: Likewise. * tree-call-cdce.c: Likewise. * tree-cfg.c: Likewise. * tree-complex.c: Likewise. * tree-core.h: Likewise. * tree-eh.c: Likewise. * tree-inline.c: Likewise. * tree-loop-distribution.c: Likewise.
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #10 from sandra at gcc dot gnu.org --- Patch was posted here. I'd like some review on methodology for the mechanically-generated parts before checking in the whole mess. https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01732.html
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #9 from joseph at codesourcery dot com --- I'd suggest reviewing the set of files changed to see if any are generated files, or their sources (configure.ac, aclocal.m4, etc.), and doing a regeneration in that case.
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #8 from sandra at gcc dot gnu.org --- Right, I was expecting there would be a few of them that grep/sed would miss because of line breaks. I can hand-patch the ones I can find, but it's not the end of the world if a few escape -- it's not like we don't have other typos in comments etc as well. Are there potential problems with the automated approach in relation to touching generated files, etc that I need to beware of?
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 --- Comment #7 from joseph at codesourcery dot com --- Note there are a few places where it's "cannot", which the most obvious find/sed might not locate. E.g. in lra-remat.c: /* Map: insn -> candidate representing it. It is null if the insn can not be used for rematerialization. */ or in reorg.c: We can not steal the delay list if one of the instructions in the current delay_list modifies the condition codes and the jump in the sequence is a conditional jump. We can not do this because we can not change the direction of the jump because the condition codes will effect the direction of the jump in the sequence. */ (found via examining the output of "grep -C1 'can$'" for following lines starting with "not" after whitespace).
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615 sandra at gcc dot gnu.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||sandra at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |sandra at gcc dot gnu.org --- Comment #6 from sandra at gcc dot gnu.org --- Since this will touch hundreds of files (code as well as documentation), I propose to do this mechanically via find and sed, and wait until around the end of the year when there is typically less activity on trunk due to holidays; that would be late in Stage 3. Any objection to that plan?
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615
--- Comment #5 from Eric Gallager ---
(In reply to Eric Gallager from comment #4)
> (In reply to Georg Schwarz from comment #0)
> > Throughout gcc documentation and code "cannot" is wrongly spelled as "can
> > not". The following command executed in the source root reveals the affected
> > files:
> > find . -type f -print | xargs grep -i "can not"| awk -F: '{print $1}'|uniq
> >
> > Please change the text into "cannot". Thanks.
>
> Adding a 'wc -l' to the end of that pipeline shows that 375 are affected.
375 files, that is
[Bug other/16615] throughout gcc docu and code numerous "can not"'s appear
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16615
Eric Gallager changed:
What|Removed |Added
Keywords||documentation
Last reconfirmed|2005-01-16 01:24:20 |2017-7-24
CC||egallager at gcc dot gnu.org
--- Comment #4 from Eric Gallager ---
(In reply to Georg Schwarz from comment #0)
> Throughout gcc documentation and code "cannot" is wrongly spelled as "can
> not". The following command executed in the source root reveals the affected
> files:
> find . -type f -print | xargs grep -i "can not"| awk -F: '{print $1}'|uniq
>
> Please change the text into "cannot". Thanks.
Adding a 'wc -l' to the end of that pipeline shows that 375 are affected.
