[Bug other/89860] liboffloadmic/runtime/offload_target.cpp:332]: (style) Array index 'i' is used before limits check.

2020-05-05 Thread marxin at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89860

Martin Liška  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||marxin at gcc dot gnu.org

--- Comment #5 from Martin Liška  ---
Fixed on master.

[Bug other/89860] liboffloadmic/runtime/offload_target.cpp:332]: (style) Array index 'i' is used before limits check.

2020-05-05 Thread cvs-commit at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89860

--- Comment #4 from CVS Commits  ---
The master branch has been updated by Martin Liska :

https://gcc.gnu.org/g:98f7381d17a1ad47773b70a5de7d94a164357916

commit r11-75-g98f7381d17a1ad47773b70a5de7d94a164357916
Author: Martin Liska 
Date:   Tue Feb 4 14:57:59 2020 +0100

Put index check before use.

liboffloadmic/ChangeLog:

2020-02-04  Martin Liska  

PR other/89860
* runtime/offload_target.cpp: Put index check
before its use.

[Bug other/89860] liboffloadmic/runtime/offload_target.cpp:332]: (style) Array index 'i' is used before limits check.

2019-09-28 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89860

Eric Gallager  changed:

   What|Removed |Added

 CC||iverbin at gcc dot gnu.org

--- Comment #3 from Eric Gallager  ---
svn blame says Ilya Verbin wrote this code; cc-ing

[Bug other/89860] liboffloadmic/runtime/offload_target.cpp:332]: (style) Array index 'i' is used before limits check.

2019-03-28 Thread crazylht at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89860

--- Comment #2 from Hongtao.liu  ---

The code is like:

for (int i = 0; i < m_vars_total; i++) {
  // instead of m_vars[i].type.src we will use m_vars_extra[i].type_src

   if (i < vars_total) {

..

if (m_vars[i].type.dst == c_extended_type && i < vars_total)

..

   }

..

}

So the later ***i < vars_total*** is not actually needed.

[Bug other/89860] liboffloadmic/runtime/offload_target.cpp:332]: (style) Array index 'i' is used before limits check.

2019-03-28 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89860

Richard Biener  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-03-28
 CC||hjl.tools at gmail dot com
 Ever confirmed|0   |1

--- Comment #1 from Richard Biener  ---
Confirmed.  But the code is probably unmaintained - HJ, whose the Intel contact
to work on MIC (or is it time to rip out intelmic support given Knights-* is
dead?)