[Bug other/93168] Error messages are full of control code garbage

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

--- Comment #7 from Segher Boessenkool  ---
(In reply to David Malcolm from comment #6)
> Segher: did the above patch fix it for your terminal?

I haven't found time to test it on all those systems yet, no.

[Bug other/93168] Error messages are full of control code garbage

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

--- Comment #6 from David Malcolm  ---
Segher: did the above patch fix it for your terminal?

[Bug other/93168] Error messages are full of control code garbage

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

--- Comment #5 from CVS Commits  ---
The master branch has been updated by Bernd Edlinger :

https://gcc.gnu.org/g:458c8d6459c4005fc9886b6e25d168a6535ac415

commit r10-6643-g458c8d6459c4005fc9886b6e25d168a6535ac415
Author: Bernd Edlinger 
Date:   Wed Jan 29 15:31:10 2020 +0100

PR 87488: Add --with-diagnostics-urls configuration option

2020-02-15  David Malcolm  
Bernd Edlinger  

PR 87488
PR other/93168
* config.in (DIAGNOSTICS_URLS_DEFAULT): New define.
* configure.ac (--with-diagnostics-urls): New configuration
option, based on --with-diagnostics-color.
(DIAGNOSTICS_URLS_DEFAULT): New define.
* config.h: Regenerate.
* configure: Regenerate.
* diagnostic.c (diagnostic_urls_init): Handle -1 for
DIAGNOSTICS_URLS_DEFAULT from configure-time
--with-diagnostics-urls=auto-if-env by querying for a GCC_URLS
and TERM_URLS environment variable.
* diagnostic-url.h (diagnostic_url_format): New enum type.
(diagnostic_urls_enabled_p): rename to...
(determine_url_format): ... this, and change return type.
* diagnostic-color.c (parse_env_vars_for_urls): New helper function.
(auto_enable_urls): Disable URLs on xfce4-terminal, gnome-terminal,
the linux console, and mingw.
(diagnostic_urls_enabled_p): rename to...
(determine_url_format): ... this, and adjust.
* pretty-print.h (pretty_printer::show_urls): rename to...
(pretty_printer::url_format): ... this, and change to enum.
* pretty-print.c (pretty_printer::pretty_printer,
pp_begin_url, pp_end_url, test_urls): Adjust.
* doc/install.texi (--with-diagnostics-urls): Document the new
configuration option.
(--with-diagnostics-color): Document the existing interaction
with GCC_COLORS better.
* doc/invoke.texi (-fdiagnostics-urls): Add GCC_URLS and TERM_URLS
vindex reference.  Update description of defaults based on the above.
(-fdiagnostics-color): Update description of how -fdiagnostics-color
interacts with GCC_COLORS.

[Bug other/93168] Error messages are full of control code garbage

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

--- Comment #4 from David Malcolm  ---
Updated patch: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg02096.html

[Bug other/93168] Error messages are full of control code garbage

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

Martin Liška  changed:

   What|Removed |Added

 Status|UNCONFIRMED |WAITING
   Last reconfirmed||2020-01-21
 CC||marxin at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #3 from Martin Liška  ---
@Segher: Can you please provide more info?

[Bug other/93168] Error messages are full of control code garbage

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93168

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||diagnostic
 CC||dmalcolm at gcc dot gnu.org,
   ||pinskia at gcc dot gnu.org
  Component|middle-end  |other

--- Comment #2 from Andrew Pinski  ---
Currently -fdiagnostics-urls is enabled to auto but it seems like for some
terminals, it detects the wrong thing.

Which terminal are you using, and what version?


See https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01409.html also.  Though
--with-diagnostics-urls has not gone in yet.