[Bug pch/35027] too short to be a PCH file warning should be conditional on -Winvalid-PCH

[pinskia at gcc dot gnu dot org]

--- Comment #2 from pinskia at gcc dot gnu dot org  2008-02-23 17:08 ---
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35027

[Bug pch/35027] too short to be a PCH file warning should be conditional on -Winvalid-PCH

[pinskia at gcc dot gnu dot org]

--- Comment #3 from pinskia at gcc dot gnu dot org  2008-02-23 17:08 ---
Subject: Bug 35027

Author: pinskia
Date: Sat Feb 23 17:08:12 2008
New Revision: 132574

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=132574
Log:
2008-02-23  Andrew Pinski  [EMAIL PROTECTED]

PR pch/35027
* c-pch.c (c_common_valid_pch): Make the too short to be a PCH
file warning condtional on -Winvalid-PCH.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/c-pch.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35027

[Bug pch/35027] too short to be a PCH file warning should be conditional on -Winvalid-PCH

[pinskia at gcc dot gnu dot org]

--- Comment #1 from pinskia at gcc dot gnu dot org  2008-01-30 00:43 ---
I have a simple fix for 4.4.0:
Index: c-pch.c
===
--- c-pch.c (revision 131943)
+++ c-pch.c (working copy)
@@ -243,8 +243,9 @@
 fatal_error (can%'t read %s: %m, name);
   else if (sizeread != IDENT_LENGTH + 16)
 {
-  cpp_error (pfile, CPP_DL_WARNING, %s: too short to be a PCH file,
-name);
+  if (cpp_get_options (pfile)-warn_invalid_pch)
+cpp_error (pfile, CPP_DL_WARNING, %s: too short to be a PCH file,
+  name);
   return 2;
 }



-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

OtherBugsDependingO||33702
  nThis||
 AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2008-01-30 00:43:57
   date||
   Target Milestone|--- |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35027