[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #12 from Jakub Jelinek --- Author: jakub Date: Thu Jan 28 22:35:20 2016 New Revision: 232956 URL: https://gcc.gnu.org/viewcvs?rev=232956&root=gcc&view=rev Log: PR pch/68176 * files.c (_cpp_find_file): Set file->implicit_preinclude even if included from file->implicit_preinclude header. Modified: trunk/libcpp/ChangeLog trunk/libcpp/files.c
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #11 from Nix --- Confirmed fixed (properly this time).
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #10 from Nix --- Argh, scratch that -- I need to test a tree that *doesn't* have the original patch reverted! Doing that now, will report back once that's done.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #9 from Nix --- Tested on the same old GCC 4.9 build tree and eglibc system that failed in the original report (for maximum reproducibility): it works, the regression is cured.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #8 from Jakub Jelinek --- Note, while I don't have eglibc, I've hacked my /usr/include/stdc-predef.h to #include and added that header, without the patch I see many FAILs with make check-gcc RUNTESTFLAGS=pch.exp, with the patch none. Will bootstrap/regtest it now.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 Jakub Jelinek changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2016-01-28 Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org Ever confirmed|0 |1 --- Comment #7 from Jakub Jelinek --- Created attachment 37503 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=37503&action=edit gcc6-pr68176.patch Can you please try this?
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #6 from joseph at codesourcery dot com --- The original concept for stdc-predef.h includes that it might include other headers - in particular, that it might #include_next , so that e.g. libdfp could provide its own stdc-predef.h that defines relevant __STDC_* macros to say that DFP library functionality is available before including the glibc version, when you use -isystem /usr/include/dfp. Now, libdfp currently doesn't do that, and such use of libdfp might not be expected to work with PCH, so fixincluding may well be sufficient for this bug at present.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #5 from Nix --- I didn't think of that (I try to forget that fixincludes exists because it gives me nightmares). But much though I hate fixincludes, this sort of fix (to headers for an obsolete program which will by definition never be fixed) is more or less exactly what it was designed for, and seems a perfect fit for this case. The question is whether further adjustments are needed to compensate for the removal of ... I'll do some experimentation.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org, ||jsm28 at gcc dot gnu.org --- Comment #4 from Jakub Jelinek --- So shouldn't we just fixinclude the bad stdc-predef.h headers and resolve this that way? IMNSHO stdc-predef.h really shouldn't include anything.
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 --- Comment #3 from Nix --- I haven't tested that yet, so I wasn't willing to commit to it. It seems very likely though. (I wasn't sure of protocol, or I'd have put you in the Cc list as the author of the fix for bug 65550, but I was afraid that might seem spammy... glad to see you spotted the bug going by anyway.)
[Bug pch/68176] [4.9/5/6 Regression] all pch tests fail on eglibc systems (with bits/predefs.h)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68176 Richard Biener changed: What|Removed |Added CC||rguenth at gcc dot gnu.org Target Milestone|--- |4.9.4 Summary|[4.8/4.9 Regression] all|[4.9/5/6 Regression] all |pch tests fail on eglibc|pch tests fail on eglibc |systems (with |systems (with |bits/predefs.h) |bits/predefs.h) --- Comment #2 from Richard Biener --- I suppose it doesn't work with GCC 5 or trunk either.
