[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

--- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-15 
13:43 ---
See http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00604.html


-- 
   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[cvs-commit at gcc dot gnu dot org]

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-15 
13:41 ---
Subject: Bug 15167

CVSROOT:/cvs/gcc
Module name:gcc
Branch: gcc-3_4-branch
Changes by: [EMAIL PROTECTED]   2004-12-15 13:41:28

Modified files:
gcc: ChangeLog cppfiles.c 
gcc/testsuite  : ChangeLog 
Added files:
gcc/testsuite/gcc.dg/cpp: pragma-once-1b.h pragma-once-1.c 
  pragma-once-1c.h pragma-once-1d.h 
gcc/testsuite/gcc.dg/cpp/inc: pragma-once-1a.h 

Log message:
PR preprocessor/15167
* cppfiles.c (destroy_cpp_file): New function.
(should_stack_file): Make a new file if the
compared file is still stacked.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.736&r2=2.2326.2.737
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cppfiles.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.198.4.3&r2=1.198.4.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.325&r2=1.3389.2.326
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1b.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1c.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1d.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pragma-once-1a.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[cvs-commit at gcc dot gnu dot org]

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-15 
13:31 ---
Subject: Bug 15167

CVSROOT:/cvs/gcc
Module name:gcc
Changes by: [EMAIL PROTECTED]   2004-12-15 13:31:29

Modified files:
libcpp : ChangeLog files.c 
gcc/testsuite  : ChangeLog 
Added files:
gcc/testsuite/gcc.dg/cpp: pragma-once-1b.h pragma-once-1.c 
  pragma-once-1c.h pragma-once-1d.h 
gcc/testsuite/gcc.dg/cpp/inc: pragma-once-1a.h 

Log message:
PR preprocessor/15167
* files.c (destroy_cpp_file): New function.
(should_stack_file): Make a new file if the
compared file is still stacked.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/ChangeLog.diff?cvsroot=gcc&r1=1.44&r2=1.45
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libcpp/files.c.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4761&r2=1.4762
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1b.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1c.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/pragma-once-1d.h.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/cpp/inc/pragma-once-1a.h.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

--- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-09 
07:07 ---
Revised patch at http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00604.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

--- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-06 
07:11 ---
> Eric - can you try your testcase on GCC sources as of around the beginning of
> August 2003?

You can't reasonably ask this.  It is your duty as a cpplib maintainer to do
this kind of work.  I honestly have no time to do it myself.

> This is when I completely rewrote the whole file lookup mechanism, and
> contrary to Zack's claims it did work 100% correctly, to the best of my
> knowledge, and would always get links, both hard and soft, correct with
> #pragma once correct no matter how contorted or renamed the file was.  Then
> only issue in that code was the -remap bug that has since been fixed.

Yes, the code doesn't look particularly broken to me.  Does your original code
reset buffer_valid when the buffer is freed?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[neil at gcc dot gnu dot org]

--- Additional Comments From neil at gcc dot gnu dot org  2004-12-06 02:26 
---
Eric - can you try your testcase on GCC sources as of around the beginning of
August 2003?

This is when I completely rewrote the whole file lookup mechanism, and contrary
to Zack's claims it did work 100% correctly, to the best of my knowledge, and
would always get links, both hard and soft, correct with #pragma once correct no
matter how contorted or renamed the file was.  Then only issue in that code was
the -remap bug that has since been fixed.

However, since that date, various people have hacked at the code who probably
didn't understand it.  Zack did various "optimizations" and Apple added a bunch
of stuff for obfuscated include file lookup and line number stuff.  I think it
is very likely it was broken along the way.

If it was broken back around 5th August 2003 I will look into this, as it was my
new code.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-05 
18:48 ---
Patch here: .

-- 
   What|Removed |Added

   Keywords||patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[ebotcazou at gcc dot gnu dot org]

--- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-12-02 
18:54 ---
Investigating, but this is not pretty.


-- 
   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
   |dot org |org
 Status|NEW |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-12 
04:54 ---
Someone should really look into this more than I have since this is a really 
bad preprocessor regression.

-- 
   What|Removed |Added

   Severity|normal  |critical


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[mmitchel at gcc dot gnu dot org]

--- Additional Comments From mmitchel at gcc dot gnu dot org  2004-11-01 00:46 
---
Postponed until GCC 3.4.4.

-- 
   What|Removed |Added

   Target Milestone|3.4.3   |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-13 11:31 
---
*** Bug 17944 has been marked as a duplicate of this bug. ***

-- 
   What|Removed |Added

 CC||micis at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167

[Bug preprocessor/15167] [3.4/4.0 Regression] Internal compiler error with "#pragma once"

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-11 05:22 
---
f->buffer is NULL at the point of the crash.

-- 
   What|Removed |Added

  Known to fail|3.4.1 4.0   |3.4.1 4.0.0
  Known to work||3.3.3
   Last reconfirmed|2004-04-27 13:29:45 |2004-10-11 05:22:19
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15167