[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-16 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Andrew Pinski  changed:

   What|Removed |Added

   Severity|normal  |blocker
   Target Milestone|--- |14.0
   Keywords||wrong-code
  Component|target  |rtl-optimization
   Priority|P3  |P1

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-16 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #5 from Andrew Pinski  ---
The first thing to start with is figure out which file is being miscompiled.
Once we have that it might be easier to track down what is going wrong (we can
even look at the RTL dumps before and after to understand the issue).

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-16 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #6 from Andrew Pinski  ---
So the thing to look for the placement of vzeroupper. That is what mode
switching is used for inside the x86 back-end.

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-16 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #7 from Kostadin Shishmanov  ---
Created attachment 56612
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56612&action=edit
bad object file

I've attached the bad object file (the one from the compilation with the "bad"
commit). Going to also upload a good one in a bit. What flags do you need me to
add for the rtl dumps?

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-16 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #8 from Andrew Pinski  ---
(In reply to Kostadin Shishmanov from comment #7)
> Created attachment 56612 [details]
> bad object file
> 
> I've attached the bad object file (the one from the compilation with the
> "bad" commit). Going to also upload a good one in a bit. What flags do you
> need me to add for the rtl dumps?

-da should be enough. I would only attach the first one that is different. Also
attach the preprocessed source if you have not yet (-save-temps and either a .i
or .ii file compressed if needed).

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #9 from Kostadin Shishmanov  ---
Created attachment 56613
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56613&action=edit
dump of the first bad pass with the problematic commit

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #10 from Kostadin Shishmanov  ---
Created attachment 56614
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56614&action=edit
dump of the first bad pass with the commit reverted

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #11 from Kostadin Shishmanov  ---
I think the gcc builds might be a bit more different than just the commit
reverted, so I am going to redo everything and upload the attachments again
with just that difference.

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Kostadin Shishmanov  changed:

   What|Removed |Added

  Attachment #56613|0   |1
is obsolete||

--- Comment #12 from Kostadin Shishmanov  ---
Created attachment 56616
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56616&action=edit
dump of the first different pass with the problematic commit

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Kostadin Shishmanov  changed:

   What|Removed |Added

  Attachment #56614|0   |1
is obsolete||

--- Comment #13 from Kostadin Shishmanov  ---
Created attachment 56617
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56617&action=edit
dump of the first different pass with the commit reverted

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Kostadin Shishmanov  changed:

   What|Removed |Added

  Attachment #56603|0   |1
is obsolete||

--- Comment #14 from Kostadin Shishmanov  ---
Created attachment 56618
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56618&action=edit
good object file

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-17 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Kostadin Shishmanov  changed:

   What|Removed |Added

  Attachment #56602|0   |1
is obsolete||
  Attachment #56612|0   |1
is obsolete||

--- Comment #15 from Kostadin Shishmanov  ---
Created attachment 56619
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56619&action=edit
bad object file

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-18 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #16 from Andrew Pinski  ---
(In reply to Kostadin Shishmanov from comment #13)
> Created attachment 56617 [details]
> dump of the first different pass with the commit reverted

Note using -fdump-unnumbered might help to avoid dumping memory addresses that
were from memory addresses inside gcc itself. I forgot about that when I
mentioned the -da option.

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-18 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #17 from Andrew Pinski  ---
Can you try the patch in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112572#c18 ?

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-18 Thread kocelfc at tutanota dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

--- Comment #18 from Kostadin Shishmanov  ---
(In reply to Andrew Pinski from comment #17)
> Can you try the patch in
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112572#c18 ?

The patch does fix it.

[Bug rtl-optimization/112568] [14 Regression] Miscompilation of radeonsi (mesa) with -march=raptorlake (-mavx) since r14-5355-g3cd3a09b3f91a1

2023-11-18 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112568

Andrew Pinski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #19 from Andrew Pinski  ---
Even though this is an older bug, pr 112572 has more analysis of what is going
wrong so marking as a dup.

*** This bug has been marked as a duplicate of bug 112572 ***