[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[bonzini at gnu dot org]

--- Comment #5 from bonzini at gnu dot org  2006-09-05 21:40 ---
patch committed, confirmed fixed by andreas


-- 

bonzini at gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[bonzini at gcc dot gnu dot org]

--- Comment #4 from bonzini at gnu dot org  2006-09-05 17:41 ---
Subject: Bug 26847

Author: bonzini
Date: Tue Sep  5 17:41:22 2006
New Revision: 116701

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116701
Log:
2006-09-05  Paolo Bonzini  <[EMAIL PROTECTED]>

PR rtl-optimization/26847
* simplify-rtx.c (struct simplify_plus_minus_op_data): Remove ix.
(simplify_plus_minus_op_data_cmp): For REGs, break ties on the regno.
(simplify_plus_minus): Count n_constants while filling ops.  Replace
qsort with insertion sort.  Before going through the array to simplify
pairs, sort it.  Delay early exit until after the first sort, exiting
only if no swaps occurred.  Simplify pairs in reversed order, without
special-casing the first iteration.  Pack ops after simplifying pairs.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/simplify-rtx.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[bonzini at gnu dot org]

--- Comment #3 from bonzini at gnu dot org  2006-08-11 09:15 ---
Created an attachment (id=12062)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12062&action=view)
patch being tested


Tested so far by checking that it makes PR28651 resurface...

Being bootstrapped and tested on i686-pc-linux-gnu.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[bonzini at gnu dot org]

--- Comment #2 from bonzini at gnu dot org  2006-08-09 07:42 ---
Uhm, fixing this will resurface a wrong-code bug, PR28651, which is more
important than this missed optimization. :-(


-- 

bonzini at gnu dot org changed:

   What|Removed |Added

  BugsThisDependsOn||28651


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[bonzini at gnu dot org]

-- 

bonzini at gnu dot org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Last reconfirmed|2006-03-30 20:09:49 |2006-07-25 14:53:34
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

   What|Removed |Added

   Priority|P3  |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

   Target Milestone|--- |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847

[Bug rtl-optimization/26847] [4.2 Regression] Missed optimization in simplify_plus_minus

[pinskia at gcc dot gnu dot org]

--- Comment #1 from pinskia at gcc dot gnu dot org  2006-03-30 20:09 ---
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2006-03-30 20:09:49
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26847