[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread chefmax at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

Maxim Ostapenko  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Maxim Ostapenko  ---
Fixed by Jakub.


[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

--- Comment #5 from Jakub Jelinek  ---
Author: jakub
Date: Tue Feb  4 10:46:22 2014
New Revision: 207459

URL: http://gcc.gnu.org/viewcvs?rev=207459&root=gcc&view=rev
Log:
PR sanitizer/60055
* tsan/tsan_flags.cc (__tsan_default_options): Add
SANITIZER_INTERFACE_ATTRIBUTE.  Backport from upstream r200747.
* tsan/tsan_rtl.cc (__tsan::OnFinalize): Likewise.

Modified:
trunk/libsanitizer/ChangeLog
trunk/libsanitizer/tsan/tsan_flags.cc
trunk/libsanitizer/tsan/tsan_rtl.cc


[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread chefmax at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

--- Comment #4 from Maxim Ostapenko  ---
(In reply to Dmitry Vyukov from comment #3)
> Hi,
> 
> Does this work for you
> http://llvm.org/viewvc/llvm-project?view=revision&revision=200747
> ?
> 
> These callbacks are intended for very specific usages. I am curious how do
> you want to use them?

We use these callbacks in tsan test g++.dg/tsan/default_options.C.

I guess we'll wait for next merge with LLVM libsanitizer to get this fix.


[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread dvyukov at google dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

Dmitry Vyukov  changed:

   What|Removed |Added

 CC||dvyukov at google dot com

--- Comment #3 from Dmitry Vyukov  ---
Hi,

Does this work for you
http://llvm.org/viewvc/llvm-project?view=revision&revision=200747
?

These callbacks are intended for very specific usages. I am curious how do you
want to use them?


[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

--- Comment #2 from Jakub Jelinek  ---
Shouldn't __tsan::OnFinalize also have SANITIZER_INTERFACE_ATTRIBUTE ?
__tsan::OnReport does have it.


[Bug sanitizer/60055] Invalid binding of __tsan_default_options

2014-02-04 Thread chefmax at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60055

--- Comment #1 from chefmax at gcc dot gnu.org ---
Created attachment 32034
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32034&action=edit
Proposed patch

Attached patch seems to fix the bug.

$ readelf -s ~/gcc-master-install/lib64/libtsan.so | grep tsan_default
3305: 0002c2b5 8 FUNCWEAK   DEFAULT   10 __tsan_default_options