[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-20 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #11 from Eric Gallager  ---
My testresults are here:
https://gcc.gnu.org/ml/gcc-testresults/2017-10/msg01751.html
Lots of sanitizer-related FAILs, but they're probably my fault due to the bogus
--without-pic I added.

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-20 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #10 from Jakub Jelinek  ---
Still, it was clearly caused by the bogus --without-pic, as lsan_preinit.cc is
guarded with a macro that was not enabled if PIC was defined.

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-20 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

Eric Gallager  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Eric Gallager  ---
(In reply to Jakub Jelinek from comment #7)
> Author: jakub
> Date: Fri Oct 20 07:32:35 2017
> New Revision: 253925
> 
> URL: https://gcc.gnu.org/viewcvs?rev=253925&root=gcc&view=rev
> Log:
>   PR sanitizer/82595
>   * config/gnu-user.h (LIBTSAN_EARLY_SPEC): Add libtsan_preinit.o
>   for -fsanitize=thread link of executables.
>   (LIBLSAN_EARLY_SPEC): Add liblsan_preinit.o for -fsanitize=leak
>   link of executables.
> 
>   * lsan/lsan.h (__lsan_init): Add SANITIZER_INTERFACE_ATTRIBUTE.
>   * lsan/Makefile.am (nodist_toolexeclib_HEADERS): Add
>   liblsan_preinit.o.
>   (lsan_files): Remove lsan_preinit.cc.
>   (liblsan_preinit.o): New rule.
>   * lsan/Makefile.in: Regenerated.
> 
> Modified:
> trunk/gcc/ChangeLog
> trunk/gcc/config/gnu-user.h
> trunk/libsanitizer/ChangeLog
> trunk/libsanitizer/lsan/Makefile.am
> trunk/libsanitizer/lsan/Makefile.in
> trunk/libsanitizer/lsan/lsan.h

I've bootstrapped now successfully after this revision; thanks!

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-20 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #8 from Jakub Jelinek  ---
Author: jakub
Date: Fri Oct 20 08:01:31 2017
New Revision: 253927

URL: https://gcc.gnu.org/viewcvs?rev=253927&root=gcc&view=rev
Log:
PR sanitizer/82595
* lsan/Makefile.am (lsan_files): Remove lsan_preinit.cc.
* lsan/Makefile.in: Regenerated.

Modified:
branches/gcc-7-branch/libsanitizer/ChangeLog
branches/gcc-7-branch/libsanitizer/lsan/Makefile.am
branches/gcc-7-branch/libsanitizer/lsan/Makefile.in

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-20 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #7 from Jakub Jelinek  ---
Author: jakub
Date: Fri Oct 20 07:32:35 2017
New Revision: 253925

URL: https://gcc.gnu.org/viewcvs?rev=253925&root=gcc&view=rev
Log:
PR sanitizer/82595
* config/gnu-user.h (LIBTSAN_EARLY_SPEC): Add libtsan_preinit.o
for -fsanitize=thread link of executables.
(LIBLSAN_EARLY_SPEC): Add liblsan_preinit.o for -fsanitize=leak
link of executables.

* lsan/lsan.h (__lsan_init): Add SANITIZER_INTERFACE_ATTRIBUTE.
* lsan/Makefile.am (nodist_toolexeclib_HEADERS): Add
liblsan_preinit.o.
(lsan_files): Remove lsan_preinit.cc.
(liblsan_preinit.o): New rule.
* lsan/Makefile.in: Regenerated.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/gnu-user.h
trunk/libsanitizer/ChangeLog
trunk/libsanitizer/lsan/Makefile.am
trunk/libsanitizer/lsan/Makefile.in
trunk/libsanitizer/lsan/lsan.h

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-19 Thread egall at gwmail dot gwu.edu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #6 from Eric Gallager  ---
On 10/19/17, jakub at gcc dot gnu.org  wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595
>
> --- Comment #5 from Jakub Jelinek  ---
> BTW, why --without-pic?  What you want to achieve by that?
>

I just copied it from my configure line from my home computer, which
runs i386-apple-darwin9.8.0, where I was trying --without-pic while
trying to fight with -mdynamic-no-pic when overriding BOOT_CFLAGS. I
guess I don't need it when compiling on the compile farm...

> --
> You are receiving this mail because:
> You reported the bug.

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-19 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #5 from Jakub Jelinek  ---
BTW, why --without-pic?  What you want to achieve by that?

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-19 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

Jakub Jelinek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2017-10-19
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #4 from Jakub Jelinek  ---
Created attachment 42401
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=42401&action=edit
gcc8-pr82595.patch

Untested fix.

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-19 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #3 from Eric Gallager  ---
(In reply to Jakub Jelinek from comment #2)
> Well, lsan_preinit.o shouldn't be linked into liblsan.so.*, either we should
> just ignore it completely, or install and link in like asan_preinit.o or
> tsan_preinit.o is.

Is there a workaround I can use until one of these options gets chosen?

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-18 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #2 from Jakub Jelinek  ---
Well, lsan_preinit.o shouldn't be linked into liblsan.so.*, either we should
just ignore it completely, or install and link in like asan_preinit.o or
tsan_preinit.o is.

[Bug sanitizer/82595] bootstrap fails in libsanitizer on powerpc64-unknown-linux-gnu

2017-10-17 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82595

--- Comment #1 from Andrew Pinski  ---
Looks like:
https://gcc.gnu.org/ml/gcc-patches/2013-02/msg01043.html

is no longer part of the sources due to the last merge.