[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[kugan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

kugan at gcc dot gnu.org changed:

   What|Removed |Added

 CC||kugan at gcc dot gnu.org

--- Comment #7 from kugan at gcc dot gnu.org ---
*** Bug 88350 has been marked as a duplicate of this bug. ***

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

Jakub Jelinek  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Jakub Jelinek  ---
Fixed.

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

--- Comment #5 from Jakub Jelinek  ---
Author: jakub
Date: Wed Dec  5 08:26:06 2018
New Revision: 266817

URL: https://gcc.gnu.org/viewcvs?rev=266817=gcc=rev
Log:
PR sanitizer/88333
* cfgexpand.c (expand_stack_vars): If asan_vec is empty, start with
aligning frame offset to ASAN_RED_ZONE_SIZE bytes.

* c-c++-common/asan/pr88333.c: New test.

Added:
trunk/gcc/testsuite/c-c++-common/asan/pr88333.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cfgexpand.c
trunk/gcc/testsuite/ChangeLog

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek  ---
Created attachment 45152
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45152=edit
gcc9-pr88333.patch

Full untested patch.

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

--- Comment #3 from Jakub Jelinek  ---
Untested fix:
--- gcc/cfgexpand.c.jj  2018-11-30 19:59:59.676789914 +0100
+++ gcc/cfgexpand.c 2018-12-04 11:25:55.549672029 +0100
@@ -1124,6 +1124,11 @@ expand_stack_vars (bool (*pred) (size_t)
  && frame_offset.is_constant (_offset)
  && stack_vars[i].size.is_constant ())
{
+ if (data->asan_vec.is_empty ())
+   {
+ alloc_stack_frame_space (0, ASAN_RED_ZONE_SIZE);
+ prev_offset = frame_offset.to_constant ();
+   }
  prev_offset = align_base (prev_offset,
MAX (alignb, ASAN_MIN_RED_ZONE_SIZE),
!FRAME_GROWS_DOWNWARD);

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

Jakub Jelinek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2018-12-04
 Ever confirmed|0   |1

--- Comment #2 from Jakub Jelinek  ---
void bar (int *);

void
foo (void)
{
  int c;
  bar ();
}

ICEs too, including with -fstack-protector-strong -fsanitize=address --param
asan-stack=1 .

[Bug sanitizer/88333] [9 Regression] ice in asan_emit_stack_protection, at asan.c:1574

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88333

Richard Biener  changed:

   What|Removed |Added

 CC||dodji at gcc dot gnu.org,
   ||dvyukov at gcc dot gnu.org,
   ||jakub at gcc dot gnu.org,
   ||kcc at gcc dot gnu.org
  Component|c   |sanitizer
Version|8.0 |9.0
   Target Milestone|--- |9.0
Summary|ice in  |[9 Regression] ice in
   |asan_emit_stack_protection, |asan_emit_stack_protection,
   |at asan.c:1574  |at asan.c:1574

--- Comment #1 from Richard Biener  ---
assuming GCC 9