[Bug target/19041] [4.0 Regression] -fvisibility=hidden causes bad codegen for common symbols

2004-12-16 Thread pinskia at gcc dot gnu dot org 

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-16 
19:12 ---
Patch posted here: http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00814.html, 
this is a 
regression from before Mark implemented his speed up.
There is also a better testcase which does not use the option but attributes 
instead.

-- 
   What|Removed |Added

   Keywords||patch
Summary|-fvisibility=hidden causes  |[4.0 Regression] -
   |bad codegen for common  |fvisibility=hidden causes
   |symbols |bad codegen for common
   ||symbols
   Target Milestone|--- |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19041

[Bug target/19041] [4.0 Regression] -fvisibility=hidden causes bad codegen for common symbols

2004-12-16 Thread pinskia at gcc dot gnu dot org 

--- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-17 
00:24 ---
Fixed.

-- 
   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19041

[Bug target/19041] [4.0 Regression] -fvisibility=hidden causes bad codegen for common symbols

2004-12-16 Thread cvs-commit at gcc dot gnu dot org 

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-17 
00:25 ---
Subject: Bug 19041

CVSROOT:/cvs/gcc
Module name:gcc
Changes by: [EMAIL PROTECTED]   2004-12-17 00:25:17

Modified files:
gcc: ChangeLog 
gcc/config : darwin.c 
gcc/testsuite  : ChangeLog 
Added files:
gcc/testsuite/gcc.dg: visibility-c.c 

Log message:
2004-12-16  Andrew Pinski  [EMAIL PROTECTED]

PR target/19041
* config/darwin.c (machopic_symbol_defined_p): Return false
if the binds local and is a common symbol.

2004-12-16  Andrew Pinski  [EMAIL PROTECTED]

PR target/19041
* gcc.dg/visibility-c.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gccr1=2.6863r2=2.6864
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/darwin.c.diff?cvsroot=gccr1=1.98r2=1.99
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gccr1=1.4770r2=1.4771
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/visibility-c.c.diff?cvsroot=gccr1=NONEr2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19041