[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
-- pinskia at gcc dot gnu dot org changed: What|Removed |Added Target Milestone|4.3.0 |4.2.3 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #8 from uros at gcc dot gnu dot org 2007-10-10 10:02 --- Subject: Bug 33369 Author: uros Date: Wed Oct 10 10:01:53 2007 New Revision: 129201 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=129201 Log: Backport from mainline: 2007-09-14 Uros Bizjak [EMAIL PROTECTED] PR target/33438 * config/i386/i386.md (fmodxf3): Copy operands[2] to temporary register when operands[2] equals operands[1]. (dremxf3): Ditto. 2007-09-10 Uros Bizjak [EMAIL PROTECTED] PR target/33369 * gcc/config/i386/sse.md (ashrmode3): Change op2 mode to SImode. Use 'N' operand constraint for op2. (lshrmode3): Ditto. (ashlmode3): Ditto. (vec_shl_mode): Use const_0_to_255_mul_8_operand predicate for op2. (vec_shr_mode): Use const_0_to_255_mul_8_operand predicate for op2. * gcc/config/i386/i386.c (ix86_expand_builtin) [IX86_BUILTIN_PSLL?128, IX86_BUILTIN_PSRA*?128, IX86_BUILTIN_PSRL?128]: Convert op1 to SImode. testsuite/ChangeLog: Backport from mainline: 2007-09-14 Uros Bizjak [EMAIL PROTECTED] PR target/33438 * gcc.target/i386/pr33438.c: New test. 2007-09-10 Uros Bizjak [EMAIL PROTECTED] PR target/33369 * gcc.dg/vect/pr33369.c: New test. Added: branches/gcc-4_2-branch/gcc/testsuite/gcc.dg/vect/pr33369.c - copied unchanged from r128328, trunk/gcc/testsuite/gcc.dg/vect/pr33369.c branches/gcc-4_2-branch/gcc/testsuite/gcc.target/i386/pr33483.c - copied unchanged from r128502, trunk/gcc/testsuite/gcc.target/i386/pr33483.c Modified: branches/gcc-4_2-branch/gcc/ChangeLog branches/gcc-4_2-branch/gcc/config/i386/i386.c branches/gcc-4_2-branch/gcc/config/i386/i386.md branches/gcc-4_2-branch/gcc/config/i386/sse.md branches/gcc-4_2-branch/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #7 from ubizjak at gmail dot com 2007-09-19 06:20 --- *** Bug 33482 has been marked as a duplicate of this bug. *** -- ubizjak at gmail dot com changed: What|Removed |Added CC||dwarak dot rajagopal at amd ||dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #6 from ubizjak at gmail dot com 2007-09-12 06:52 --- Middle-end was fixed by http://gcc.gnu.org/ml/gcc-cvs/2007-09/msg00406.html -- ubizjak at gmail dot com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
-- jsm28 at gcc dot gnu dot org changed: What|Removed |Added Target Milestone|--- |4.3.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #3 from ubizjak at gmail dot com 2007-09-10 06:32 ---
A 64-bit compiler is required. The problem is, that gcc creates a vector shift
constant for vector shift instruction, without checking if optab can take
vector argument.
This one will also create wrong operand for x86_64:
--cut here--
typedef struct tagPOINT
{
int x;
int y;
} POINT;
void
f (POINT * ptBuf)
{
int i;
for (i = 0; i 4; i++)
{
ptBuf[i].x = ((ptBuf[i].x) 4);
ptBuf[i].y = ((ptBuf[i].y) 4);
}
}
--cut here--
When compiling with 32bit compiler, the shift argument is pushed into memory,
but resulting code is still wrong:
movdqu (%edx), %xmm0
movdqa .LC0, %xmm1
pslld %xmm1, %xmm0
movdqa %xmm0, (%edx)
movdqu 16(%edx), %xmm0
pslld %xmm1, %xmm0
movdqa %xmm0, 16(%edx)
where
.LC0:
.long 4
.long 4
.long 4
.long 4
This problem is similar or the same as PR22480.
--
ubizjak at gmail dot com changed:
What|Removed |Added
BugsThisDependsOn||22480
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #4 from uros at gcc dot gnu dot org 2007-09-10 09:10 --- Subject: Bug 33369 Author: uros Date: Mon Sep 10 09:10:00 2007 New Revision: 128328 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=128328 Log: PR target/33369 * gcc/config/i386/sse.md (ashrmode3): Change op2 mode to SImode. Use 'N' operand constraint for op2. (lshrmode3): Ditto. (ashlmode3): Ditto. (vec_shl_mode): Use const_0_to_255_mul_8_operand predicate for op2. (vec_shr_mode): Use const_0_to_255_mul_8_operand predicate for op2. * gcc/config/i386/i386.c (ix86_expand_builtin) [IX86_BUILTIN_PSLL?128, IX86_BUILTIN_PSRA*?128, IX86_BUILTIN_PSRL?128]: Convert op1 to SImode. testsuite/ChangeLog: PR target/33369 * gcc.dg/vect/pr33369.c: New test. Added: trunk/gcc/testsuite/gcc.dg/vect/pr33369.c Modified: trunk/gcc/ChangeLog trunk/gcc/config/i386/i386.c trunk/gcc/config/i386/i386.md trunk/gcc/config/i386/sse.md trunk/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #5 from ubizjak at gmail dot com 2007-09-10 12:12 --- Some additional discussion (with the fix to SLP vectorizer in a followup) at http://gcc.gnu.org/ml/gcc-patches/2007-09/msg00859.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
[Bug target/33369] [4.3 Regression] suffix or operands invalid for `pslld'
--- Comment #2 from ubizjak at gmail dot com 2007-09-10 05:35 --- Confirmed. -- ubizjak at gmail dot com changed: What|Removed |Added Status|UNCONFIRMED |NEW Component|c |target Ever Confirmed|0 |1 GCC host triplet|x86_64-unknown-linux-gnu|i686-*-*, x86_64-*-* GCC target triplet|i586-unknown-linux-gnu |i686-*-*, x86_64-*-* Last reconfirmed|-00-00 00:00:00 |2007-09-10 05:35:48 date|| Summary|bad sse assembler emitted |[4.3 Regression] suffix or ||operands invalid for `pslld' http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33369
