[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

--- Comment #17 from Martin Liška  ---
(In reply to coypu from comment #16)
> well, the workaround only works for x86 and powerpc.
> Other archs are not calling SUBTARGET_INIT_BUILTINS.
> I'm not sure whether that should be grounds for keeping the ticket open,
> though.

That said, then let it open.

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[coypu at sdf dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

coypu  changed:

   What|Removed |Added

 CC||coypu at sdf dot org

--- Comment #16 from coypu  ---
well, the workaround only works for x86 and powerpc.
Other archs are not calling SUBTARGET_INIT_BUILTINS.
I'm not sure whether that should be grounds for keeping the ticket open,
though.

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

Martin Liška  changed:

   What|Removed |Added

 CC||marxin at gcc dot gnu.org

--- Comment #15 from Martin Liška  ---
Can the bug be marked as resolved?

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[kristerw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

--- Comment #14 from Krister Walfridsson  ---
Author: kristerw
Date: Fri Sep 29 09:38:08 2017
New Revision: 253283

URL: https://gcc.gnu.org/viewcvs?rev=253283=gcc=rev
Log:
2017-09-29  Krister Walfridsson  

Backport from mainline
2017-09-26  Krister Walfridsson  

PR target/39570
* gcc/config/netbsd-protos.h: New file.
* gcc/config/netbsd.c: New file.
* gcc/config/netbsd.h (SUBTARGET_INIT_BUILTINS): Define.
* gcc/config/t-netbsd: New file.
* gcc/config.gcc (tm_p_file): Add netbsd-protos.h.
(tmake_file) Add t-netbsd.
(extra_objs) Add netbsd.o.

Added:
branches/gcc-7-branch/gcc/config/netbsd-protos.h
branches/gcc-7-branch/gcc/config/netbsd.c
branches/gcc-7-branch/gcc/config/t-netbsd
Modified:
branches/gcc-7-branch/gcc/ChangeLog
branches/gcc-7-branch/gcc/config.gcc
branches/gcc-7-branch/gcc/config/netbsd.h

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[kristerw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

--- Comment #13 from Krister Walfridsson  ---
Author: kristerw
Date: Tue Sep 26 21:26:21 2017
New Revision: 253216

URL: https://gcc.gnu.org/viewcvs?rev=253216=gcc=rev
Log:
2017-09-26  Krister Walfridsson  

PR target/39570
* gcc/config/netbsd-protos.h: New file.
* gcc/config/netbsd.c: New file.
* gcc/config/netbsd.h (SUBTARGET_INIT_BUILTINS): Define.
* gcc/config/t-netbsd: New file.
* gcc/config.gcc (tm_p_file): Add netbsd-protos.h.
(tmake_file) Add t-netbsd.
(extra_objs) Add netbsd.o.

Added:
trunk/gcc/config/netbsd-protos.h
trunk/gcc/config/netbsd.c
trunk/gcc/config/t-netbsd
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config.gcc
trunk/gcc/config/netbsd.h

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[kuehro at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

Kai-Uwe Eckhardt kuehro at gmx dot de changed:

   What|Removed |Added

 CC||kuehro at gmx dot de

--- Comment #12 from Kai-Uwe Eckhardt kuehro at gmx dot de ---
Created attachment 34296
  -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34296action=edit
a set of four patches for snapshot 20141214

I have used the darwin files as templates and made the necessary changes. It
reduces test failures from over 15000 (all run tests) to 27 in 3 files (patch
for PR 48244 applied as well).

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[fxcoudert at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

Francois-Xavier Coudert fxcoudert at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2011-11-07
 CC||fxcoudert at gcc dot
   ||gnu.org
 Ever Confirmed|0   |1

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

Tobias Burnus burnus at gcc dot gnu.org changed:

   What|Removed |Added

 CC||cato at df dot lth.se

--- Comment #11 from Tobias Burnus burnus at gcc dot gnu.org 2011-02-22 
13:25:53 UTC ---
I just checked
CC the one of the two NetBSD maintainers who has been last active...

 * * *

  CVS_RSH=ssh  cvs -d anon...@anoncvs.netbsd.org:/cvsroot co src/lib/libm/

and libm/compat contains only compat_cabsf and compat_cabs.c, which use a
struct instead of complex. That those are the only math-related changes, one
sees if on greps for __RENAME in
  CVS_RSH=ssh  cvs -d anon...@anoncvs.netbsd.org:/cvsroot co src/include/
i.e. complex.h contains:

#ifndef __LIBM0_SOURCE__
/* avoid conflict with historical cabs(struct complex) */
double cabs(double complex) __RENAME(__c99_cabs);
float cabsf(float complex) __RENAME(__c99_cabsf);
#endif

 * * *

Regarding the patch (cf. comment 3): Darwin has the files darwin.c in
./gcc/config/, which is included via ./gcc/config.gcc's
  tm_p_file=${tm_p_file} darwin-protos.h
  target_gtfiles=\$(srcdir)/config/darwin.c
  extra_objs=darwin.o
One probably needs to do likewise for *-*-netbsd*).

In darwin.c, see darwin_patch_builtins and darwin_patch_builtin.

Those are used via SUBTARGET_INIT_BUILTINS in some ./gcc/config/* files.

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

Tobias Burnus burnus at gcc dot gnu.org changed:

   What|Removed |Added

 CC||burnus at gcc dot gnu.org

--- Comment #10 from Tobias Burnus burnus at gcc dot gnu.org 2011-02-21 
09:48:08 UTC ---
(In reply to comment #9)
 Yep, that would have worked.  Thanks for the clue.

Is there any update on this issue?

(Cf. also bug 47716 comment 6
 and http://www.mailinglistarchive.com/fort...@gcc.gnu.org/msg17593.html )

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[fxcoudert at gcc dot gnu dot org]

--- Comment #6 from fxcoudert at gcc dot gnu dot org  2009-03-28 13:09 
---
Switch component to target, as this is target-specific behaviour not specific
to fortran (you'd have the same thing with C if you use __builtin_cabs() and
__builtin_cabsf().


-- 

fxcoudert at gcc dot gnu dot org changed:

   What|Removed |Added

  Component|fortran |target


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[aran at 100acres dot us]

--- Comment #7 from aran at 100acres dot us  2009-03-28 18:13 ---
(In reply to comment #5)
 Another fix is to #undef TARGET_C99_FUNCTIONS as obviously netbsd is another
 OS without a clue ...
 

Please explain how an OS with a clue would handle this problem.  Older binaries
that use the pre-c99 complex structure links to the existing linker symbols,
cabs and cabsf.  Changing the meaning of these symbols to the c99 meaning would
break these legacy programs.  It seems cluefull to decorate these symbols with
__c99_ and provide a rename in the header.  What would be a better solution?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[jakub at gcc dot gnu dot org]

--- Comment #8 from jakub at gcc dot gnu dot org  2009-03-28 18:30 ---
Symbol versioning, obviously.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570

[Bug target/39570] cabs and cabsf are named differently on NetBSD 5

[aran at 100acres dot us]

--- Comment #9 from aran at 100acres dot us  2009-03-28 19:38 ---
(In reply to comment #8)
 Symbol versioning, obviously.
 
Yep, that would have worked.  Thanks for the clue.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39570