[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 Martin Liška changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #16 from Martin Liška --- Let's resolve that.
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #15 from Mike Stump --- Can the bug be marked as resolved? :-)
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #14 from Iain Sandoe --- Author: iains Date: Mon Nov 26 19:49:19 2018 New Revision: 266478 URL: https://gcc.gnu.org/viewcvs?rev=266478=gcc=rev Log: darwin - backport r263763 to fix PR81033 2018-11-26 Iain Sandoe Backport from mainline 2018-08-22 Iain Sandoe PR bootstrap/81033 PR target/81733 PR target/52795 * gcc/dwarf2out.c (FUNC_SECOND_SECT_LABEL): New. (dwarf2out_switch_text_section): Generate a local label for the second function sub-section and apply it as the second FDE start label. * gcc/final.c (final_scan_insn_1): Emit second FDE label after the second sub-section start. Modified: branches/gcc-7-branch/gcc/ChangeLog branches/gcc-7-branch/gcc/dwarf2out.c branches/gcc-7-branch/gcc/final.c
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #13 from Iain Sandoe --- (In reply to Martin Liška from comment #12) > Can the bug be marked as resolved? I need to ask RM permission to back-port the fix for 81033 to 7 branch, which would clear this bug on all open branches.
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 Martin Liška changed: What|Removed |Added CC||marxin at gcc dot gnu.org --- Comment #12 from Martin Liška --- Can the bug be marked as resolved?
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #11 from Iain Sandoe --- Author: iains Date: Sun Oct 28 22:56:02 2018 New Revision: 265576 URL: https://gcc.gnu.org/viewcvs?rev=265576=gcc=rev Log: fix PR81033 and associated. 2018-10-28 Iain Sandoe Backport from mainline 2018-08-22 Iain Sandoe PR bootstrap/81033 PR target/81733 PR target/52795 * gcc/dwarf2out.c (FUNC_SECOND_SECT_LABEL): New. (dwarf2out_switch_text_section): Generate a local label for the second function sub-section and apply it as the second FDE start label. * gcc/final.c (final_scan_insn_1): Emit second FDE label after the second sub-section start. Modified: branches/gcc-8-branch/gcc/ChangeLog branches/gcc-8-branch/gcc/dwarf2out.c branches/gcc-8-branch/gcc/final.c
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #10 from Iain Sandoe --- Author: iains Date: Wed Aug 22 11:37:02 2018 New Revision: 263763 URL: https://gcc.gnu.org/viewcvs?rev=263763=gcc=rev Log: Fix FDE labels for Darwin gcc/ PR bootstrap/81033 PR target/81733 PR target/52795 * gcc/dwarf2out.c (FUNC_SECOND_SECT_LABEL): New. (dwarf2out_switch_text_section): Generate a local label for the second function sub-section and apply it as the second FDE start label. * gcc/final.c (final_scan_insn_1): Emit second FDE label after the second sub-section start. Modified: trunk/gcc/ChangeLog trunk/gcc/dwarf2out.c trunk/gcc/final.c
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 Iain Sandoe changed: What|Removed |Added See Also||https://gcc.gnu.org/bugzill ||a/show_bug.cgi?id=81033 --- Comment #9 from Iain Sandoe --- The fix attached to 81033 also resolves this issue, and is much less intrusive than #c6 (which is no longer applicable - obsoleted).
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #8 from Iain Sandoe --- (In reply to Iain Sandoe from comment #6) > Created attachment 39664 [details] > Reorganize hot/cold output to allow atoms to be properly detected. > > > This is a proof-of-principle patch that reorganizes the output of the > hot/cold partitions so that section switches are only made when needed. > Although it was done to make the atom detection work with ld64, IMO - it > makes the asm more readable for linux too... but that's a side-effect of > course. > > This is a very invasive patch, because it touches debug output - so some way > to test more widely would be needed. However, worth testing as a resolution > for this problem. NOTE: this is intended to apply on top of the patch set for PR71767.
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #7 from Iain Sandoe --- (In reply to Dominique d'Humieres from comment #5) > This PR seems fixed on x86_64-apple-darwin14.5 with Xcode 7. I don't think it's actually "fixed" as such, the newer linkers are capable of handling symbol aliasing - so probably there's no reported error/warning but likely the atoms are still not correctly detected (however, I've not proved this assertion).
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #6 from Iain Sandoe --- Created attachment 39664 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=39664=edit Reorganize hot/cold output to allow atoms to be properly detected. This is a proof-of-principle patch that reorganizes the output of the hot/cold partitions so that section switches are only made when needed. Although it was done to make the atom detection work with ld64, IMO - it makes the asm more readable for linux too... but that's a side-effect of course. This is a very invasive patch, because it touches debug output - so some way to test more widely would be needed. However, worth testing as a resolution for this problem.
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #5 from Dominique d'Humieres --- This PR seems fixed on x86_64-apple-darwin14.5 with Xcode 7.
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795 --- Comment #4 from Dominique d'Humieres dominiq at lps dot ens.fr --- As said in pr59541 comment 1, r206070 introduced new failures of the same kind with -m64: g++.dg/tree-prof/partition1.C gcc.dg/tree-prof/20041218-1.c gcc.dg/tree-prof/crossmodule-indircall-1.c gcc.dg/tree-prof/pr49299-1.c gcc.dg/tree-prof/pr49299-2.c
[Bug target/52795] FAIL: gcc.dg/tree-prof/pr34999.c compilation, -fprofile-use -D_PROFILE_USE on {x86_64,i386}-apple-darwin{10,11} at -m64
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52795
Dominique d'Humieres dominiq at lps dot ens.fr changed:
What|Removed |Added
Target|{x86_64,i386}-apple-darwin{ |{x86_64,i386}-apple-darwin1
|10,11) |*
Host|{x86_64,i386}-apple-darwin{ |{x86_64,i386}-apple-darwin1
|10,11) |*
Build|{x86_64,i386}-apple-darwin{ |{x86_64,i386}-apple-darwin1
|10,11) |*
--- Comment #3 from Dominique d'Humieres dominiq at lps dot ens.fr ---
Also seen with x86_64-apple-darwin13.
