[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #11 from Georg-Johann Lay gjl at gcc dot gnu.org --- (In reply to Jorn Wolfgang Rennecke from comment #10) Created attachment 33768 [details] patch for dtor direction I have this patch for fixing the direction of the dtor execution, but I got stuck trying to write a testcase. That won't work. I'll install a working implementation soon so you can proceed.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #12 from Georg-Johann Lay gjl at gcc dot gnu.org --- Author: gjl Date: Wed Oct 22 10:46:11 2014 New Revision: 216551 URL: https://gcc.gnu.org/viewcvs?rev=216551root=gccview=rev Log: PR target/63223 * config/avr/lib1funcs.S (__do_global_dtors): Reverse execution order to first...last. Modified: branches/gcc-4_9-branch/libgcc/ChangeLog branches/gcc-4_9-branch/libgcc/config/avr/lib1funcs.S
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #8 from Georg-Johann Lay gjl at gcc dot gnu.org --- (In reply to Jorn Wolfgang Rennecke from comment #4) (In reply to Georg-Johann Lay from comment #1) do_global_dtors is supposed to start at the start and increment from there. I see it used to be half-way wrong and half-way correct. (Starting at the start, decrementing for __AVR_HAVE_ELPM__, incrementing otherwise.) However, you now made it all the way use an incorrect order - starting at the end and incrementing from there. Is there a rationale for this? The old code was broken as it decremented begainning at the start address. The flaw never came apparent for __dtors_start = __dtors_end or with simulators that terminated in exit. The new code uses the same traverse direction like __do_global_ctors. Is the order of .ctors, .dtors defined in any way? I.e. how do you express that constructor A must run before constructor B in the C program? Same for destructors.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #9 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- (In reply to Georg-Johann Lay from comment #8) (In reply to Jorn Wolfgang Rennecke from comment #4) (In reply to Georg-Johann Lay from comment #1) do_global_dtors is supposed to start at the start and increment from there. I see it used to be half-way wrong and half-way correct. (Starting at the start, decrementing for __AVR_HAVE_ELPM__, incrementing otherwise.) However, you now made it all the way use an incorrect order - starting at the end and incrementing from there. Is there a rationale for this? The old code was broken as it decremented begainning at the start address. The flaw never came apparent for __dtors_start = __dtors_end or with simulators that terminated in exit. The new code uses the same traverse direction like __do_global_ctors. Is the order of .ctors, .dtors defined in any way? I.e. how do you express that constructor A must run before constructor B in the C program? Same for destructors. The C++ standard says that destructors have to run in reverse order of completion of constructors. crtstuff.c:__do_global_ctors_aux starts at the first constructor, and increments from there; crtstuff.c:__do_global_dtors_aux starts at the last destructor, and decrements from there.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #10 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- Created attachment 33768 -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=33768action=edit patch for dtor direction I have this patch for fixing the direction of the dtor execution, but I got stuck trying to write a testcase.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org changed: What|Removed |Added CC||amylaar at gcc dot gnu.org --- Comment #4 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- (In reply to Georg-Johann Lay from comment #1) Author: gjl Date: Thu Sep 11 08:08:17 2014 New Revision: 215152 URL: https://gcc.gnu.org/viewcvs?rev=215152root=gccview=rev Log: gcc/ PR target/63223 * config/avr/avr.md (*tablejump.3byte-pc): New insn. (*tablejump): Restrict to !AVR_HAVE_EIJMP_EICALL. Add void clobber. (casesi): Expand to *tablejump.3byte-pc if AVR_HAVE_EIJMP_EICALL. libgcc/ PR target/63223 * config/avr/libgcc.S (__tablejump2__): Rewrite to use RAMPZ, ELPM and R24 as needed. Make work for all devices and .text locations. (__do_global_ctors, __do_global_dtors): Use word addresses. do_global_dtors is supposed to start at the start and increment from there. I see it used to be half-way wrong and half-way correct. (Starting at the start, decrementing for __AVR_HAVE_ELPM__, incrementing otherwise.) However, you now made it all the way use an incorrect order - starting at the end and incrementing from there. Is there a rationale for this?
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #5 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- I also observe that the cpi/cpc/brne idiom that is used throughout - before and after your patch - is nonsentical.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #6 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- (In reply to Jorn Wolfgang Rennecke from comment #4) However, you now made it all the way use an incorrect order - starting at the end and incrementing from there. Oops, I mean decrementing from there. But the point still stands.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #7 from Jorn Wolfgang Rennecke amylaar at gcc dot gnu.org --- (In reply to Jorn Wolfgang Rennecke from comment #5) I also observe that the cpi/cpc/brne idiom that is used throughout - before and after your patch - is nonsentical. Oops, I drew conclusions from the operation short description of CPC that are not borne out by the detailed flag setting description.
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 Georg-Johann Lay gjl at gcc dot gnu.org changed: What|Removed |Added Target||avr Priority|P3 |P4 Assignee|unassigned at gcc dot gnu.org |gjl at gcc dot gnu.org
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #1 from Georg-Johann Lay gjl at gcc dot gnu.org --- Author: gjl Date: Thu Sep 11 08:08:17 2014 New Revision: 215152 URL: https://gcc.gnu.org/viewcvs?rev=215152root=gccview=rev Log: gcc/ PR target/63223 * config/avr/avr.md (*tablejump.3byte-pc): New insn. (*tablejump): Restrict to !AVR_HAVE_EIJMP_EICALL. Add void clobber. (casesi): Expand to *tablejump.3byte-pc if AVR_HAVE_EIJMP_EICALL. libgcc/ PR target/63223 * config/avr/libgcc.S (__tablejump2__): Rewrite to use RAMPZ, ELPM and R24 as needed. Make work for all devices and .text locations. (__do_global_ctors, __do_global_dtors): Use word addresses. (__tablejump__, __tablejump_elpm__): Remove functions. * t-avr (LIB1ASMFUNCS): Remove _tablejump, _tablejump_elpm. Add _tablejump2. (XICALL, XIJMP): New macros. Modified: trunk/gcc/ChangeLog trunk/gcc/config/avr/avr.md trunk/libgcc/ChangeLog trunk/libgcc/config/avr/lib1funcs.S trunk/libgcc/config/avr/t-avr
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 --- Comment #2 from Georg-Johann Lay gjl at gcc dot gnu.org --- Author: gjl Date: Thu Sep 11 08:19:45 2014 New Revision: 215153 URL: https://gcc.gnu.org/viewcvs?rev=215153root=gccview=rev Log: gcc/ Backport from 2014-09-11 trunk r215152. PR target/63223 * config/avr/avr.md (*tablejump.3byte-pc): New insn. (*tablejump): Restrict to !AVR_HAVE_EIJMP_EICALL. Add void clobber. (casesi): Expand to *tablejump.3byte-pc if AVR_HAVE_EIJMP_EICALL. libgcc/ Backport from 2014-09-11 trunk r215152. PR target/63223 * config/avr/libgcc.S (__tablejump2__): Rewrite to use RAMPZ, ELPM and R24 as needed. Make work for all devices and .text locations. (__do_global_ctors, __do_global_dtors): Use word addresses. (__tablejump__, __tablejump_elpm__): Remove functions. * t-avr (LIB1ASMFUNCS): Remove _tablejump, _tablejump_elpm. Add _tablejump2. (XICALL, XIJMP): New macros. Modified: branches/gcc-4_9-branch/gcc/ChangeLog branches/gcc-4_9-branch/gcc/config/avr/avr.md branches/gcc-4_9-branch/libgcc/ChangeLog branches/gcc-4_9-branch/libgcc/config/avr/lib1funcs.S branches/gcc-4_9-branch/libgcc/config/avr/t-avr
[Bug target/63223] [avr] Make jumptables work with -Wl,--section-start,.text=
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63223 Georg-Johann Lay gjl at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Target Milestone|--- |4.9.2 --- Comment #3 from Georg-Johann Lay gjl at gcc dot gnu.org --- Fixed in 4.9.2.
