[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 Jonathan Wakely changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Jonathan Wakely --- Fixed for 8.4 and 9.2
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 --- Comment #8 from Jonathan Wakely --- Author: redi Date: Sat May 11 11:38:51 2019 New Revision: 271095 URL: https://gcc.gnu.org/viewcvs?rev=271095=gcc=rev Log: PR libstdc++/81266 fix std::thread::native_handle_type test The test uses remove_pointer because in most cases native_handle_type is a pointer to the actual type that the C++ class contains. However, for std::thread, native_handle_type is the same type as the type contained in std::thread, and so remove_pointer is not needed. On targets where pthread_t is a pointer type remove_pointer is not a no-op, instead it transforms pthread_t and causes the test to fail. The fix is to not apply remove_pointer when testing std::thread. Backport from mainline 2019-05-10 Jonathan Wakely PR libstdc++/81266 * testsuite/util/thread/all.h: Do not use remove_pointer for std::thread::native_handle_type. Modified: branches/gcc-8-branch/libstdc++-v3/ChangeLog branches/gcc-8-branch/libstdc++-v3/testsuite/util/thread/all.h
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 --- Comment #7 from Jonathan Wakely --- Author: redi Date: Sat May 11 11:35:59 2019 New Revision: 271094 URL: https://gcc.gnu.org/viewcvs?rev=271094=gcc=rev Log: PR libstdc++/81266 fix std::thread::native_handle_type test The test uses remove_pointer because in most cases native_handle_type is a pointer to the actual type that the C++ class contains. However, for std::thread, native_handle_type is the same type as the type contained in std::thread, and so remove_pointer is not needed. On targets where pthread_t is a pointer type remove_pointer is not a no-op, instead it transforms pthread_t and causes the test to fail. The fix is to not apply remove_pointer when testing std::thread. Backport from mainline 2019-05-10 Jonathan Wakely PR libstdc++/81266 * testsuite/util/thread/all.h: Do not use remove_pointer for std::thread::native_handle_type. Modified: branches/gcc-9-branch/libstdc++-v3/ChangeLog branches/gcc-9-branch/libstdc++-v3/testsuite/util/thread/all.h
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 Jonathan Wakely changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 Iain Sandoe changed: What|Removed |Added Target Milestone|--- |8.4 --- Comment #6 from Iain Sandoe --- Fixed on trunk, needed on 9 and 8.
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 --- Comment #5 from Jonathan Wakely --- Author: redi Date: Fri May 10 21:41:23 2019 New Revision: 271080 URL: https://gcc.gnu.org/viewcvs?rev=271080=gcc=rev Log: PR libstdc++/81266 fix std::thread::native_handle_type test The test uses remove_pointer because in most cases native_handle_type is a pointer to the actual type that the C++ class contains. However, for std::thread, native_handle_type is the same type as the type contained in std::thread, and so remove_pointer is not needed. On targets where pthread_t is a pointer type remove_pointer is not a no-op, instead it transforms pthread_t and causes the test to fail. The fix is to not apply remove_pointer when testing std::thread. PR libstdc++/81266 * testsuite/util/thread/all.h: Do not use remove_pointer for std::thread::native_handle_type. Modified: trunk/libstdc++-v3/ChangeLog trunk/libstdc++-v3/testsuite/util/thread/all.h
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 --- Comment #4 from Iain Sandoe --- Created attachment 46341 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46341=edit updated patch I'm testing this - the posted one didn't build on Darwin.
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 Alexandre Oliva changed: What|Removed |Added CC||aoliva at gcc dot gnu.org --- Comment #3 from Alexandre Oliva --- https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00493.html has a patch
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 Iain Sandoe changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2018-12-03 Ever confirmed|0 |1 --- Comment #2 from Iain Sandoe --- (In reply to Jonathan Wakely from comment #1) > This was previously only run for GNU/Linux, Solaris and AIX, but is now > enabled for all pthreads targets. I don't think this particular test will > ever pass for targets where is_pointer is true. So - just skip this on Darwin, or invent some new target supports test for pthread-non-pointer? (not entirely sure that would be unequivocally trivial)
[Bug target/81266] FAIL: 30_threads/thread/native_handle/typesizes.cc execution test on darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81266 --- Comment #1 from Jonathan Wakely --- This was previously only run for GNU/Linux, Solaris and AIX, but is now enabled for all pthreads targets. I don't think this particular test will ever pass for targets where is_pointer is true.
