[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

--- Comment #9 from Jakub Jelinek  ---
Author: jakub
Date: Fri Jun 22 20:51:42 2018
New Revision: 261930

URL: https://gcc.gnu.org/viewcvs?rev=261930=gcc=rev
Log:
Backported from mainline
2018-03-22  Jakub Jelinek  

PR sanitizer/85018
* dwarf2asm.c (dw2_output_indirect_constant_1): Set
DECL_INITIAL (decl) to decl at the end.
* varasm.c (use_blocks_for_decl_p): Revert the 2018-03-20 change,
adjust the comment.

2018-03-20  Jakub Jelinek  

PR target/84990
* dwarf2asm.c (dw2_output_indirect_constant_1): Temporarily turn off
flag_section_anchors.
* varasm.c (use_blocks_for_decl_p): Remove hack for
dw2_force_const_mem.

2018-03-19  Jakub Jelinek  

PR sanitizer/78651
* dwarf2asm.c: Include fold-const.c.
(dw2_output_indirect_constant_1): Set DECL_INITIAL (decl) to ADDR_EXPR
of decl rather than decl itself.

2018-03-19  Maxim Ostapenko  

PR sanitizer/78651
* dwarf2asm.c (dw2_output_indirect_constant_1): Disable ASan before
calling assemble_variable.

* g++.dg/asan/pr78651.C: New test.

Added:
branches/gcc-7-branch/gcc/testsuite/g++.dg/asan/pr78651.C
Modified:
branches/gcc-7-branch/gcc/ChangeLog
branches/gcc-7-branch/gcc/dwarf2asm.c
branches/gcc-7-branch/gcc/testsuite/ChangeLog
branches/gcc-7-branch/gcc/varasm.c

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

Andreas Schwab  changed:

   What|Removed |Added

 CC||doko at gcc dot gnu.org

--- Comment #8 from Andreas Schwab  ---
*** Bug 85010 has been marked as a duplicate of this bug. ***

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

Jakub Jelinek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Jakub Jelinek  ---
Both powerpc64le-linux and aarch64-linux bootstrapped for me with this change
with --enable-checking=release and Ada enabled.
Sorry for the breakage.

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

--- Comment #6 from Jakub Jelinek  ---
Author: jakub
Date: Tue Mar 20 13:00:48 2018
New Revision: 258681

URL: https://gcc.gnu.org/viewcvs?rev=258681=gcc=rev
Log:
PR target/84990
* dwarf2asm.c (dw2_output_indirect_constant_1): Temporarily turn off
flag_section_anchors.
* varasm.c (use_blocks_for_decl_p): Remove hack for
dw2_force_const_mem.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/dwarf2asm.c
trunk/gcc/varasm.c

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

--- Comment #5 from rguenther at suse dot de  ---
On Tue, 20 Mar 2018, jakub at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990
> 
> --- Comment #4 from Jakub Jelinek  ---
> Created attachment 43718
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=43718=edit
> gcc8-pr84990.patch
> 
> Can't reproduce with a cross, but just from the ICE line I guess this could 
> fix
> it.  There is no point to use section-anchors for these artificial variables,
> and we weren't using them before either, just through a hack for the
> DECL_INITIAL (decl) == decl which I've changed.

LGTM.

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

--- Comment #4 from Jakub Jelinek  ---
Created attachment 43718
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=43718=edit
gcc8-pr84990.patch

Can't reproduce with a cross, but just from the ICE line I guess this could fix
it.  There is no point to use section-anchors for these artificial variables,
and we weren't using them before either, just through a hack for the
DECL_INITIAL (decl) == decl which I've changed.

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

--- Comment #3 from Andreas Schwab  ---
And I didn't use --enable-checking=release on aarch64.

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

Andreas Schwab  changed:

   What|Removed |Added

 Target|powerpc64le-linux,  |powerpc64*-*-*, aarch64-*-*
   |powerpc64-linux |

--- Comment #2 from Andreas Schwab  ---
Same error on aarch64.

[Bug target/84990] [8 Regression] Boostrap broken with --enable-checking=release and Ada

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84990

Richard Biener  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org
   Target Milestone|--- |8.0

--- Comment #1 from Richard Biener  ---
See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78651#c8