[Bug target/85978] config/frv/frv.c: 3 * iffy code in switch

2019-09-30 Thread nickc at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85978

Nick Clifton  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nick Clifton  ---
Hi David,

  I think that it will be better to add the missing break statements and allow
the nested switches to correctly exit to the end of the function.  In that way
the code is clearly only looking for costs that are better than the default
HIGH_COST.

Cheers
  Nick

[Bug target/85978] config/frv/frv.c: 3 * iffy code in switch

2019-09-30 Thread nickc at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85978

--- Comment #2 from Nick Clifton  ---
Author: nickc
Date: Mon Sep 30 15:27:14 2019
New Revision: 276306

URL: https://gcc.gnu.org/viewcvs?rev=276306=gcc=rev
Log:
Fix compile time warning about building the FRV backend by adding missing break
statements to the switches in frv_register_move_cost.

PR target/85978
* config/frv/frv.c (frv_register_move_cost): Add break statements
to avoid falling through to the wrong cases.  Tidy code.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/frv/frv.c

[Bug target/85978] config/frv/frv.c: 3 * iffy code in switch

2019-09-27 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85978

Eric Gallager  changed:

   What|Removed |Added

 CC||aoliva at gcc dot gnu.org,
   ||nickc at gcc dot gnu.org

--- Comment #1 from Eric Gallager  ---
cc-ing frv maintainers