[Bug target/94136] GCC doc for built-in function __builtin___clear_cache() not 100% correct

2021-04-29 Thread palmer at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94136

palmer at gcc dot gnu.org changed:

   What|Removed |Added

 CC||palmer at gcc dot gnu.org

--- Comment #4 from palmer at gcc dot gnu.org ---
IMO this isn't actually a documentation bug, it's a functionality bug.  I've
sent a patch, sorry it took a while -- I hadn't seen this one, but just
stumbled across Jim's mostly unrelated email and happened to find this bug.

[Bug target/94136] GCC doc for built-in function __builtin___clear_cache() not 100% correct

2020-03-11 Thread wilson at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94136

Jim Wilson  changed:

   What|Removed |Added

 CC||wilson at gcc dot gnu.org

--- Comment #3 from Jim Wilson  ---
Another possible issue is that __clear_cache is defined in the libgcc docs. 
But only some platforms are defining CLEAR_INSN_CACHE so only some targets have
a usable __clear_cache function.

[Bug target/94136] GCC doc for built-in function __builtin___clear_cache() not 100% correct

2020-03-11 Thread andrew at sifive dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94136

Andrew Waterman  changed:

   What|Removed |Added

 CC||andrew at sifive dot com

--- Comment #2 from Andrew Waterman  ---
The problematic sentence in the docs is "Otherwise either instructions
are emitted in-line to clear the instruction cache or a call to the
__clear_cache function in libgcc is made."

The problem is that the RISC-V port emits a call to a function, but
that function isn't named "__clear_cache."  RISC-V is not unique in
this respect, though: the MIPS port uses a variety of function names
that can be overridden on the command line.

My recommendation is to replace the problematic sentence something
like: "Otherwise, a target-dependent code sequence effects the
requested instruction-stream synchronization operation.  On some
targets, this sequence invokes the __clear_cache function in libgcc."
This formulation maintains the sentiment of the original, while
admitting the RISC-V and MIPS behavior.

[Bug target/94136] GCC doc for built-in function __builtin___clear_cache() not 100% correct

2020-03-11 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94136

Richard Biener  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords||documentation
  Component|other   |target
 Target||riscv
   Last reconfirmed||2020-03-11
 Ever confirmed|0   |1

--- Comment #1 from Richard Biener  ---
Confirmed.