[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[ebotcazou at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Eric Botcazou  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Eric Botcazou  ---
Fixed everywhere.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

--- Comment #5 from CVS Commits  ---
The releases/gcc-10 branch has been updated by Eric Botcazou
:

https://gcc.gnu.org/g:61382972d005a76bc9e5d1dd66c6b515f62499d7

commit r10-9130-g61382972d005a76bc9e5d1dd66c6b515f62499d7
Author: Eric Botcazou 
Date:   Tue Dec 8 09:19:36 2020 +0100

Fix PR target/96470

This forces the scalarization of the testcase on PowerPC.

gcc/testsuite/ChangeLog:
PR target/96470
* gnat.dg/opt39.adb: Add dg-additional-options for PowerPC.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[cvs-commit at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

--- Comment #4 from CVS Commits  ---
The master branch has been updated by Eric Botcazou :

https://gcc.gnu.org/g:c1370f8c0d0760714fe77d55c1fa16045ffa69f2

commit r11-5837-gc1370f8c0d0760714fe77d55c1fa16045ffa69f2
Author: Eric Botcazou 
Date:   Tue Dec 8 09:19:36 2020 +0100

Fix PR target/96470

This forces the scalarization of the testcase on PowerPC.

gcc/testsuite/ChangeLog:
PR target/96470
* gnat.dg/opt39.adb: Add dg-additional-options for PowerPC.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[rguenth at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Richard Biener  changed:

   What|Removed |Added

   Priority|P3  |P2

--- Comment #3 from Richard Biener  ---
Via

  /* If the user didn't set PARAM_SRA_MAX_SCALARIZATION_SIZE_<...>,
 fall back to a target default.  */
  unsigned HOST_WIDE_INT max_scalarization_size
= get_move_ratio (optimize_speed_p) * UNITS_PER_WORD;

and rs6000 not altering MOVE_RATIO from its default

/* If a memory-to-memory move would take MOVE_RATIO or more simple
   move-instruction sequences, we will do a cpymem or libcall instead.  */

#ifndef MOVE_RATIO
#if defined (HAVE_cpymemqi) || defined (HAVE_cpymemhi) || defined
(HAVE_cpymemsi) || defined (HAVE_cpymemdi) || defined (HAVE_cpymemti)
#define MOVE_RATIO(speed) 2
#else
/* If we are optimizing for space (-Os), cut down the default move ratio.  */
#define MOVE_RATIO(speed) ((speed) ? 15 : 3)
#endif
#endif

and rs6000 having cpymem.

[Bug target/96470] [10/11 regression] gnat.dg/opt39.adb is not scalarized

[ebotcazou at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96470

Eric Botcazou  changed:

   What|Removed |Added

 CC||ebotcazou at gcc dot gnu.org
 Ever confirmed|0   |1
   Last reconfirmed||2020-09-28
  Component|testsuite   |target
 Status|UNCONFIRMED |NEW
Summary|[10 regression] |[10/11 regression]
   |gnat.dg/opt39.adb fails |gnat.dg/opt39.adb is not
   |since r10-917   |scalarized

--- Comment #2 from Eric Botcazou  ---
The difference is:

Rejected (3173): not aggregate: a
Rejected (3174): not aggregate: i
Rejected (3175): not aggregate: aL
Candidate (3180): tmp
Too big to totally scalarize: tmp (UID: 3180)

because max_scalarization_size == 128 on PowerPC64 (it's 1088 on x86-64) in the
analyze_all_variable_accesses function.  So I can force the test to pass on
PowerPC64 by means of --param=sra-max-scalarization-size-Ospeed=32 but the
default max_scalarization_size seems to be unduly low on PowerPC64 (just 2
words).