[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 Jeffrey A. Law changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jeffrey A. Law --- Fixed on the trunk.
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 --- Comment #6 from Stefan Schulze Frielinghaus --- Thanks for confirmation! Bootstrap and regtest are still running on x86 as well as IBM Z. I will commit the attached patch assuming successful runs.
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 --- Comment #5 from Stefan Schulze Frielinghaus --- Created attachment 51606 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51606=edit Fix determining precission of reduction_var
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 Richard Biener changed: What|Removed |Added Priority|P3 |P1 Target Milestone|--- |12.0 Keywords||ice-on-valid-code
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 Jeffrey A. Law changed: What|Removed |Added Last reconfirmed||2021-10-14 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Jeffrey A. Law --- And just an FYI. That patch fixes the problem on all three affected platforms. Assuming it bootstraps and regression tests, consider it pre-approved for the trunk. Thanks
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 --- Comment #3 from Jeffrey A. Law --- No worries. This is why we have testing systems.
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752
--- Comment #2 from Stefan Schulze Frielinghaus
---
It looks like I missed to take the TREE_TYPE of reduction_var. I just did a
quick test with
diff --git a/gcc/tree-loop-distribution.c b/gcc/tree-loop-distribution.c
index fb9250031b5..0559b9c47d7 100644
--- a/gcc/tree-loop-distribution.c
+++ b/gcc/tree-loop-distribution.c
@@ -3430,7 +3430,7 @@ generate_strlen_builtin_using_rawmemchr (loop_p loop,
tree reduction_var,
static bool
reduction_var_overflows_first (tree reduction_var, tree load_type)
{
- widest_int n2 = wi::lshift (1, TYPE_PRECISION (reduction_var));;
+ widest_int n2 = wi::lshift (1, TYPE_PRECISION (TREE_TYPE (reduction_var)));;
widest_int m2 = wi::lshift (1, TYPE_PRECISION (ptrdiff_type_node) - 1);
widest_int s = wi::to_widest (TYPE_SIZE_UNIT (load_type));
return wi::ltu_p (n2, wi::udiv_trunc (m2, s));
@@ -3681,7 +3681,7 @@ loop_distribution::transform_reduction_loop (loop_p loop)
&& ((TYPE_PRECISION (sizetype) >= TYPE_PRECISION (ptr_type_node) - 1
&& TYPE_PRECISION (ptr_type_node) >= 32)
|| (TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (reduction_var))
- && TYPE_PRECISION (reduction_var) <= TYPE_PRECISION
(sizetype)))
+ && TYPE_PRECISION (TREE_TYPE (reduction_var)) <=
TYPE_PRECISION (sizetype)))
&& builtin_decl_implicit (BUILT_IN_STRLEN))
generate_strlen_builtin (loop, reduction_var, load_iv.base,
reduction_iv.base, loc);
successfully. It's getting late here. I will come back to this tomorrow
morning. Sorry for the inconvenience.
[Bug tree-optimization/102752] [12 Regression] Recent change to ldist causing ICE on msp430-elf, rl78-elf, and xstormy16-elf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102752 --- Comment #1 from Jeffrey A. Law --- gcc.dg/tree-ssa/pr45427.c shows the same issue.
