[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 --- Comment #10 from Sergei Trofimovich --- I confirm the change fixed build for me (it also needed unrelated workaround for https://gcc.gnu.org/PR110697). Thank you!
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Kewen Lin changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Kewen Lin --- Should be fixed on trunk.
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 --- Comment #8 from CVS Commits --- The master branch has been updated by Kewen Lin : https://gcc.gnu.org/g:081c623ca88dc53abe34b5f5661e79fcde800cef commit r14-2560-g081c623ca88dc53abe34b5f5661e79fcde800cef Author: Kewen Lin Date: Mon Jul 17 03:44:59 2023 -0500 vect: Initialize new_temp to avoid false positive warning [PR110652] As PR110652 and its duplicate PRs show, there could be one build error error: 'new_temp' may be used uninitialized for some build configurations. It's a false positive warning (or error at -Werror), but in order to make the build succeed, this patch is to initialize the reported variable 'new_temp' as NULL_TREE. PR tree-optimization/110652 gcc/ChangeLog: * tree-vect-stmts.cc (vectorizable_load): Initialize new_temp as NULL_TREE.
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Andrew Pinski changed: What|Removed |Added CC||danglin at gcc dot gnu.org --- Comment #7 from Andrew Pinski --- *** Bug 110672 has been marked as a duplicate of this bug. ***
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 --- Comment #6 from rguenther at suse dot de --- On Fri, 14 Jul 2023, linkw at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 > > Kewen Lin changed: > >What|Removed |Added > > CC||rguenth at gcc dot gnu.org > > --- Comment #5 from Kewen Lin --- > I can reproduce this on cfarm x86 machine, the complained line is exactly the > one in comment #c4, I believe it's a false positive. > > How do we work around this normally? Just initializing new_temp with > NULL_TREE > as below? Yes, possibly with a comment refering to this PR.
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Kewen Lin changed: What|Removed |Added CC||rguenth at gcc dot gnu.org --- Comment #5 from Kewen Lin --- I can reproduce this on cfarm x86 machine, the complained line is exactly the one in comment #c4, I believe it's a false positive. How do we work around this normally? Just initializing new_temp with NULL_TREE as below? diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index c08d0ef951f..124caab5c1f 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -9297,7 +9297,7 @@ vectorizable_load (vec_info *vinfo, class loop *containing_loop = gimple_bb (stmt_info->stmt)->loop_father; bool nested_in_vect_loop = false; tree elem_type; - tree new_temp; + tree new_temp = NULL_TREE; machine_mode mode; tree dummy; tree dataref_ptr = NULL_TREE;
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652
--- Comment #4 from Kewen Lin ---
I can't reproduce this on ppc64le with both the default bootstrapping checking
option --enable-checking=yes,extra and the reported --enable-checking=release.
I'm going to test it on cfarm x86 machine.
If the error message lineno is correct, it complains on line 10962:
/* Collect vector loads and later create their permutation in
vect_transform_grouped_load (). */
if (!costing_p && (grouped_load || slp_perm))
dr_chain.quick_push (new_temp); // line 10962
It's guarded with !costing_p and we have:
/* One common place to cost the above vect load for different
alignment support schemes. */
if (costing_p)
{
...
}
else
{
vec_dest = vect_create_destination_var (scalar_dest,
vectype);
...
new_temp = make_ssa_name (vec_dest, new_stmt); // line 10911
...
}
at line 10911, new_temp is always initialized for !costing_p. It looks like a
false positive.
Anyway, I'll reproduce it first on x86.
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Kewen Lin changed: What|Removed |Added Last reconfirmed||2023-07-14 Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #3 from Kewen Lin --- Thanks for reporting and I'll have a look.
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Sergei Trofimovich changed: What|Removed |Added CC||linkw at gcc dot gnu.org --- Comment #2 from Sergei Trofimovich --- If it helps bisect landed on r14-2493-g5f03844b32f452 commit 5f03844b32f45224c33dcea08a20b5a2089082f7 Author: Kewen Lin Date: Wed Jul 12 21:23:22 2023 -0500 vect: Adjust vectorizable_load costing on VMAT_CONTIGUOUS_REVERSE
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 --- Comment #1 from Andrew Pinski --- new_temp does look like it is initialized on the !costing_p path too ..
[Bug tree-optimization/110652] [14 Regression] bootstrap failure on tree-vect-stmts.cc with --enable-checking=release: error: 'new_temp' may be used uninitialized
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110652 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |14.0 Keywords||build, diagnostic
