[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-07-05 Thread rguenth at gcc dot gnu dot org


--- Comment #8 from rguenth at gcc dot gnu dot org  2007-07-05 17:51 ---
This is related to the gimplifier verifying call expression types to disable
inlining.  In this case the argument type list says we need struct _Bind, but
the actual argument is struct _Bind*.  Oh well.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-07-05 Thread pluto at agmk dot net


--- Comment #7 from pluto at agmk dot net  2007-07-05 17:35 ---
(In reply to comment #6)
 Fixed.

Richard, there's a recent regresion in 4.3/r126266:

_ZSt9transformIPlS0_NSt3tr15_BindIFSt4plusIlEllT0_T_S8_S7_T1_:
cmpq%rsi, %rdi
je  .L2
addq$8, %rdi
movq%rdx, %r9
movq%rdi, %r8
.p2align 4,,10
.p2align 3
.L3:
movq8(%rcx), %rax
addq16(%rcx), %rax
addq$8, %r8
movq%rax, (%r9)
leaq-8(%r8), %rax
addq$8, %r9
cmpq%rax, %rsi
jne .L3
subq%rdi, %rsi
shrq$3, %rsi
leaq8(%rdx,%rsi,8), %rdx
.L2:
movq%rdx, %rax
ret

_Z6assignRll:
subq$40, %rsp
movq%rdi, %rdx
movq%rsi, 8(%rsp)
leaq8(%rdi), %rsi
movq%rsp, %rcx
movq$0, 16(%rsp)
call   
_ZSt9transformIPlS0_NSt3tr15_BindIFSt4plusIlEllT0_T_S8_S7_T1_
addq$40, %rsp
ret

_Z6assignPll:
subq$40, %rsp
movq%rdi, %rdx
movq%rsi, 8(%rsp)
leaq8(%rdi), %rsi
movq%rsp, %rcx
movq$0, 16(%rsp)
call   
_ZSt9transformIPlS0_NSt3tr15_BindIFSt4plusIlEllT0_T_S8_S7_T1_
addq$40, %rsp
ret


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-07-05 Thread pluto at agmk dot net


--- Comment #9 from pluto at agmk dot net  2007-07-05 18:21 ---
(In reply to comment #8)
 This is related to the gimplifier verifying call expression types to disable
 inlining.  In this case the argument type list says we need struct _Bind, but
 the actual argument is struct _Bind*.  Oh well.

should i fill a separated PR for this issue?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-07-05 Thread rguenther at suse dot de


--- Comment #10 from rguenther at suse dot de  2007-07-05 18:29 ---
Subject: Re:  Fails to tree-combine conditions
 in COND_EXPRs

On Thu, 5 Jul 2007, pluto at agmk dot net wrote:

 
 
 --- Comment #9 from pluto at agmk dot net  2007-07-05 18:21 ---
 (In reply to comment #8)
  This is related to the gimplifier verifying call expression types to disable
  inlining.  In this case the argument type list says we need struct _Bind, 
  but
  the actual argument is struct _Bind*.  Oh well.
 
 should i fill a separated PR for this issue?

Yes, that would be nice.

richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-07-05 Thread rguenth at gcc dot gnu dot org


--- Comment #11 from rguenth at gcc dot gnu dot org  2007-07-05 20:25 
---
I have a fix.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-04-27 Thread rguenth at gcc dot gnu dot org


--- Comment #5 from rguenth at gcc dot gnu dot org  2007-04-27 14:44 ---
Subject: Bug 30965

Author: rguenth
Date: Fri Apr 27 14:43:42 2007
New Revision: 124217

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=124217
Log:
2007-04-27  Richard Guenther  [EMAIL PROTECTED]

PR tree-optimization/30965
PR tree-optimization/30978
* Makefile.in (tree-ssa-forwprop.o): Depend on $(FLAGS_H).
* tree-ssa-forwprop.c (forward_propagate_into_cond_1): Remove.
(find_equivalent_equality_comparison): Likewise.
(simplify_cond): Likewise.
(get_prop_source_stmt): New helper.
(get_prop_dest_stmt): Likewise.
(can_propagate_from): Likewise.
(remove_prop_source_from_use): Likewise.
(combine_cond_expr_cond): Likewise.
(forward_propagate_comparison): New function.
(forward_propagate_into_cond): Rewrite to use fold for
tree combining.
(tree_ssa_forward_propagate_single_use_vars): Call
forward_propagate_comparison to propagate comparisons.

* gcc.dg/tree-ssa/pr30978.c: New testcase.
* gcc.dg/tree-ssa/bool-3.c: Remove XFAIL, explain why.
* gcc.dg/tree-ssa/ssa-fre-4.c: Use char instead of bool
* gcc.dg/strict-overflow-5.c: Adjust tree dump scanning.

Added:
trunk/gcc/testsuite/gcc.dg/tree-ssa/pr30978.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/Makefile.in
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/strict-overflow-5.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/bool-3.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-4.c
trunk/gcc/tree-ssa-forwprop.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-04-27 Thread rguenth at gcc dot gnu dot org


--- Comment #6 from rguenth at gcc dot gnu dot org  2007-04-27 14:56 ---
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-04-27 Thread rguenth at gcc dot gnu dot org


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

   Target Milestone|--- |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-04-14 Thread jv244 at cam dot ac dot uk


--- Comment #3 from jv244 at cam dot ac dot uk  2007-04-14 11:00 ---

 http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00129.html

should this one be pinged ?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-04-14 Thread rguenth at gcc dot gnu dot org


--- Comment #4 from rguenth at gcc dot gnu dot org  2007-04-14 12:57 ---
I need to update it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-03-16 Thread jv244 at cam dot ac dot uk


--- Comment #2 from jv244 at cam dot ac dot uk  2007-03-16 19:38 ---
just to keep track, patch here:

http://gcc.gnu.org/ml/gcc-patches/2007-03/msg00129.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965



[Bug tree-optimization/30965] Fails to tree-combine conditions in COND_EXPRs

2007-03-02 Thread pinskia at gcc dot gnu dot org


--- Comment #1 from pinskia at gcc dot gnu dot org  2007-03-02 20:04 ---
*** Bug 31029 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30965