[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-12 Thread rguenth at gcc dot gnu dot org 


--- Comment #6 from rguenth at gcc dot gnu dot org  2007-05-12 18:22 ---
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-10 Thread patchapp at dberlin dot org 


--- Comment #5 from patchapp at dberlin dot org  2007-05-10 08:12 ---
Subject: Bug number PR31847

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00527.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-08 Thread simartin at gcc dot gnu dot org 


--- Comment #3 from simartin at gcc dot gnu dot org  2007-05-08 16:34 
---
Subject: Bug 31847

Author: simartin
Date: Tue May  8 15:33:56 2007
New Revision: 124551

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=124551
Log:
2007-05-08  Simon Martin  [EMAIL PROTECTED]

PR 31847
* tree-dump.c (dump_options): Don't use TDF_DIAGNOSTIC in *-all tree
dumps.

Added:
trunk/gcc/testsuite/gcc.dg/pr31847.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-dump.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-08 Thread simartin at gcc dot gnu dot org 


--- Comment #4 from simartin at gcc dot gnu dot org  2007-05-08 16:47 
---
This should be fixed (see
http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00527.html for an explanation of
the patch).


-- 

simartin at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |simartin at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2007-05-08 16:47:37
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-07 Thread simartin at gcc dot gnu dot org 


--- Comment #1 from simartin at gcc dot gnu dot org  2007-05-07 07:23 
---
Hello.

I've had a look at the code, and the PRE dump apparently directly calls
print_generic_expr (not via default_tree_printer) with TDF_DIAGNOSTIC in the
dump flags. I'm not sure how those flags are setup...

I think there is a problem in tree-dump.c (TDF_DIAGNOSTIC will be erroneously
passed in some dump flags), fixed by this patch:

Index: tree-dump.c
===
--- tree-dump.c (revision 124477)
+++ tree-dump.c (working copy)
@@ -803,7 +803,7 @@
   {stmtaddr, TDF_STMTADDR},
   {memsyms, TDF_MEMSYMS},
   {all, ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA 
-   | TDF_STMTADDR | TDF_GRAPH)},
+   | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC)},
   {NULL, 0}
 };


However, I'm not sure this will fix this issue, and I have not been able to
test it. Would you mind trying it? Thanks.

I'll look more closely on this issue this evening when I'm back from work.

Sorry for this breakage.
Simon


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-07 Thread dberlin at dberlin dot org 


--- Comment #2 from dberlin at gcc dot gnu dot org  2007-05-07 14:02 ---
Subject: Re:  [4.3 Regression] Printing to dump file broken

On 7 May 2007 06:23:40 -, simartin at gcc dot gnu dot org
[EMAIL PROTECTED] wrote:


 --- Comment #1 from simartin at gcc dot gnu dot org  2007-05-07 07:23 
 ---
 Hello.

 I've had a look at the code, and the PRE dump apparently directly calls
 print_generic_expr (not via default_tree_printer)

Every pass calls print_generic_expr to print expressions to dump files

 with TDF_DIAGNOSTIC in the
 dump flags. I'm not sure how those flags are setup...

PRE doesn't change the dump flags on its own, it just uses the global
dump_flags like everyone else :)



 I think there is a problem in tree-dump.c (TDF_DIAGNOSTIC will be erroneously
 passed in some dump flags), fixed by this patch:


 Index: tree-dump.c
 ===
 --- tree-dump.c (revision 124477)
 +++ tree-dump.c (working copy)
 @@ -803,7 +803,7 @@
{stmtaddr, TDF_STMTADDR},
{memsyms, TDF_MEMSYMS},
{all, ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA
 -   | TDF_STMTADDR | TDF_GRAPH)},
 +   | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC)},
{NULL, 0}
  };


 However, I'm not sure this will fix this issue, and I have not been able to
 test it. Would you mind trying it? Thanks.

This seems to work.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847

[Bug tree-optimization/31847] [4.3 Regression] Printing to dump file broken

2007-05-06 Thread pinskia at gcc dot gnu dot org 


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

Summary|Printing to dump file broken|[4.3 Regression] Printing to
   ||dump file broken
   Target Milestone|--- |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31847