[Bug tree-optimization/32949] suboptimal address generation for int indices on 64-bit targets

[pinskia at gcc dot gnu dot org]

--- Comment #5 from pinskia at gcc dot gnu dot org  2009-01-01 05:34 ---
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32949

[Bug tree-optimization/32949] suboptimal address generation for int indices on 64-bit targets

[rakdver at gcc dot gnu dot org]

--- Comment #4 from rakdver at gcc dot gnu dot org  2007-08-22 23:05 ---
Subject: Bug 32949

Author: rakdver
Date: Wed Aug 22 23:05:05 2007
New Revision: 127720

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=127720
Log:
2007-08-22  Zdenek Dvorak  <[EMAIL PROTECTED]>

PR tree-optimization/32949
* tree-ssa-loop-niter.c (scev_probably_wraps_p): Test nowrap_type_p
before failing for ivs with non-constant step.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-ssa-loop-niter.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32949

[Bug tree-optimization/32949] suboptimal address generation for int indices on 64-bit targets

[amonakov at gmail dot com]

--- Comment #3 from amonakov at gmail dot com  2007-08-22 21:29 ---
With first hunk modified not to delete 'return true', this patch passes
bootstrap with all default languages on ia64 and x86_64 with
--disable-multilib, and passes regtest with no new regressions (all said with
10-days-old trunk, revision 127475).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32949

[Bug tree-optimization/32949] suboptimal address generation for int indices on 64-bit targets

[amonakov at gmail dot com]

--- Comment #2 from amonakov at gmail dot com  2007-08-22 10:13 ---
> *** scev_probably_wraps_p (tree base, tree s
> *** 2969,2977 
>2032, 2040, 0, 8, ..., but the code is still legal.  */
> 
> if (chrec_contains_undetermined (base)
> !   || chrec_contains_undetermined (step)
> !   || TREE_CODE (step) != INTEGER_CST)
> ! return true;
> 
> if (integer_zerop (step))
>   return false;
> --- 2969,2975 
>2032, 2040, 0, 8, ..., but the code is still legal.  */
> 
> if (chrec_contains_undetermined (base)
> !   || chrec_contains_undetermined (step))
> 
> if (integer_zerop (step))
>   return false;

Zdenek, isn't 'return true' missing here?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32949

[Bug tree-optimization/32949] suboptimal address generation for int indices on 64-bit targets

[rakdver at gcc dot gnu dot org]

--- Comment #1 from rakdver at gcc dot gnu dot org  2007-08-21 21:29 ---
This patch fixes the problem:

Index: tree-ssa-loop-niter.c
===
*** tree-ssa-loop-niter.c   (revision 127674)
--- tree-ssa-loop-niter.c   (working copy)
*** scev_probably_wraps_p (tree base, tree s
*** 2969,2977 
   2032, 2040, 0, 8, ..., but the code is still legal.  */

if (chrec_contains_undetermined (base)
!   || chrec_contains_undetermined (step)
!   || TREE_CODE (step) != INTEGER_CST)
! return true;

if (integer_zerop (step))
  return false;
--- 2969,2975 
   2032, 2040, 0, 8, ..., but the code is still legal.  */

if (chrec_contains_undetermined (base)
!   || chrec_contains_undetermined (step))

if (integer_zerop (step))
  return false;
*** scev_probably_wraps_p (tree base, tree s
*** 2981,2986 
--- 2979,2989 
if (use_overflow_semantics && nowrap_type_p (type))
  return false;

+   /* To be able to use estimates on number of iterations of the loop,
+  we must have an upper bound on the absolute value of the step.  */
+   if (TREE_CODE (step) != INTEGER_CST)
+ return true;
+
/* Don't issue signed overflow warnings.  */
fold_defer_overflow_warnings ();


-- 

rakdver at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |rakdver at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2007-08-21 21:29:28
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32949