[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

--- Comment #5 from pinskia at gcc dot gnu dot org  2008-03-06 21:57 ---
Subject: Bug 35402

Author: pinskia
Date: Thu Mar  6 21:56:04 2008
New Revision: 132991

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=132991
Log:
2008-03-06  Andrew Pinski  [EMAIL PROTECTED]

PR tree-opt/35402
* tree-ssa-ccp.c (get_symbol_constant_value): Handle
integral and scalar float variables which have a
NULL DECL_INITIAL.

2008-03-06  Andrew Pinski  [EMAIL PROTECTED]

PR tree-opt/35402
* gcc.dg/tree-ssa/ssa-store-ccp-1.c: New test.


Added:
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-store-ccp-1.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-ssa-ccp.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

--- Comment #6 from pinskia at gcc dot gnu dot org  2008-03-06 21:59 ---
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

--- Comment #4 from pinskia at gcc dot gnu dot org  2008-03-05 23:40 ---
(In reply to comment #3)
 Please change tree-ssa-sccvn.c:try_to_simplify accordingly (eventually that
 should use a common helper function to extract a constant initializer for
 the tcc_reference case, too).  Thanks!

There is already a helper function in tree-ssa-ccp.c: get_symbol_constant_value
.
This is what I am changing if tree-ssa-sccvn.c:try_to_simplify wants to use it,
it should too.

I think there are too many duplicated functions all around really.  This is
just one example.

-- PInski


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[rguenth at gcc dot gnu dot org]

--- Comment #3 from rguenth at gcc dot gnu dot org  2008-02-29 12:43 ---
Please change tree-ssa-sccvn.c:try_to_simplify accordingly (eventually that
should use a common helper function to extract a constant initializer for
the tcc_reference case, too).  Thanks!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

--- Comment #1 from pinskia at gcc dot gnu dot org  2008-02-28 22:08 ---
Mine.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2008-02-28 22:08:57
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

--- Comment #2 from pinskia at gcc dot gnu dot org  2008-02-28 22:26 ---
/* { dg-final { scan-tree-dump-times conststaticvariable o optimized} } */

that should be:
/* { dg-final { scan-tree-dump-times conststaticvariable 0 optimized} } */

:)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402

[Bug tree-optimization/35402] Store CCP will not inline static const variable which is default initialized

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

   Severity|normal  |enhancement


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35402