[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[rguenth at gcc dot gnu dot org]

--- Comment #8 from rguenth at gcc dot gnu dot org  2010-08-26 14:21 ---
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[rguenth at gcc dot gnu dot org]

--- Comment #9 from rguenth at gcc dot gnu dot org  2010-08-26 14:21 ---
Subject: Bug 45255

Author: rguenth
Date: Thu Aug 26 14:20:45 2010
New Revision: 163565

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=163565
Log:
2010-08-26  Richard Guenther  rguent...@suse.de

PR tree-optimization/45255
* tree.c (decl_address_invariant_p): DECL_DLLIMPORT_P
statics and externals are also invariant.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[t66667 at gmail dot com]

--- Comment #5 from t7 at gmail dot com  2010-08-25 16:11 ---
Hi,
(In reply to comment #4)
 Well.  I do not have access to i686-pc-mingw32-gcc and this seems related to
 
 /* Return whether OP is a DECL whose address is function-invariant.  */
 
 bool
 decl_address_invariant_p (const_tree op)
 {
   /* The conditions below are slightly less strict than the one in
  staticp.  */
 ...
 case VAR_DECL:
   if (((TREE_STATIC (op) || DECL_EXTERNAL (op))
 !DECL_DLLIMPORT_P (op))
   || DECL_THREAD_LOCAL_P (op)
   || DECL_CONTEXT (op) == current_function_decl
   || decl_function_context (op) == current_function_decl)
 return true;
   break;
 
 WTF !DECL_DLLIMPORT_P (op)!?  (also noticed by rth recently)
 
 A fix is to remove that check here, but I can't test that.
 

Thanks. Indeed, removal of this check here fixed PR45405.
Tested on Windows 7 x64 multi-lib native GCC trunk.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[t66667 at gmail dot com]

--- Comment #6 from t7 at gmail dot com  2010-08-25 16:11 ---
*** Bug 45405 has been marked as a duplicate of this bug. ***


-- 

t7 at gmail dot com changed:

   What|Removed |Added

 CC||t7 at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[rguenth at gcc dot gnu dot org]

--- Comment #7 from rguenth at gcc dot gnu dot org  2010-08-25 17:19 ---
Mine then, thanks for testing the proposed fix.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
   |dot org |org
 Status|UNCONFIRMED |ASSIGNED
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2010-08-25 17:19:44
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[jojelino at gmail dot com]

--- Comment #1 from jojelino at gmail dot com  2010-08-11 09:57 ---
Created an attachment (id=21451)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21451action=view)
testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[jojelino at gmail dot com]

--- Comment #2 from jojelino at gmail dot com  2010-08-11 09:59 ---
(In reply to comment #1)
 Created an attachment (id=21451)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21451action=view) [edit]
 testcase
 

and it is resolved by changing __attribute__ ((dllimport)) to __attribute__
((visibility(default)))


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[steven at gcc dot gnu dot org]

--- Comment #3 from steven at gcc dot gnu dot org  2010-08-11 10:17 ---
WHOPR involved, MEM_REF involved... Richi?


-- 

steven at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||rguenth at gcc dot gnu dot
   ||org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255

[Bug tree-optimization/45255] [4.6 regression] internal compiler error: verify_stmts failed with -fwhopr

[rguenth at gcc dot gnu dot org]

--- Comment #4 from rguenth at gcc dot gnu dot org  2010-08-11 10:59 ---
Well.  I do not have access to i686-pc-mingw32-gcc and this seems related to

/* Return whether OP is a DECL whose address is function-invariant.  */

bool
decl_address_invariant_p (const_tree op)
{
  /* The conditions below are slightly less strict than the one in
 staticp.  */
...
case VAR_DECL:
  if (((TREE_STATIC (op) || DECL_EXTERNAL (op))
!DECL_DLLIMPORT_P (op))
  || DECL_THREAD_LOCAL_P (op)
  || DECL_CONTEXT (op) == current_function_decl
  || decl_function_context (op) == current_function_decl)
return true;
  break;

WTF !DECL_DLLIMPORT_P (op)!?  (also noticed by rth recently)

A fix is to remove that check here, but I can't test that.


-- 

rguenth at gcc dot gnu dot org changed:

   What|Removed |Added

   Target Milestone|--- |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45255