[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

Richard Guenther rguenth at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|unassigned at gcc dot   |rguenth at gcc dot gnu.org
   |gnu.org |

--- Comment #3 from Richard Guenther rguenth at gcc dot gnu.org 2010-11-04 
12:52:15 UTC ---
The gcc_unreachable is certainly gross, maybe it was ok for developing the
patch but as we can easily handle the situation we shouldn't explode in
the users face.

[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

--- Comment #4 from Richard Guenther rguenth at gcc dot gnu.org 2010-11-04 
15:17:29 UTC ---
Author: rguenth
Date: Thu Nov  4 15:17:24 2010
New Revision: 166315

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=166315
Log:
2010-11-04  Richard Guenther  rguent...@suse.de

PR tree-optimization/46068
* ipa-split.c (consider_split): Remove gcc_unreachable.

* gcc.dg/torture/pr46068.c: New testcase.

Added:
trunk/gcc/testsuite/gcc.dg/torture/pr46068.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ipa-split.c
trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

Richard Guenther rguenth at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #5 from Richard Guenther rguenth at gcc dot gnu.org 2010-11-04 
15:20:42 UTC ---
Fixed.

[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

Jakub Jelinek jakub at gcc dot gnu.org changed:

   What|Removed |Added

   Priority|P3  |P1

[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

Jakub Jelinek jakub at gcc dot gnu.org changed:

   What|Removed |Added

   Keywords|lto |
 Status|UNCONFIRMED |NEW
   Last reconfirmed||2010.10.18 18:34:22
 CC||jakub at gcc dot gnu.org
Summary|[4.6 Regression] ICE: in|[4.6 Regression] ICE: in
   |consider_split, at  |consider_split, at
   |ipa-split.c:313 with|ipa-split.c:313 with asm
   |-flto/-fwhopr and asm goto  |goto and
   ||__builtin_unreachable ()
 Ever Confirmed|0   |1

--- Comment #1 from Jakub Jelinek jakub at gcc dot gnu.org 2010-10-18 
18:34:22 UTC ---
void
foo ()
{
  asm goto (l1);
  __builtin_unreachable ();
  l1:;
}

void
bar ()
{
  foo ();
  foo ();
}

ICEs at -O2 even without -flto.

[Bug tree-optimization/46068] [4.6 Regression] ICE: in consider_split, at ipa-split.c:313 with asm goto and __builtin_unreachable ()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46068

Jakub Jelinek jakub at gcc dot gnu.org changed:

   What|Removed |Added

 CC||hubicka at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek jakub at gcc dot gnu.org 2010-10-18 
18:55:18 UTC ---
The testcase has 3 basic blocks, one contains the asm goto (for which
estimate_num_insns returns 0 because the string is empty), another one is
__builtin_unreachable () (obviously it doesn't require code) and the last one
is GIMPLE_RETURN (with no return value, again, no code).
So overall_size is 0.  I'd say either we should not call find_split_points at
all if overall_size is 0, or we should nuke that gcc_unreachable () on which it
ICEs in consider_split.