[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[irar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

--- Comment #5 from irar at gcc dot gnu.org 2011-09-04 09:22:42 UTC ---
Author: irar
Date: Sun Sep  4 09:22:38 2011
New Revision: 178508

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=178508
Log:

PR tree-optimization/50208
* tree-vect-patterns.c (vect_handle_widen_mult_by_const): Add an
argument.  Check that def_stmt is inside the loop.
(vect_recog_widen_mult_pattern): Update calls to
vect_handle_widen_mult_by_cons.
(vect_operation_fits_smaller_type): Check that def_stmt is
inside the loop.


Added:
trunk/gcc/testsuite/gcc.dg/vect/no-fre-pre-pr50208.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/vect/vect.exp
trunk/gcc/tree-vect-patterns.c

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

Ira Rosen irar at il dot ibm.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #6 from Ira Rosen irar at il dot ibm.com 2011-09-04 10:58:58 UTC 
---
Fixed.

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

--- Comment #3 from Ira Rosen irar at il dot ibm.com 2011-09-01 11:42:24 UTC 
---
Created attachment 25159
  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=25159
patch

Right. The attached patch does the suggested checks also in
vect_handle_widen_mult_by_const(). I'll test it on Sunday.

Thanks,
Ira

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[irar at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

Ira Rosen irar at il dot ibm.com changed:

   What|Removed |Added

 CC||irar at il dot ibm.com

--- Comment #4 from Ira Rosen irar at il dot ibm.com 2011-09-01 11:44:19 UTC 
---
(In reply to comment #2)
 I have no idea whether this can be invoked from slp vectorizer and what to
 do in that case.

Pattern detection is not called from SLP at the moment.

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

Jakub Jelinek jakub at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2011-08-29
 CC||jakub at gcc dot gnu.org
 Ever Confirmed|0   |1

--- Comment #1 from Jakub Jelinek jakub at gcc dot gnu.org 2011-08-29 
10:05:42 UTC ---
Caused by http://gcc.gnu.org/viewcvs?root=gccview=revrev=177647

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

--- Comment #2 from Jakub Jelinek jakub at gcc dot gnu.org 2011-08-29 
10:44:42 UTC ---
The problem is that def_stmt is a gimple stmt from before the loop and
new_loop_vec_info only initializes gimple_uid of stmts in the loop being
processed.
So perhaps before testing for vinfo_for_stmt it should
  || !gimple_bb (def_stmt)
  || !flow_bb_inside_loop_p (loop, gimple_bb (def_stmt))
and perhaps give up in those cases too?  Loop would need to be initialized,
perhaps similarly to vect_recog_dot_prod_pattern?
  loop_vec_info loop_info = STMT_VINFO_LOOP_VINFO (vinfo_for_stmt (stmt));
  struct loop *loop = LOOP_VINFO_LOOP (loop_info);
?  I have no idea whether this can be invoked from slp vectorizer and what to
do in that case.

[Bug tree-optimization/50208] [4.7 Regression] ICE: in vinfo_for_stmt at tree-vectorizer.h:598 with -ftree-vectorize -fno-tree-fre -fno-tree-pre

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50208

Richard Guenther rguenth at gcc dot gnu.org changed:

   What|Removed |Added

 CC||irar at gcc dot gnu.org,
   ||rguenth at gcc dot gnu.org
   Target Milestone|--- |4.7.0
Summary|ICE: in vinfo_for_stmt at   |[4.7 Regression] ICE: in
   |tree-vectorizer.h:598 with  |vinfo_for_stmt at
   |-ftree-vectorize|tree-vectorizer.h:598 with
   |-fno-tree-fre -fno-tree-pre |-ftree-vectorize
   ||-fno-tree-fre -fno-tree-pre