[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #23 from vries at gcc dot gnu.org ---
*** Bug 69822 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vogt at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #22 from Dominik Vogt  ---
Successfully bootstrapped and regression tested on s390x biarch.
Thanks.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

vries at gcc dot gnu.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
   Assignee|unassigned at gcc dot gnu.org  |vries at gcc dot gnu.org

--- Comment #21 from vries at gcc dot gnu.org ---
patch with test-case committed, marking resolved-fixed.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #20 from vries at gcc dot gnu.org ---
Author: vries
Date: Wed Mar  2 15:10:34 2016
New Revision: 233909

URL: https://gcc.gnu.org/viewcvs?rev=233909=gcc=rev
Log:
Handle addr_expr and component_ref in graphite-ast-to-ast

2016-03-02  Tom de Vries  

PR tree-optimization/68659
* graphite-isl-ast-to-gimple.c (collect_all_ssa_names): Handle
new_expr == NULL_TREE.
(get_new_name): Handle ADDR_EXPR.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/graphite-isl-ast-to-gimple.c

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

vries at gcc dot gnu.org changed:

   What|Removed |Added

   Keywords||ice-on-valid-code, patch

--- Comment #19 from vries at gcc dot gnu.org ---
https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00016.html

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vogt at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Dominik Vogt  changed:

   What|Removed |Added

 CC||vogt at linux dot vnet.ibm.com

--- Comment #18 from Dominik Vogt  ---
I've no opinion on wether the patch is good or not, but it does make the test
failure go away on s390x.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

vries at gcc dot gnu.org changed:

   What|Removed |Added

 CC||vries at gcc dot gnu.org

--- Comment #17 from vries at gcc dot gnu.org ---
(In reply to John David Anglin from comment #11)
> Seeing this on hppa with -mschedule=7100LC.  This is with r231795.
> 
> There is null pointer exception here:
> 
> Program received signal SIGSEGV, Segmentation fault.
> translate_isl_ast_to_gimple::collect_all_ssa_names (
> this=this@entry=0xfd703908, new_expr=0x0,
> vec_ssa=vec_ssa@entry=0xfd7044c8)
> at ../../gcc/gcc/graphite-isl-ast-to-gimple.c:1603
> 1603if (TREE_CODE (new_expr) == SSA_NAME)
> (gdb) p new_expr
> $1 = (tree) 0x0

I wonder if this patch is correct (at least fixes the ICE with x86_64 -m32):
...
index d3614e4..e5b03ee 100644
--- a/gcc/graphite-isl-ast-to-gimple.c
+++ b/gcc/graphite-isl-ast-to-gimple.c
@@ -1404,6 +1404,9 @@ void translate_isl_ast_to_gimple::
 collect_all_ssa_names (tree new_expr, vec *vec_ssa)
 {

+  if (new_expr == NULL_TREE)
+return;
+
   /* Rename all uses in new_expr.  */
   if (TREE_CODE (new_expr) == SSA_NAME)
 {
@@ -1804,6 +1807,9 @@ get_new_name (basic_block new_bb, tree op,
   if (is_constant (op))
 return op;

+  if (TREE_CODE (op) == ADDR_EXPR)
+return op;
+
   return get_rename (new_bb, op, old_bb, phi_kind);
 }

...

We're doing collect_all_ssa_names for component_ref u2.buf. Operand 2 is
NULL_TREE, which AFAIU according to the definition of component_ref is allowed
(tree.def: Operand 2, if present, ...). This code in collect_all_ssa_names just
looks at TREE_CODE_LENGTH, which is 3 for component_ref, and for i == 2, op ==
NULL_TREE:
...
  /* Iterate over SSA_NAMES in NEW_EXPR.  */
  for (int i = 0; i < (TREE_CODE_LENGTH (TREE_CODE (new_expr))); i++)
{
  tree op = TREE_OPERAND (new_expr, i);
  collect_all_ssa_names (op, vec_ssa);
}
...

The first bit of the patch allows the NULL_TREE operand in
collect_all_ssa_names. But subsequently, we run into handling op ==  in
get_new_name, which results in an assert that op is not an ssa-name in
get_rename. The last bit of the patch handles that.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Rainer Orth  changed:

   What|Removed |Added

 Target|powerpc-*-*, arm*-*-*,  |powerpc-*-*, arm*-*-*,
   |i?86-*-*|i?86-*-*, sparc*-*-*
 CC||ro at gcc dot gnu.org

--- Comment #16 from Rainer Orth  ---
Also on Solaris/SPARC with ISL 0.15.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Jack Howarth  changed:

   What|Removed |Added

 CC||howarth.at.gcc at gmail dot com

--- Comment #14 from Jack Howarth  ---
Since this bug impacts platforms that are primary targets, shouldn't it really
be recategorized as a P2 (or least a P3)?

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #15 from Jeffrey A. Law  ---
It's P4 because it's a graphite issue.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #13 from Uroš Bizjak  ---
(In reply to Uroš Bizjak from comment #12)
> At revision 232901, this testcase still ICEs on i686 (or x86_64 with -m32)
> on Fedora 23:
> 
> Running target unix/-m32
> FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)
> FAIL: gcc.dg/graphite/id-pr45230-1.c (test for excess errors)

Also seen in [1].

[1] https://gcc.gnu.org/ml/gcc-testresults/2016-01/msg02668.html

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Uroš Bizjak  changed:

   What|Removed |Added

 Target|powerpc-*-*, arm*-*-*   |powerpc-*-*, arm*-*-*,
   ||i?86-*-*
 CC||ubizjak at gmail dot com

--- Comment #12 from Uroš Bizjak  ---
At revision 232901, this testcase still ICEs on i686 (or x86_64 with -m32) on
Fedora 23:

Running target unix/-m32
FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)
FAIL: gcc.dg/graphite/id-pr45230-1.c (test for excess errors)

Executing on host: /ssd/uros/gcc-build/gcc/xgcc -B/ssd/uros/gcc-build/gcc/
/home/uros/gcc-svn/trunk/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c  -m32   
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/ 
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxrt 
-L/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxrt/.libs 
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/ 
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxwrap 
-L/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxwrap/.libs 
-fno-diagnostics-show-caret -fdiagnostics-color=never   -O2 -fgraphite-identity
-ffast-math -S -o id-pr45230-1.s(timeout = 300)
spawn -ignore SIGHUP /ssd/uros/gcc-build/gcc/xgcc -B/ssd/uros/gcc-build/gcc/
/home/uros/gcc-svn/trunk/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c -m32
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxrt
-L/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxrt/.libs
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/
-B/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxwrap
-L/ssd/uros/gcc-build/x86_64-pc-linux-gnu/./libmpx/mpxwrap/.libs
-fno-diagnostics-show-caret -fdiagnostics-color=never -O2 -fgraphite-identity
-ffast-math -S -o id-pr45230-1.s
/home/uros/gcc-svn/trunk/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c: In
function 'main':
/home/uros/gcc-svn/trunk/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1:
internal compiler error: Segmentation fault
0xb2a58f crash_signal
/home/uros/gcc-svn/trunk/gcc/toplev.c:335
0x11cd064 translate_isl_ast_to_gimple::collect_all_ssa_names(tree_node*,
vec*)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1652
0x11cd0cf translate_isl_ast_to_gimple::collect_all_ssa_names(tree_node*,
vec*)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1662
0x11cd0cf translate_isl_ast_to_gimple::collect_all_ssa_names(tree_node*,
vec*)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1662
0x11cd0cf translate_isl_ast_to_gimple::collect_all_ssa_names(tree_node*,
vec*)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1662
0x11ce727 translate_isl_ast_to_gimple::rename_all_uses(tree_node*,
basic_block_def*, basic_block_def*)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1814
0x11ce900 translate_isl_ast_to_gimple::get_rename_from_scev(tree_node*,
gimple**, loop*, basic_block_def*, basic_block_def*, vec)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1871
0x11d0f5f translate_isl_ast_to_gimple::rename_uses(gimple*,
gimple_stmt_iterator*, basic_block_def*, loop*, vec)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1981
0x11d27f7
translate_isl_ast_to_gimple::graphite_copy_stmts_from_block(basic_block_def*,
basic_block_def*, vec)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:2861
0x11d2c66
translate_isl_ast_to_gimple::copy_bb_and_scalar_dependences(basic_block_def*,
edge_def*, vec)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:3077
0x11d3367
translate_isl_ast_to_gimple::translate_isl_ast_node_user(isl_ast_node*,
edge_def*, std::map,
std::allocator > >&)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1172
0x11d36d9 translate_isl_ast_to_gimple::translate_isl_ast_for_loop(loop*,
isl_ast_node*, edge_def*, tree_node*, tree_node*, tree_node*, std::map, std::allocator > >&)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:922
0x11d391c translate_isl_ast_to_gimple::translate_isl_ast_node_for(loop*,
isl_ast_node*, edge_def*, std::map,
std::allocator > >&)
/home/uros/gcc-svn/trunk/gcc/graphite-isl-ast-to-gimple.c:1090
0x11d3ae5 translate_isl_ast_to_gimple::translate_isl_ast_node_block(loop*,
isl_ast_node*, edge_def*, std::map,

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Jeffrey A. Law  changed:

   What|Removed |Added

   Priority|P3  |P4
 CC||law at redhat dot com

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

John David Anglin  changed:

   What|Removed |Added

 CC||danglin at gcc dot gnu.org

--- Comment #11 from John David Anglin  ---
Seeing this on hppa with -mschedule=7100LC.  This is with r231795.

There is null pointer exception here:

Program received signal SIGSEGV, Segmentation fault.
translate_isl_ast_to_gimple::collect_all_ssa_names (
this=this@entry=0xfd703908, new_expr=0x0, vec_ssa=vec_ssa@entry=0xfd7044c8)
at ../../gcc/gcc/graphite-isl-ast-to-gimple.c:1603
1603  if (TREE_CODE (new_expr) == SSA_NAME)
(gdb) p new_expr
$1 = (tree) 0x0

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[mwahab at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

mwahab at gcc dot gnu.org changed:

   What|Removed |Added

 CC||mwahab at gcc dot gnu.org

--- Comment #9 from mwahab at gcc dot gnu.org ---
I still see this on arm-none-eabi.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Sebastian Pop  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #10 from Sebastian Pop  ---
Thanks for reporting.
I will have a look at what happens on arm.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Sebastian Pop  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Sebastian Pop  ---
Most likely fixed in r231206.

*** This bug has been marked as a duplicate of bug 68550 ***

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|--- |6.0

--- Comment #3 from Richard Biener  ---
Sounds similar to the fixed PR68550.  But confirmed, I also saw the ICE (with
ISL 0.12 and 0.14).

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

ktkachov at gcc dot gnu.org changed:

   What|Removed |Added

 Target|powerpc-*-* |powerpc-*-*, arm*-*-*
   Last reconfirmed|2015-12-02 00:00:00 |2015-12-3
 CC||ktkachov at gcc dot gnu.org

--- Comment #4 from ktkachov at gcc dot gnu.org ---
Seeing this on arm-none-eabi too.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[amker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

amker at gcc dot gnu.org changed:

   What|Removed |Added

   Last reconfirmed|2015-12-03 00:00:00 |2015-12-02 0:00

--- Comment #5 from amker at gcc dot gnu.org ---
(In reply to Richard Biener from comment #3)
> Sounds similar to the fixed PR68550.  But confirmed, I also saw the ICE
> (with ISL 0.12 and 0.14).

Yes, seems with the change, more scop is recognized and then the error happens.
 I will double check that the loop niter analysis is correct.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #6 from Sebastian Pop  ---
I do not see the error on today's trunk at r231233.  Could you please verify
that this has been fixed by our changes from yesterday?

Thanks!

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[amker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #7 from amker at gcc dot gnu.org ---
(In reply to Sebastian Pop from comment #6)
> I do not see the error on today's trunk at r231233.  Could you please verify
> that this has been fixed by our changes from yesterday?

I can confirm it's gone at revision 231243 on powerpc-elf.

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-12-02
 CC||spop at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Dominique d'Humieres  ---
Confirmed on x86_64-apple-darwin14 with -m32, but not with -m64. No ICE with
r231086, r231131 gives

/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c: In function
'main':
/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: error:
missing PHI def
 main ()
 ^~~~

/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: error:
missing PHI def
p1_14 = PHI <(28), (33)>
/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: internal
compiler error: verify_gimple failed

/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: internal
compiler error: Abort trap: 6

and r231168 (configured with --enable-checking=release)

/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c: In function
'main':
/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: internal
compiler error: Segmentation fault: 11
 main ()
 ^~~~


/opt/gcc/_clean/gcc/testsuite/gcc.dg/graphite/id-pr45230-1.c:45:1: internal
compiler error: Abort trap: 6

[Bug tree-optimization/68659] [6 regression] FAIL: gcc.dg/graphite/id-pr45230-1.c (internal compiler error)

[amker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68659

--- Comment #2 from amker at gcc dot gnu.org ---
I will have a look.