[Bug tree-optimization/89268] [9 Regression] r268689 caused FAIL: gcc.dg/vect/pr79887.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89268

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek  ---
Fixed.

[Bug tree-optimization/89268] [9 Regression] r268689 caused FAIL: gcc.dg/vect/pr79887.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89268

--- Comment #3 from Jakub Jelinek  ---
Author: jakub
Date: Sun Feb 10 11:06:58 2019
New Revision: 268743

URL: https://gcc.gnu.org/viewcvs?rev=268743&root=gcc&view=rev
Log:
PR tree-optimization/89268
* tree-if-conv.c (version_loop_for_if_conversion): Push to preds only
if preds is non-NULL.

* gcc.dg/vect/pr89268.c: New test.

Added:
trunk/gcc/testsuite/gcc.dg/vect/pr89268.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-if-conv.c

[Bug tree-optimization/89268] [9 Regression] r268689 caused FAIL: gcc.dg/vect/pr79887.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89268

Jakub Jelinek  changed:

   What|Removed |Added

   Target Milestone|--- |9.0

[Bug tree-optimization/89268] [9 Regression] r268689 caused FAIL: gcc.dg/vect/pr79887.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89268

--- Comment #2 from Jakub Jelinek  ---
Created attachment 45650
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45650&action=edit
gcc9-pr89268.patch

Full untested patch.

[Bug tree-optimization/89268] [9 Regression] r268689 caused FAIL: gcc.dg/vect/pr79887.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89268

Jakub Jelinek  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-02-09
 CC||jakub at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Jakub Jelinek  ---
I think we want:
--- gcc/tree-if-conv.c.jj   2019-02-08 20:00:40.774827920 +0100
+++ gcc/tree-if-conv.c  2019-02-09 17:35:36.995782510 +0100
@@ -2760,7 +2760,8 @@ version_loop_for_if_conversion (struct l
   new_loop->force_vectorize = false;
   gsi = gsi_last_bb (cond_bb);
   gimple_call_set_arg (g, 1, build_int_cst (integer_type_node,
new_loop->num));
-  preds->safe_push (g);
+  if (preds)
+preds->safe_push (g);
   gsi_insert_before (&gsi, g, GSI_SAME_STMT);
   update_ssa (TODO_update_ssa);
   return new_loop;
so that it behaves as before when called from tree-vect-loop.c (preds is NULL).