[Bug tree-optimization/93397] [10 Regression] ICE in vect_create_epilog_for_reduction

2020-01-27 Thread cvs-commit at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93397

--- Comment #5 from CVS Commits  ---
The master branch has been updated by Richard Guenther :

https://gcc.gnu.org/g:1442bc31da61a7f6c7d7c526e0449cfd9a917cd5

commit r10-6241-g1442bc31da61a7f6c7d7c526e0449cfd9a917cd5
Author: Richard Biener 
Date:   Mon Jan 27 10:30:29 2020 +0100

tree-optimization/93397 delay converted reduction chain adjustment

The following delays adjusting the SLP graph for converted reduction
chains to a point where the SLP build no longer can fail since we
otherwise fail to undo marking the conversion as a group.

2020-01-27  Richard Biener  

PR tree-optimization/93397
* tree-vect-slp.c (vect_analyze_slp_instance): Delay
converted reduction chain SLP graph adjustment.

* gcc.dg/torture/pr93397.c: New testcase.

[Bug tree-optimization/93397] [10 Regression] ICE in vect_create_epilog_for_reduction

2020-01-27 Thread rguenth at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93397

Richard Biener  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Richard Biener  ---
Fixed.

[Bug tree-optimization/93397] [10 Regression] ICE in vect_create_epilog_for_reduction

2020-01-23 Thread rguenth at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93397

Richard Biener  changed:

   What|Removed |Added

   Priority|P3  |P1
 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |rguenth at gcc dot 
gnu.org

--- Comment #3 from Richard Biener  ---
Mine.

[Bug tree-optimization/93397] [10 Regression] ICE in vect_create_epilog_for_reduction

2020-01-22 Thread marxin at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93397

Martin Liška  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2020-01-23
 CC||marxin at gcc dot gnu.org,
   ||rguenth at gcc dot gnu.org
  Known to work||9.2.0
   Target Milestone|--- |10.0
 Ever confirmed|0   |1
  Known to fail||10.0

--- Comment #2 from Martin Liška  ---
Confirmed, started with r10-4222-gb4673569c2a8b974e3f84ffaa547941c5d40cfe5.

[Bug tree-optimization/93397] [10 Regression] ICE in vect_create_epilog_for_reduction

2020-01-22 Thread prathamesh3492 at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93397

prathamesh3492 at gcc dot gnu.org changed:

   What|Removed |Added

 CC||prathamesh3492 at gcc dot 
gnu.org

--- Comment #1 from prathamesh3492 at gcc dot gnu.org ---
Seems to ICE at all optimization levels. Because slp_node is NULL in following
hunk in vect_create_epilog_for_reduction since we're calling it from loop
vectorizer:

  /* In SLP reduction chain we reduce vector results into one vector if
 necessary, hence we set here REDUC_GROUP_SIZE to 1.  SCALAR_DEST is the
 LHS of the last stmt in the reduction chain, since we are looking for
 the loop exit phi node.  */
  if (REDUC_GROUP_FIRST_ELEMENT (stmt_info))
{
  stmt_vec_info t = SLP_TREE_SCALAR_STMTS (slp_node)[group_size - 1];

Gating the condition on slp_node seems to work, but not sure if that's the
right fix ?

Thanks,
Prathamesh