Re: Small error in manual

2009-03-24 Thread Ralf Wildenhues
* Ian Lance Taylor wrote on Wed, Mar 25, 2009 at 01:51:01AM CET:
> 
> Really the original text is slightly wrong.
[...]
> This option only applies to strings in debugging information.  It should
> say something like "Direct the linker to not merge together strings in
> the debugging information which are identical in different object
> files."  Also I think s/It decreases/Merging decreases/.
> 
> OK with those changes.

Thanks, this is how I applied it (also s/assemblers or linker/&s/)
after retesting.

Cheers,
Ralf

2009-03-25  Ralf Wildenhues  

* doc/invoke.texi (Debugging Options): Fix description of
-fno-merge-debug-strings.

Index: gcc/doc/invoke.texi
===
--- gcc/doc/invoke.texi (revision 145050)
+++ gcc/doc/invoke.texi (working copy)
@@ -4408,11 +4408,11 @@
 @item -fno-merge-debug-strings
 @opindex fmerge-debug-strings
 @opindex fno-merge-debug-strings
-Direct the linker to merge together strings which are identical in
-different object files.  This is not supported by all assemblers or
-linker.  This decreases the size of the debug information in the
-output file at the cost of increasing link processing time.  This is
-on by default.
+Direct the linker to not merge together strings in the debugging
+information which are identical in different object files.  Merging is
+not supported by all assemblers or linkers.  Merging decreases the size
+of the debug information in the output file at the cost of increasing
+link processing time.  Merging is enabled by default.
 
 @item -fdebug-prefix-m...@var{old}=@var{new}
 @opindex fdebug-prefix-map


Re: Small error in manual

2009-03-24 Thread Ian Lance Taylor
Ralf Wildenhues  writes:

> 2009-03-24  Ralf Wildenhues  
>
> * doc/invoke.texi (Debugging Options): Fix description of
> -fno-merge-debug-strings.

Really the original text is slightly wrong.

> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index d1c86dc..8b97fa0 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -4408,11 +4408,11 @@ This option works only with DWARF 2.
>  @item -fno-merge-debug-strings
>  @opindex fmerge-debug-strings
>  @opindex fno-merge-debug-strings
> -Direct the linker to merge together strings which are identical in
> -different object files.  This is not supported by all assemblers or
> -linker.  This decreases the size of the debug information in the
> -output file at the cost of increasing link processing time.  This is
> -on by default.
> +Direct the linker to not merge together strings which are identical in
> +different object files.  Merging is not supported by all assemblers or
> +linker.  It decreases the size of the debug information in the output
> +file at the cost of increasing link processing time.  Merging is enabled
> +by default.

This option only applies to strings in debugging information.  It should
say something like "Direct the linker to not merge together strings in
the debugging information which are identical in different object
files."  Also I think s/It decreases/Merging decreases/.

OK with those changes.

Thanks.

Ian


Re: Small error in manual

2009-03-24 Thread Dave Korn
Ralf Wildenhues wrote:
> * Dave Korn wrote on Tue, Mar 24, 2009 at 08:40:08PM CET:
>> Ralf Wildenhues wrote:
>>
>>> Thanks for the report.  OK to push this patch, tested 'make info pdf
>>> html'?
>>   You forgot "dvi".
> 
> I forgot to mention it, but I did test it.  OK?

  Well, it aint my say-so, but it ought to be!

cheers,
  DaveK



Re: Small error in manual

2009-03-24 Thread Ralf Wildenhues
* Dave Korn wrote on Tue, Mar 24, 2009 at 08:40:08PM CET:
> Ralf Wildenhues wrote:
> 
> > Thanks for the report.  OK to push this patch, tested 'make info pdf
> > html'?
> 
>   You forgot "dvi".

I forgot to mention it, but I did test it.  OK?


Re: Small error in manual

2009-03-24 Thread Dave Korn
Ralf Wildenhues wrote:

> Thanks for the report.  OK to push this patch, tested 'make info pdf
> html'?

  You forgot "dvi".

cheers,
  DaveK


Re: Small error in manual

2009-03-24 Thread Ralf Wildenhues
Hello Reuben,

I think nowadays the gcc-bugs list is meant only as gateway for bugzilla
messages, so you might want to open a bugzilla for future reports.
Thanks.

* Reuben Thomas wrote on Mon, Mar 23, 2009 at 02:58:20AM CET:
> (Found in 4.3; I was unable to discover without checking out the sources  
> whether the error is still present in head, as I couldn't work out which  
> file to look in using ViewVC; sorry.)
>
> -fno-merge-debug-strings is documented as if it were 
> -fmerge-debug-strings; the description needs to be negated.

Thanks for the report.  OK to push this patch, tested 'make info pdf
html'?

Thanks,
Ralf

gcc/ChangeLog:
2009-03-24  Ralf Wildenhues  

* doc/invoke.texi (Debugging Options): Fix description of
-fno-merge-debug-strings.

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index d1c86dc..8b97fa0 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -4408,11 +4408,11 @@ This option works only with DWARF 2.
 @item -fno-merge-debug-strings
 @opindex fmerge-debug-strings
 @opindex fno-merge-debug-strings
-Direct the linker to merge together strings which are identical in
-different object files.  This is not supported by all assemblers or
-linker.  This decreases the size of the debug information in the
-output file at the cost of increasing link processing time.  This is
-on by default.
+Direct the linker to not merge together strings which are identical in
+different object files.  Merging is not supported by all assemblers or
+linker.  It decreases the size of the debug information in the output
+file at the cost of increasing link processing time.  Merging is enabled
+by default.
 
 @item -fdebug-prefix-m...@var{old}=@var{new}
 @opindex fdebug-prefix-map


Small error in manual

2009-03-22 Thread Reuben Thomas
(Found in 4.3; I was unable to discover without checking out the sources 
whether the error is still present in head, as I couldn't work out which 
file to look in using ViewVC; sorry.)


-fno-merge-debug-strings is documented as if it were -fmerge-debug-strings; 
the description needs to be negated.


--
http://rrt.sc3d.org/ | Floc: an egregiously good aperitif