RE: [H8300] Use braced strings in MD
Hi, >> Great. I approved it this morning and it looks like your account was >> created soon thereafter. Thanks for the approval. My account has been created. >> add yourself to the MAINTAINTERS file with write-after-approval >> privileges. Done. http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00705.html >> Looks good. Please install. Similarly for the v850 changes. The h8300.md and v850.md are committed at the following links respectively on trunk:- http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00696.html http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00699.html Thanks for your help. Regards, Naveen
[PATCH] SH2A: Don't push/pop registers for functions with resbank attribute
Hi, Please find attached the patch "resbank.patch" which fixes the issue with "resbank" attribute. Currently, registers used in the routine are also saved on using resbank attribute. These registers are saved with resbank instruction and need not be saved separately. The patch fixes the issue. Tested with sh2a-elf. Regression results are good. ChangeLog 2012-03-29 Naveen H.S * config/sh/sh.c (push_regs): Condition added for resbank attribute. (sh_expand_epilogue): Condition added for resbank attribute. Thanks & Regards, Naveen resbank.patch Description: resbank.patch
[PATCH] SH: Fix m2a-single-only compilation error
Hi, Please find attached the patch "crt1.patch" which fixes compilation issue with sh2a-single-only target. Currently, compilation generates the following error:- "merge of architecture 'sh3e' with architecture 'sh2a' produced unknown architecture" The patch fixes the issue. Tested with sh2a-elf. No new regressions. ChangeLog 2012-03-30 Naveen H.S * libgcc/config/sh/crt1.S (VBR_SETUP): Don't define for SH2E targets Thanks & Regards, Naveen crt1.patch Description: crt1.patch
RE: [PATCH] SH2A: Don't push/pop registers for functions with resbank attribute
Hi, >> Looks that the patch ignores the case using movml. >> It could be something like the attached patch Sorry for ignoring the case using movml. Thanks for the patch which takes care of movml case. >> though I don't do any tests. The patch was tested with movml testcase and works as expected. Tested with sh2a-elf. No new regressions. Thanks & Regards, Naveen
[PATCH] RX: Fix min instruction for unsigned variables
Hi, Please find attached the patch "smin.patch" which fixes the issue for unsigned values with "min" instruction. Currently, unsigned values greater than QI mode are converted into signed values and hence generates wrong value. The patch fixes the issue. Tested with rx-elf. No new regressions. ChangeLog 2012-04-05 Naveen H.S * config/rx/rx.md (umin3): Allow const int values in HImode. Thanks & Regards, Naveen smin.patch Description: smin.patch
PING [PATCH] RX: Fix min instruction for unsigned variables
Hi, Please consider this mail as a reminder to review the patch posted at the following link:- http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00255.html Please review the patch and let us know if there should be any modifications in it. Thanks & Regards, Naveen
[V850] Use braced strings in MD
Hi, Please find attached the patch "v850_indent.patch" that adapts V850 machine descriptions to the braced string notation. The changes makes the "Machine Descriptor" file more easier to read. It is similar to the following changes in SH target. http://gcc.gnu.org/ml/gcc-patches/2012-03/msg01315.html ChangeLog * config/v850/v850.md: Use braced string notation where applicable. Thanks & Regards, Naveen v850_indent.patch Description: v850_indent.patch
[PATCH,RX] Support Bit Manipulation on Memory Operands
Hi, Please find attached the patch "rx_bit_insn.patch" which supports bit operations on memory operand. Please review the same and let me know if there should be any modifications in it. Tested with rx-elf. No new Regressions. ChangeLog 2012-11-06 Naveen H.S * config/rx/constraints.md (Uint03, Intu1, Intu0, Intsz, Intso): New Constraints. * config/rx/predicates.md (rx_constbit_operand): New Predicates that allows value from 0 to 7. * gcc/config/rx/rx.c (print_operand): Add %D and %E operand codes for bit manipulations. * gcc/config/rx/rx.md (iorbset_mem, iorbset_reg, bset): New instructions for setting a memory bit. (xorbnot_mem, xorbnot_reg): New instructions for inverting a memory bit. (andbclr_mem, andbclr_reg, bclr, insv_mem_imm): New instructions for clearing a memory bit. (insv): Modify to support bit manipulation operations on memory directly. Thanks & Regards, Naveen rx_bit_insn.patch Description: rx_bit_insn.patch
RE: [PATCH,RX] Support Bit Manipulation on Memory Operands
Hi, Thank you for reviewing the patch and valuable comments. >> You need to use match_dup instead of a matching constraint. Done. >> Every one that isn't explicitly invoked should have a leading "*" >> in the name. Done. Please find attached the modified patch and let me know if it's okay? Thanks & Regards, Naveen rx_bit_insn.patch Description: rx_bit_insn.patch
RE: [PATCH,RX] Support Bit Manipulation on Memory Operands
Hi, Thank you for reviewing the patch and valuable comments. >> The output constraint is now an in-out: s/=Q/+Q/. Done. Please find attached the modified patch and let me know if it's okay? Thanks & Regards, Naveen rx_bit_insn.patch Description: rx_bit_insn.patch
