RE: [PATCH][RX] Patch to correct the functionality of compiler option -falign-labels=n

[Sandeep Kumar Singh]

Hi DJ,

> Have you checked the other alignment macros to see if they need to be
> fixed too?
Thank you for review this patch.
Yes, I have checked other alignment macros and it seems fine. 

> This should be :
I have corrected this review comment.

Is this patch now ok to commit?

Best Regards,
Sandeep Kumar Singh


2014-06-12  Sandeep Kumar Singh  
* config/rx/rx.h (LABEL_ALIGN): Corrected macro LABEL_ALIGN



rx_align_labels.patch
Description: rx_align_labels.patch

[PATCH][RX] Patch to correct the functionality of compiler option -falign-labels=n

[Sandeep Kumar Singh]

Hi,

The RX compiler align wrong labels with option falign-labels=n, where n is 
number 
of bytes. The relationship between -falign-labels and expected .balign output 
supposed to be:
-falign-labels=4 --> .balign 4
-falign-labels=8 --> .balign 8
-falign-labels=16 --> .balign 16

However, listed pseudo code was the like (without any optimization):
-falign-labels=1 --> .balign 2
-falign-labels=4 --> .balign 16
-falign-labels=8 --> .balign 256
-falign-labels=16 --> .balign 65536

No regression found with this patch.

Please review the patch and let me know if there should be any modifications
in it?

Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gcc/ChangeLog
2014-06-11  Sandeep Kumar Singh  

* config/rx/rx.h (Corrected macro LABEL_ALIGN).




rx_align_labels.patch
Description: rx_align_labels.patch

[PING 3] [Patch RX] Add assembler option "-mcu" for generating assembler

[Sandeep Kumar Singh]

Hi,

Please find the patch to add assembler option "-mcu" for generating assembler
error messages when target not supporting hardware FPU were seeing FPU code,
namely RX100 and RX200.

KPIT has recently submitted a patch to add warnings of RX variants that do not
have hardware FPU support,
http://www.sourceware.org/ml/binutils/2013-07/msg00085.html

Index: gcc/config/rx/rx.h
===
--- gcc/config/rx/rx.h.orig 2013-07-18 18:03:11.0 +0530
+++ gcc/config/rx/rx.h  2013-07-11 14:57:17.0 +0530
@@ -101,6 +101,7 @@
 %{mpid} \
 %{mint-register=*} \
 %{mgcc-abi:-mgcc-abi} %{!mgcc-abi:-mrx-abi} \
+%{mcpu=*} \
 "
 
No regression found with this patch.

Please let me know if this is OK?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gas/config:
2013-07-18  Sandeep Kumar Singh  

* rx.h: Add option -mcpu for target variants RX100 and RX200.

[PING 2] [Patch RX] Add assembler option "-mcu" for generating assembler

[Sandeep Kumar Singh]

Hi,

Please find the patch to add assembler option "-mcu" for generating assembler
error messages when target not supporting hardware FPU were seeing FPU code,
namely RX100 and RX200.

KPIT has recently submitted a patch to add warnings of RX variants that do not
have hardware FPU support,
http://www.sourceware.org/ml/binutils/2013-07/msg00085.html

Index: gcc/config/rx/rx.h
===
--- gcc/config/rx/rx.h.orig 2013-07-18 18:03:11.0 +0530
+++ gcc/config/rx/rx.h  2013-07-11 14:57:17.0 +0530
@@ -101,6 +101,7 @@
 %{mpid} \
 %{mint-register=*} \
 %{mgcc-abi:-mgcc-abi} %{!mgcc-abi:-mrx-abi} \
+%{mcpu=*} \
 "
 
No regression found with this patch.

Please let me know if this is OK?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gas/config:
2013-07-18  Sandeep Kumar Singh  

* rx.h: Add option -mcpu for target variants RX100 and RX200.

[PING] [Patch RX] Add assembler option "-mcu" for generating assembler

[Sandeep Kumar Singh]

Hi,

Please find the patch to add assembler option "-mcu" for generating assembler
error messages when target not supporting hardware FPU were seeing FPU code,
namely RX100 and RX200.

KPIT has recently submitted a patch to add warnings of RX variants that do not
have hardware FPU support,
http://www.sourceware.org/ml/binutils/2013-07/msg00085.html

Index: gcc/config/rx/rx.h
===
--- gcc/config/rx/rx.h.orig 2013-07-18 18:03:11.0 +0530
+++ gcc/config/rx/rx.h  2013-07-11 14:57:17.0 +0530
@@ -101,6 +101,7 @@
 %{mpid} \
 %{mint-register=*} \
 %{mgcc-abi:-mgcc-abi} %{!mgcc-abi:-mrx-abi} \
+%{mcpu=*} \
 "
 
No regression found with this patch.

Please let me know if this is OK?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gas/config:
2013-07-18  Sandeep Kumar Singh  

* rx.h: Add option -mcpu for target variants RX100 and RX200.

[Patch RX] Add assembler option "-mcu" for generating assembler

[Sandeep Kumar Singh]

Hi,

Please find the patch to add assembler option "-mcu" for generating assembler
error messages when target not supporting hardware FPU were seeing FPU code,
namely RX100 and RX200.

KPIT has recently submitted a patch to add warnings of RX variants that do not
have hardware FPU support,
http://www.sourceware.org/ml/binutils/2013-07/msg00085.html

Index: gcc/config/rx/rx.h
===
--- gcc/config/rx/rx.h.orig 2013-07-18 18:03:11.0 +0530
+++ gcc/config/rx/rx.h  2013-07-11 14:57:17.0 +0530
@@ -101,6 +101,7 @@
 %{mpid} \
 %{mint-register=*} \
 %{mgcc-abi:-mgcc-abi} %{!mgcc-abi:-mrx-abi} \
+%{mcpu=*} \
 "
 
No regression found with this patch.

Please let me know if this is OK?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gas/config:
2013-07-18  Sandeep Kumar Singh  

* rx.h: Add option -mcpu for target variants RX100 and RX200.

RE: [PATCH RX] Added target specific macros for macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi Chung-Ju Wu,

Thanks for your help. Suggested changes has been committed.  

Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India


> -Original Message-
> From: Chung-Ju Wu [mailto:jasonw...@gmail.com]
> Sent: Monday, June 03, 2013 8:02 PM
> To: Sandeep Kumar Singh
> Cc: Gerald Pfeifer; gcc-patches@gcc.gnu.org; Kaushik Phatak
> Subject: Re: [PATCH RX] Added target specific macros for macros for RX100,
> RX200, and RX600
> 
> 2013/6/3 Sandeep Kumar Singh :
> > Hi Gerald,
> >
> > Below is the update to mention under changes link on GCC website.
> >
> > RX
> > The port now allows to specify the RX100, RX200, and RX600 
> > processors
> with the command
> > line options -mcpu=rx100, -mcpu=rx200 and -mcpu=rx600
> >
> > This update will go into:
> > "New Targets and Target Specific Improvements" heading
> >
> > Help to guide me for updating this on GCC website would be highly
> appreciated.
> >
> >
> > Regards,
> > Sandeep Kumar Singh,
> > KPIT Cummins InfoSystems Ltd.
> > Pune, India
> >
> >
> 
> Hi, Sandeep,
> 
> GCC website is available via CVS access:
>   http://gcc.gnu.org/cvs.html
> 
> I think your patch for wwwdoc can be presented as follows:
> 
> Index: htdocs/gcc-4.9/changes.html
> =
> ==
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.9/changes.html,v
> retrieving revision 1.15
> diff -r1.15 changes.html
> 176d175
> < 
> ---
> > RX
> >   
> >  The port now allows to specify the RX100, RX200, and RX600 
> > processors
> >   with the command line options -mcpu=rx100, -mcpu=rx200 and -
> mcpu=rx600.
> > 
> >   
> 
> 
> Best regards,
> jasonwucj

RE: [PATCH RX] Added target specific macros for macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi Gerald,

Below is the update to mention under changes link on GCC website.

RX
The port now allows to specify the RX100, RX200, and RX600 processors 
with the command
line options -mcpu=rx100, -mcpu=rx200 and -mcpu=rx600

This update will go into:
"New Targets and Target Specific Improvements" heading

Help to guide me for updating this on GCC website would be highly appreciated. 


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India



> -Original Message-
> From: Gerald Pfeifer [mailto:ger...@pfeifer.com]
> Sent: Sunday, June 02, 2013 11:50 PM
> To: Sandeep Kumar Singh
> Cc: gcc-patches@gcc.gnu.org; Kaushik Phatak
> Subject: Re: [PATCH RX] Added target specific macros for macros for RX100,
> RX200, and RX600
> 
> On Thu, 2 May 2013, Sandeep Kumar Singh wrote:
> > 2013-05-02  Sandeep Kumar Singh  
> >
> > * rx/rx.h (TARGET_CPU_CPP_BUILTINS): Add macros for RX100, RX200,
> and RX600.
> > * rx/rx.opt: Add macro for rx100 with string rx100 and value RX100.
> > * rx/rx-opts.h (rx_cpu_types): Add new cpu type rx100.
> > * rx/t-rx: Add rx100 under multi library matches option for nofpu 
> > option.
> 
> Mind also documenting this on http://gcc.gnu.org/gcc-4.9/changes.html ?
> 
> Let me know if you need help with the web pages.
> 
> Gerald

RE: [PING 2] [PATCH RX] Added target specific macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi Nick,

>> The patch is fine, please apply.
Thanks for the review.
I do not have write approvals to gcc-svn.
Could you please commit this for me?

Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India


> -Original Message-
> From: nick clifton [mailto:ni...@redhat.com]
> Sent: Wednesday, May 29, 2013 6:38 PM
> To: Sandeep Kumar Singh; gcc-patches@gcc.gnu.org
> Cc: Kaushik Phatak; Cecilia Rodrigues
> Subject: Re: [PING 2] [PATCH RX] Added target specific macros for RX100,
> RX200, and RX600
> 
> Hi Sandeep,
> 
> > Below patch added target specific macros for RX100, RX200, and RX600
> >
> > http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00050.html
> >
> > Please review the patch and let me know if there should be any
> > modifications in it?
> 
> Sorry - I missed your original posting.
> 
> The patch is fine, please apply.
> 
> Cheers
>Nick
> 
> 

[PING 2] [PATCH RX] Added target specific macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi,

Below patch added target specific macros for RX100, RX200, and RX600

http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00050.html

Please review the patch and let me know if there should be any
modifications in it?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

[PING] [PATCH RX] Added target specific macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi,

Below patch added target specific macros for RX100, RX200, and RX600

http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00050.html

Please review the patch and let me know if there should be any
modifications in it?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

[PATCH RX] Added target specific macros for macros for RX100, RX200, and RX600

[Sandeep Kumar Singh]

Hi,

Please find the attached patch to add specific macros related to targets.

The current RX port does not contain specific macros related to targets.
For the compiler option "-mcpu=name", the valid names are rx600, rx200
and rx610. RX610 was first target supported, so this macro may have
been added for testing purpose.

$rx-elf-gcc test.c -mcpu=rx600
The rx600 is the default target and defines the macro "__RX_FPU_INSNS__"

The below command will generate code specific for RX200, $rx-elf-gcc
test.c -
mcpu=rx200 This command does not pass any specific macro, but does not
define __RX_FPU_INSNS__.

The -mcpu option does not support the rx100 target name, however the
rx200 should have the same effect as this target also does not support FPU.

No regression found with this patch.

Please review the patch and let me know if there should be any
modifications in it?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India

gcc/ChangeLog
2013-05-02  Sandeep Kumar Singh  

* rx/rx.h (TARGET_CPU_CPP_BUILTINS): Add macros for RX100, RX200, and 
RX600. 
* rx/rx.opt: Add macro for rx100 with string rx100 and value RX100.
* rx/rx-opts.h (rx_cpu_types): Add new cpu type rx100.
* rx/t-rx: Add rx100 under multi library matches option for nofpu 
option.



rx_macros.patch
Description: rx_macros.patch

[PATCH H8300] Added offset bits of MOVA/Sz assembly instruction for memory access

[Sandeep Kumar Singh]

Hi,

Please find the attached patch that adds offset bits for mova/Sz assembly
instruction of memory access in H8SX target.

Please review the patch and let me know if there should be any 
modifications in it?

Tested with h8300-elf. No new regressions.

Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India


* gcc/ChangeLog:

2012-06-12  Sandeep Kumar Singh  

* config/h8300/genmova.sh: Modified to add offset bits of
mova/Sz assembly instruction for memory access.
* config/h8300/h8300.c: Likewise.
* config/h8300/mova.md: Likewise.



mova-offset.patch
Description: mova-offset.patch

Re: [PATCH H8300] Added -mno-exr option in case of function with "monitor" attribute

[Sandeep Kumar Singh]

Hello Jeff,

Thank you for reviewing the patch.

>> First, do you have an assignment on file with the FSF

We do have a corporate assignment for KPIT.

It was signed by Bradley Kuhn from FSF side and Dhananjay Deshpande 
from KPIT side, during April 2003. In a mail, Peter Brown from FSF has 
mentioned ticket number #22417 which was associated with this corporate
assignment. 

However, we do not have any assignment for individuals here. Please 
let me know whether we need to get it done for individuals as well.

>> My recollection was -mint32 was supported on the original H8/300; 
>> is there something in particular that makes you want to issue an 
>> error for that case?

My assumption was based on t-h8300 file. In this file, combination of 
h8300 and int32 is not considered for MULTILIB_OPTIONS. Did I 
misinterpret it? In that case I will remove the respective hunk from 
the patch and will repost it.

>> In h8300.opt, rather than say "Push exr on stack", would it make 
>> more sense to say "[Do not] Push extended registers on stack in 
>> monitor functions"?

Thank you for this suggestion. I have made this change. Please find the
updated patch attached here.

Thanks and Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India



patch-EXR.patch
Description: patch-EXR.patch


ChangeLog.patch
Description: ChangeLog.patch

[PATCH H8300] Added -mno-exr option in case of function with "monitor" attribute

[Sandeep Kumar Singh]

Hi,

Please find the attached patch to avoid saving of EXR register for
monitor functions.

By default, in prologue code of a monitor function, EXR register is
pushed onto the stack. This implementation is not required for H8S/224x
and 21xx variants of H8S controllers. The behavior can be controlled
with option "-mno-exr".

Built compiler is only for compiling C language source code. No 
regression found with this patch.

Compiler behavior with different command line options used for 
compilation of code after applying this patch is given below:

* h8300-elf-gcc -mn -S test.c
test.c:1:0: error: -mn is used without -mh or -ms or -msx

* h8300-elf-gcc -mh -mexr -S test.c
test.c:1:0: error: -mexr is used without -ms

* h8300-elf-gcc -mh -mno-exr -S test.c
test.c:1:0: warning: -mno-exr valid only with -ms or -msx   
- Option ignored! [-mno-exr]

* Generated assembly without option '-mno-exr': 
_testmonitor:
stc exr,@-er7
mov.l   er0,@-er7
stc ccr,r0l

* Generated assembly with option '-mno-exr':
_testmonitor:
mov.l   er0,@-er7
stc ccr,r0l

Please review the patch and let me know if there should be any
modifications in it?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India



ChangeLog.patch
Description: ChangeLog.patch


patch-EXR.patch
Description: patch-EXR.patch

Patch for -mno-exr option in case of function with "monitor" attribute

[Sandeep Kumar Singh]

Hi,

Please find the attached patch to avoid saving of EXR register for
monitor functions.

By default, in prologue code of a monitor function, EXR register is
pushed onto the stack. This implementation is not required for H8S/224x
and 21xx variants of H8S controllers. The behavior can be controlled
with the option "-mno-exr".

Built compiler is only for compiling C language source code. No 
regression found with this patch.

Compiler behavior with different command line options used for 
compilation of code after applying this patch is given below:

* h8300-elf-gcc -mn -S test.c
test.c:1:0: error: -mn is used without -mh or -ms or -msx

* h8300-elf-gcc -mh -mexr -S test.c
test.c:1:0: error: -mexr is used without -ms

* h8300-elf-gcc -mh -mno-exr -S test.c
test.c:1:0: warning: -mno-exr valid only with -ms or -msx   
- Option ignored! [-mno-exr]

* Generated assembly with option '-m-exr': 
_testmonitor:
stc exr,@-er7
mov.l   er0,@-er7
stc ccr,r0l

* Generated assembly with option '-mno-exr':
_testmonitor:
mov.l   er0,@-er7
stc ccr,r0l

Please review the patch and let me know if there should be any
modifications in it?


Regards,
Sandeep Kumar Singh,
KPIT Cummins InfoSystems Ltd.
Pune, India



ChangeLog.patch
Description: ChangeLog.patch


patch-EXR.patch
Description: patch-EXR.patch