On Fri, 2019-01-11 at 12:30 +0100, Jakub Jelinek wrote: > > > Yeah, like you say, this was originally posted in stage 1 and is the > > last patch in the series. Not committing it would leave the work > > incomplete in GCC 9. The problem is that we're now in stage 4 rather > > than stage 3. > > > > I don't think I'm neutral enough to make the call. Richard, Jakub? > > I'm ok with accepting this late as an exception, if it can be committed > reasonably soon (within a week or at most two). > > Jakub
OK, I will make the comment change and check it in. Note that this does not give us the complete implementation yet. Patch 3/4 was OK'ed by Richard last week but I hadn't checked that in either. So I will check both these in later today unless I haer otherwise. That still leaves Patch 2/4 which is Aarch64 specific. https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01421.html Jakub had some comments on the test changes which I fixed but I did not get any feedback on the actual code changes so I am not sure if that is OK or not. STeve Ellcey sell...@marvell.com