RE: [H8300] Use braced strings in MD
Hi, Great. I approved it this morning and it looks like your account was created soon thereafter. Thanks for the approval. My account has been created. add yourself to the MAINTAINTERS file with write-after-approval privileges. Done. http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00705.html Looks good. Please install. Similarly for the v850 changes. The h8300.md and v850.md are committed at the following links respectively on trunk:- http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00696.html http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00699.html Thanks for your help. Regards, Naveen
Re: [H8300] Use braced strings in MD
On 04/23/2012 12:17 AM, Naveen H. S wrote: Some of my colleagues here do have checkin rights but not me. I have now requested for checkin after approval rights. Is this ok? Great. I approved it this morning and it looks like your account was created soon thereafter. Please add yourself to the MAINTAINTERS file with write-after-approval privileges. Done. Braces are indented except for define_insn where they start at column 0. Thanks. The mis-indented braces in h8300.md are fixed as per my knowledge. Please review the attached patch and let me know if it's OK to commit with these changes? Looks good. Please install. Similarly for the v850 changes. Thanks! jeff
Re: [H8300] Use braced strings in MD
On 04/20/2012 03:37 AM, Naveen H. S wrote: Hi, Please find attached the patch h8300_indent.patch that adapts H8300 machine descriptions to the braced string notation. The changes makes the Machine Descriptor file more easier to read. It is similar to the following changes in SH target. http://gcc.gnu.org/ml/gcc-patches/2012-03/msg01315.html Tested with C testsuite for h8300-elf. No new regressions. ChangeLog * config/h8300/h8300.md: Use braced string notation where applicable. This is fine. Do you have checkin privs for the GCC repository? If not, please request them so you can check in your patches. Like Mike, I think the braces ought to be indented, but there's a multitude of mis-indented braces in h8300.md already. If you wanted to fix up that aspect of formatting the md file, that'd be a fine follow-up patch. Jeff
