Re: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
On Wed, Mar 20, 2013 at 2:43 AM, Xinyu Qi x...@marvell.com wrote: At 2013-01-22 19:58:43,Ramana Radhakrishnan ramra...@arm.com wrote: On 01/22/13 09:21, Xinyu Qi wrote: Ping, Fix ChangeLog The ChangeLog format includes . date Author's name a...@c.com If you want a patch accepted in the future, please help by creating the Changelog entry in the correct format, i.e. fill in the author's name as well as email address as below. I've created an entry as below. Please remember to do so for every patch you submit - thanks. DATE Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. Anyway, please apply. regards, Ramana Hi Ramana, Since I have no write access, would you mind to help to check in this patch? The patch is attached. ChangeLog 2013-01-31 Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Now applied to trunk .sorry about the delay. Ramana
RE: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
At 2013-01-22 19:58:43,Ramana Radhakrishnan ramra...@arm.com wrote: On 01/22/13 09:21, Xinyu Qi wrote: Ping, Fix ChangeLog The ChangeLog format includes . date Author's name a...@c.com If you want a patch accepted in the future, please help by creating the Changelog entry in the correct format, i.e. fill in the author's name as well as email address as below. I've created an entry as below. Please remember to do so for every patch you submit - thanks. DATE Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. Anyway, please apply. regards, Ramana Hi Ramana, Since I have no write access, would you mind to help to check in this patch? The patch is attached. ChangeLog 2013-01-31 Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Thanks, Xinyu WCGR.DIFF Description: WCGR.DIFF
RE: [PATCH, ARM, iWMMXT] Fix define_constants for WCGR
At 2013-01-22 19:58:43,Ramana Radhakrishnan ramra...@arm.com wrote: On 01/22/13 09:21, Xinyu Qi wrote: Ping, Fix ChangeLog The ChangeLog format includes . date Author's name a...@c.com If you want a patch accepted in the future, please help by creating the Changelog entry in the correct format, i.e. fill in the author's name as well as email address as below. I've created an entry as below. Please remember to do so for every patch you submit - thanks. DATE Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. Anyway, please apply. regards, Ramana Hi Nick, Since I have no write access, would you mind to help to check in this patch which has already been approved? The patch is attached. ChangeLog 2013-01-31 Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Thanks, Xinyu WCGR.diff Description: WCGR.diff
RE: [PING][PATCH, ARM, iWMMXT] Fix define_constants for WCGR
Ping, Fix ChangeLog * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. Hi, It is necessary to sync the constants WCGR0 to WCGR3 in iwmmxt.md with the IWMMXT_GR_REGNUM in arm.h. ChangeLog * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0, WCGR1): Update. * config/arm/iwmmxt.md (WCGR2, WCGR3): Likewise. Index: config/arm/arm.h === --- config/arm/arm.h (revision 194603) +++ config/arm/arm.h (working copy) @@ -947,6 +947,8 @@ #define FIRST_IWMMXT_REGNUM (LAST_HI_VFP_REGNUM + 1) #define LAST_IWMMXT_REGNUM (FIRST_IWMMXT_REGNUM + 15) + +/* Need to sync with WCGR in iwmmxt.md. */ #define FIRST_IWMMXT_GR_REGNUM (LAST_IWMMXT_REGNUM + 1) #define LAST_IWMMXT_GR_REGNUM(FIRST_IWMMXT_GR_REGNUM + 3) Index: config/arm/iwmmxt.md === --- config/arm/iwmmxt.md (revision 194603) +++ config/arm/iwmmxt.md (working copy) @@ -19,12 +19,12 @@ ;; along with GCC; see the file COPYING3. If not see ;; http://www.gnu.org/licenses/. -;; Register numbers +;; Register numbers. Need to sync with FIRST_IWMMXT_GR_REGNUM in arm.h (define_constants - [(WCGR0 43) - (WCGR1 44) - (WCGR2 45) - (WCGR3 46) + [(WCGR0 96) + (WCGR1 97) + (WCGR2 98) + (WCGR3 99) ] ) OK? Thanks, Xinyu
Re: [PING][PATCH, ARM, iWMMXT] Fix define_constants for WCGR
On 01/22/13 09:21, Xinyu Qi wrote: Ping, Fix ChangeLog The ChangeLog format includes . date Author's name a...@c.com If you want a patch accepted in the future, please help by creating the Changelog entry in the correct format, i.e. fill in the author's name as well as email address as below. I've created an entry as below. Please remember to do so for every patch you submit - thanks. DATE Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. Anyway, please apply. regards, Ramana
Re: [PING][PATCH, ARM, iWMMXT] Fix define_constants for WCGR
Ramana Radhakrishnan ramra...@arm.com writes: The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. You can follow the references and look up the message-id via http://mid.gmane.org/msg-id. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 And now for something completely different.
RE: [PING][PATCH, ARM, iWMMXT] Fix define_constants for WCGR
At 2013-01-22 19:58:43,Ramana Radhakrishnan ramra...@arm.com wrote: On 01/22/13 09:21, Xinyu Qi wrote: Ping, Fix ChangeLog The ChangeLog format includes . date Author's name a...@c.com If you want a patch accepted in the future, please help by creating the Changelog entry in the correct format, i.e. fill in the author's name as well as email address as below. I've created an entry as below. Please remember to do so for every patch you submit - thanks. DATE Xinyu Qi x...@marvell.com * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0): Update. (WCGR1, WCGR2, WCGR3): Likewise. The patch by itself is OK but surprisingly I never saw this earlier. Your ping has removed the date from the original post so I couldn't track it down. Hi Ramana, Thanks for reviewing. I forget to keep the date which shows the original post is at Wed, 26 Dec 2012 You can find it at http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01418.html I would remember to set the correct Changelog entry next time. Anyway, please apply. BTW, since I have no write access, would you mind to help to check in this patch? Thanks! Xinyu regards, Ramana
[PATCH, ARM, iWMMXT] Fix define_constants for WCGR
Hi, It is necessary to sync the constants WCGR0 to WCGR3 in iwmmxt.md with the IWMMXT_GR_REGNUM in arm.h. ChangeLog * config/arm/arm.h (FIRST_IWMMXT_GR_REGNUM): Add comment. * config/arm/iwmmxt.md (WCGR0, WCGR1): Update. * config/arm/iwmmxt.md (WCGR2, WCGR3): Likewise. Index: config/arm/arm.h === --- config/arm/arm.h(revision 194603) +++ config/arm/arm.h(working copy) @@ -947,6 +947,8 @@ #define FIRST_IWMMXT_REGNUM(LAST_HI_VFP_REGNUM + 1) #define LAST_IWMMXT_REGNUM (FIRST_IWMMXT_REGNUM + 15) + +/* Need to sync with WCGR in iwmmxt.md. */ #define FIRST_IWMMXT_GR_REGNUM (LAST_IWMMXT_REGNUM + 1) #define LAST_IWMMXT_GR_REGNUM (FIRST_IWMMXT_GR_REGNUM + 3) Index: config/arm/iwmmxt.md === --- config/arm/iwmmxt.md(revision 194603) +++ config/arm/iwmmxt.md(working copy) @@ -19,12 +19,12 @@ ;; along with GCC; see the file COPYING3. If not see ;; http://www.gnu.org/licenses/. -;; Register numbers +;; Register numbers. Need to sync with FIRST_IWMMXT_GR_REGNUM in arm.h (define_constants - [(WCGR0 43) - (WCGR1 44) - (WCGR2 45) - (WCGR3 46) + [(WCGR0 96) + (WCGR1 97) + (WCGR2 98) + (WCGR3 99) ] ) OK? Thanks, Xinyu
