[PATCH, TSAN] Fix a crash in ScopedReport::AddThread

[Bernd Edlinger]

Hi Jakub,


with my OPC UA Server, I observe a reproducible crash in
ScopedReport::AddThread: tctx==NULL
in "if ((u32)rep_->threads[i]->id == tctx->tid)".

Apparently, Dmitry has already fixed that in the obvious way.

So we should cherry pick these two changes from LLVM: 224508 and 224755
See attachment.


Builds cleanly and fixes the problem for me.

OK for trunk?


Thanks
Bernd.
  

patch-tsan-crash.diff
Description: Binary data

Re: [PATCH, TSAN] Fix a crash in ScopedReport::AddThread

[Dmitry Vyukov]

OK

On Wed, Mar 11, 2015 at 5:41 PM, Bernd Edlinger
 wrote:
> Hi Jakub,
>
>
> with my OPC UA Server, I observe a reproducible crash in
> ScopedReport::AddThread: tctx==NULL
> in "if ((u32)rep_->threads[i]->id == tctx->tid)".
>
> Apparently, Dmitry has already fixed that in the obvious way.
>
> So we should cherry pick these two changes from LLVM: 224508 and 224755
> See attachment.
>
>
> Builds cleanly and fixes the problem for me.
>
> OK for trunk?
>
>
> Thanks
> Bernd.
>

Re: [PATCH, TSAN] Fix a crash in ScopedReport::AddThread

[Jakub Jelinek]

On Wed, Mar 11, 2015 at 03:41:27PM +0100, Bernd Edlinger wrote:
> Hi Jakub,
> 
> 
> with my OPC UA Server, I observe a reproducible crash in
> ScopedReport::AddThread: tctx==NULL
> in "if ((u32)rep_->threads[i]->id == tctx->tid)".
> 
> Apparently, Dmitry has already fixed that in the obvious way.
> 
> So we should cherry pick these two changes from LLVM: 224508 and 224755
> See attachment.
> 
> 
> Builds cleanly and fixes the problem for me.
> 
> OK for trunk?

Ok.

Jakub