Re: [PATCH, i386, Android] Add Android support for i386 target
http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00511.html
Re: [PATCH, i386, Android] Add Android support for i386 target
On 18/04/2012, at 2:32 AM, Ilya Enkovich wrote: >> On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: ... >> >> The patch looks OK to me in the sense, that there is no difference for >> x86 targets. >> >> So, OK for x86. >> >> Thanks, >> Uros. > > Thanks, Uros! > > Maxim, could you please look at patch? The Android parts of the patch are also good. Given that Uros approved the x86 pieces, you are clear to check in. Ilya, thanks for bearing with the us and reworking your patch after the reviews. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics
Re: [PATCH, i386, Android] Add Android support for i386 target
> On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: >> On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich >> wrote: > > It has nothing but defines for Android. It did not move any existing > code to this file. > Adding linux-common.h to i386 backend needs approval from i386 backend maintainer. If a patch also adds Android support, i386 backend maintainer may not feel comfortable to review it. However, if you simplify add linux-common.h with XXX_SPEC, i386 backend maintainer can review it easily. -- H.J. >>> >>> All XXX_SPEC in linux-common.h are Android related. I also believe >>> that my Android specific changes need i386 backend maintainer approval >>> anyway because wrong Android support implementation may break other >>> targets. >> >> +#undef ENDFILE_SPEC >> +#define ENDFILE_SPEC \ >> + GNU_USER_TARGET_MATHFILE_SPEC " " \ >> + GNU_USER_TARGET_ENDFILE_SPEC >> >> Where is GNU_USER_TARGET_ENDFILE_SPEC defined? > > Oh, I found it. > > The patch looks OK to me in the sense, that there is no difference for > x86 targets. > > So, OK for x86. > > Thanks, > Uros. Thanks, Uros! Maxim, could you please look at patch? Thanks, Ilya
Re: [PATCH, i386, Android] Add Android support for i386 target
On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: > On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich > wrote: It has nothing but defines for Android. It did not move any existing code to this file. >>> >>> Adding linux-common.h to i386 backend needs approval from >>> i386 backend maintainer. If a patch also adds Android support, >>> i386 backend maintainer may not feel comfortable to review it. >>> However, if you simplify add linux-common.h with XXX_SPEC, >>> i386 backend maintainer can review it easily. >>> >>> -- >>> H.J. >> >> All XXX_SPEC in linux-common.h are Android related. I also believe >> that my Android specific changes need i386 backend maintainer approval >> anyway because wrong Android support implementation may break other >> targets. > > +#undef ENDFILE_SPEC > +#define ENDFILE_SPEC \ > + GNU_USER_TARGET_MATHFILE_SPEC " " \ > + GNU_USER_TARGET_ENDFILE_SPEC > > Where is GNU_USER_TARGET_ENDFILE_SPEC defined? Oh, I found it. The patch looks OK to me in the sense, that there is no difference for x86 targets. So, OK for x86. Thanks, Uros.
Re: [PATCH, i386, Android] Add Android support for i386 target
On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich wrote: >>> >>> It has nothing but defines for Android. It did not move any existing >>> code to this file. >>> >> >> Adding linux-common.h to i386 backend needs approval from >> i386 backend maintainer. If a patch also adds Android support, >> i386 backend maintainer may not feel comfortable to review it. >> However, if you simplify add linux-common.h with XXX_SPEC, >> i386 backend maintainer can review it easily. >> >> -- >> H.J. > > All XXX_SPEC in linux-common.h are Android related. I also believe > that my Android specific changes need i386 backend maintainer approval > anyway because wrong Android support implementation may break other > targets. +#undef ENDFILE_SPEC +#define ENDFILE_SPEC \ + GNU_USER_TARGET_MATHFILE_SPEC " " \ + GNU_USER_TARGET_ENDFILE_SPEC Where is GNU_USER_TARGET_ENDFILE_SPEC defined? Uros.
Re: [PATCH, i386, Android] Add Android support for i386 target
>> >> It has nothing but defines for Android. It did not move any existing >> code to this file. >> > > Adding linux-common.h to i386 backend needs approval from > i386 backend maintainer. If a patch also adds Android support, > i386 backend maintainer may not feel comfortable to review it. > However, if you simplify add linux-common.h with XXX_SPEC, > i386 backend maintainer can review it easily. > > -- > H.J. All XXX_SPEC in linux-common.h are Android related. I also believe that my Android specific changes need i386 backend maintainer approval anyway because wrong Android support implementation may break other targets. Could please someone from maintainers tell me if it is needed to split this patch? Thanks, Ilya
Re: [PATCH, i386, Android] Add Android support for i386 target
On Mon, Apr 16, 2012 at 9:08 AM, Ilya Enkovich wrote: >> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich >> wrote: Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android support. Thanks. H.J. --- >>> Hi, >>> >>> The first part will just add empty file. What is the reason to do it? >>> Testing will not even reveal if I added it incorrectly. >>> >> >> It should contain everything, minus any new Android changes, >> which should be in the second patch. > > It has nothing but defines for Android. It did not move any existing > code to this file. > Adding linux-common.h to i386 backend needs approval from i386 backend maintainer. If a patch also adds Android support, i386 backend maintainer may not feel comfortable to review it. However, if you simplify add linux-common.h with XXX_SPEC, i386 backend maintainer can review it easily. -- H.J.
Re: [PATCH, i386, Android] Add Android support for i386 target
> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich wrote: >>> >>> Maybe it is better to break it into 2 patches: >>> >>> 1. Introduce config/i386/linux-common.h with any new functionalities >>> 2. Add Android support. >>> >>> Thanks. >>> >>> >>> H.J. >>> --- >> Hi, >> >> The first part will just add empty file. What is the reason to do it? >> Testing will not even reveal if I added it incorrectly. >> > > It should contain everything, minus any new Android changes, > which should be in the second patch. It has nothing but defines for Android. It did not move any existing code to this file. Ilya > > -- > H.J.
Re: [PATCH, i386, Android] Add Android support for i386 target
On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich wrote: >> >> Maybe it is better to break it into 2 patches: >> >> 1. Introduce config/i386/linux-common.h with any new functionalities >> 2. Add Android support. >> >> Thanks. >> >> >> H.J. >> --- > Hi, > > The first part will just add empty file. What is the reason to do it? > Testing will not even reveal if I added it incorrectly. > It should contain everything, minus any new Android changes, which should be in the second patch. -- H.J.
Re: [PATCH, i386, Android] Add Android support for i386 target
> > Maybe it is better to break it into 2 patches: > > 1. Introduce config/i386/linux-common.h with any new functionalities > 2. Add Android support. > > Thanks. > > > H.J. > --- Hi, The first part will just add empty file. What is the reason to do it? Testing will not even reveal if I added it incorrectly. Thanks, Ilya
Re: [PATCH, i386, Android] Add Android support for i386 target
On Mon, Apr 16, 2012 at 8:33 AM, Ilya Enkovich wrote: > Hello, > > Here is patch for i386 Android support. It is the second part of > previously splitted patch > (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first > part has been committed > (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00378.html). Bootstrapped > and checked on linux-x86_64. OK for trunk? Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android support. Thanks. H.J. --- > Thanks, > Ilya > --- > 2012-04-16 Enkovich Ilya > > * config/i386/linux-common.h: New. > > * config.gcc: Add i386/linux-common.h before > all i386/linux.h and i386/linux64.h usages. > > * config/i386/gnu-user.h (GNU_USER_TARGET_LINK_SPEC): New. > (LINK_SPEC): Use GNU_USER_TARGET_LINK_SPEC. > * config/i386/gnu-user64.h: Likewise. > > * config/i386/gnu-user.common.h (GNU_USER_TARGET_CC1_SPEC): New. > (CC1_SPEC): Use GNU_USER_TARGET_CC1_SPEC. > (GNU_USER_TARGET_MATHFILE_SPEC): New. > (ENDFILE_SPEC): Use GNU_USER_TARGET_MATHFILE_SPEC.
[PATCH, i386, Android] Add Android support for i386 target
Hello, Here is patch for i386 Android support. It is the second part of previously splitted patch (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first part has been committed (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00378.html). Bootstrapped and checked on linux-x86_64. OK for trunk? Thanks, Ilya --- 2012-04-16 Enkovich Ilya * config/i386/linux-common.h: New. * config.gcc: Add i386/linux-common.h before all i386/linux.h and i386/linux64.h usages. * config/i386/gnu-user.h (GNU_USER_TARGET_LINK_SPEC): New. (LINK_SPEC): Use GNU_USER_TARGET_LINK_SPEC. * config/i386/gnu-user64.h: Likewise. * config/i386/gnu-user.common.h (GNU_USER_TARGET_CC1_SPEC): New. (CC1_SPEC): Use GNU_USER_TARGET_CC1_SPEC. (GNU_USER_TARGET_MATHFILE_SPEC): New. (ENDFILE_SPEC): Use GNU_USER_TARGET_MATHFILE_SPEC. mandroid.patch Description: Binary data
