Re: [PATCH][AArch64] Documentation fix for -fpic
On 12/11/15 11:30, Szabolcs Nagy wrote:
> The documentation for -fpic and -fPIC explicitly mentions some targets
> where the difference matters, but not AArch64. Specifying the GOT size
> limit is not entirely correct as it can depend on the -mcmodel setting,
> but probably better than leaving the impression that -fpic vs -fPIC does
> not matter on AArch64.
>
> ChangeLog:
>
> 2015-11-12 Szabolcs Nagy
>
> * doc/invoke.texi (-fpic): Add the AArch64 limit.
> (-fPIC): Add AArch64.
>
> fpic.diff
>
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 0121832..f925fe0 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -23951,7 +23951,7 @@ loader is not part of GCC; it is part of the
> operating system). If
> the GOT size for the linked executable exceeds a machine-specific
> maximum size, you get an error message from the linker indicating that
> @option{-fpic} does not work; in that case, recompile with @option{-fPIC}
> -instead. (These maximums are 8k on the SPARC and 32k
> +instead. (These maximums are 8k on the SPARC, 28k on AArch64 and 32k
> on the m68k and RS/6000. The x86 has no such limit.)
>
> Position-independent code requires special support, and therefore works
> @@ -23966,7 +23966,7 @@ are defined to 1.
> @opindex fPIC
> If supported for the target machine, emit position-independent code,
> suitable for dynamic linking and avoiding any limit on the size of the
> -global offset table. This option makes a difference on the m68k,
> +global offset table. This option makes a difference on the AArch64, m68k,
^^^
The use of the definite article here makes this read somewhat awkwardly
(particularly as AArch64 is first and is a term for a set of processor
implementations). I think it would read better if it were dropped:
"This option makes a difference on AArch64, m68k,..."
> PowerPC and SPARC@.
>
> Position-independent code requires special support, and therefore works
>
OK with that change if nobody else objects within 24 hours.
R.
Re: [PATCH][AArch64] Documentation fix for -fpic
On 12/11/15 11:30, Szabolcs Nagy wrote: The documentation for -fpic and -fPIC explicitly mentions some targets where the difference matters, but not AArch64. Specifying the GOT size limit is not entirely correct as it can depend on the -mcmodel setting, but probably better than leaving the impression that -fpic vs -fPIC does not matter on AArch64. ping. ChangeLog: 2015-11-12 Szabolcs Nagy * doc/invoke.texi (-fpic): Add the AArch64 limit. (-fPIC): Add AArch64.
[PATCH][AArch64] Documentation fix for -fpic
The documentation for -fpic and -fPIC explicitly mentions some targets
where the difference matters, but not AArch64. Specifying the GOT size
limit is not entirely correct as it can depend on the -mcmodel setting,
but probably better than leaving the impression that -fpic vs -fPIC does
not matter on AArch64.
ChangeLog:
2015-11-12 Szabolcs Nagy
* doc/invoke.texi (-fpic): Add the AArch64 limit.
(-fPIC): Add AArch64.
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 0121832..f925fe0 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -23951,7 +23951,7 @@ loader is not part of GCC; it is part of the operating system). If
the GOT size for the linked executable exceeds a machine-specific
maximum size, you get an error message from the linker indicating that
@option{-fpic} does not work; in that case, recompile with @option{-fPIC}
-instead. (These maximums are 8k on the SPARC and 32k
+instead. (These maximums are 8k on the SPARC, 28k on AArch64 and 32k
on the m68k and RS/6000. The x86 has no such limit.)
Position-independent code requires special support, and therefore works
@@ -23966,7 +23966,7 @@ are defined to 1.
@opindex fPIC
If supported for the target machine, emit position-independent code,
suitable for dynamic linking and avoiding any limit on the size of the
-global offset table. This option makes a difference on the m68k,
+global offset table. This option makes a difference on the AArch64, m68k,
PowerPC and SPARC@.
Position-independent code requires special support, and therefore works
