Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Mike Stump]

On Nov 16, 2016, at 10:58 AM, Mike Stump  wrote:
> 
> Yeah, I easily could have approved it as well, so no worries.

Oh.  I see I did approve the original patch, sorry for not catching it.  Thanks 
for all your work.

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Mike Stump]

On Nov 16, 2016, at 7:57 AM, Tamar Christina  wrote:
> 
> Forgot to include the committed patch.

>>> This is causing all test names to depend on $srcdir.  A test name
>>> should never include the value of $srcdir.
>> 
>> Sorry about that, committed a fix as r242500 under the obvious rule.

Yeah, I easily could have approved it as well, so no worries.

The patch is Ok.

The way I usually catch this would be in reviewing the output of 
./contrib/compare_tests, it would complain about a ton of new tests now not 
passing, which is a dead giveaway.

RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Tamar Christina]

Forgot to include the committed patch.

> -Original Message-
> From: Tamar Christina
> Sent: 16 November 2016 15:55
> To: Andreas Schwab; Mike Stump
> Cc: GCC Patches; r...@cebitec.uni-bielefeld.de; nd
> Subject: RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend
> on
> 
> >
> > This is causing all test names to depend on $srcdir.  A test name
> > should never include the value of $srcdir.
> 
> Sorry about that, committed a fix as r242500 under the obvious rule.
> 
> Thanks,
> Tamar
> 
> >
> > Andreas.
> >
> > --
> > Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196
> > BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7 "And now for something
> > completely different."


trad-name-mangling-fix.patch
Description: trad-name-mangling-fix.patch

RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Tamar Christina]

> 
> This is causing all test names to depend on $srcdir.  A test name should never
> include the value of $srcdir.

Sorry about that, committed a fix as r242500 under the obvious rule.

Thanks,
Tamar

> 
> Andreas.
> 
> --
> Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196
> BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7 "And now for something
> completely different."

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Andreas Schwab]

On Nov 07 2016, Mike Stump  wrote:

> On Nov 1, 2016, at 8:46 AM, Tamar Christina  wrote:
>> 
>> A glibc update recently broke this test by adding a CPP
>> macro that uses the ## string function which traditional-cpp
>> does not support.
>> The change in glibc that made the test fail is from
>> 6962682ffe5e5f0373047a0b894fee7a774be254.
>> 
>> This fixes (PR78136) by changing the test to use a local
>> include file instead of one from glibc.
>> The intention of the test is to test that traditional-cpp does
>> not expand values inside <> blocks of #includes.
>> As such the include has to be included via <> syntax. To do this
>> the .exp has been modified to add the test directory to the
>> Include search path.
>> 
>> Ran regression tests on aarch64-none-linux-gnu.
>> 
>> Ok for trunk?
>
> Ok.

This is causing all test names to depend on $srcdir.  A test name should
never include the value of $srcdir.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

RE: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Tamar Christina]

> Can you remove the comment: Newlib uses ## when including stdlib.h as of
> 2007-09-07.  while you are at it?  I think it doesn't make any sense post the
> change unless one reads history.
> 

No problem,
Thanks

> > 2016-10-31  Tamar Christina  
> >
> > PR testsuite/78136
> > * gcc.dg/cpp/trad/trad.exp
> > (dg-runtest): Added $srcdir/$subdir/ to Include dirs.
> > * gcc.dg/cpp/trad/include.c: Use local header
> > file.

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Mike Stump]

On Nov 1, 2016, at 8:46 AM, Tamar Christina  wrote:
> 
> A glibc update recently broke this test by adding a CPP
> macro that uses the ## string function which traditional-cpp
> does not support.
> The change in glibc that made the test fail is from
> 6962682ffe5e5f0373047a0b894fee7a774be254.
> 
> This fixes (PR78136) by changing the test to use a local
> include file instead of one from glibc.
> The intention of the test is to test that traditional-cpp does
> not expand values inside <> blocks of #includes.
> As such the include has to be included via <> syntax. To do this
> the .exp has been modified to add the test directory to the
> Include search path.
> 
> Ran regression tests on aarch64-none-linux-gnu.
> 
> Ok for trunk?

Ok.

Can you remove the comment: Newlib uses ## when including stdlib.h as of 
2007-09-07.  while you are at it?  I think it doesn't make any sense post the 
change unless one reads history.

> 2016-10-31  Tamar Christina  
> 
>   PR testsuite/78136
>   * gcc.dg/cpp/trad/trad.exp
>   (dg-runtest): Added $srcdir/$subdir/ to Include dirs.
>   * gcc.dg/cpp/trad/include.c: Use local header 
> file.

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Tamar Christina]

Ping.


From: gcc-patches-ow...@gcc.gnu.org <gcc-patches-ow...@gcc.gnu.org> on behalf 
of Tamar Christina <tamar.christ...@arm.com>
Sent: Tuesday, November 1, 2016 3:46:07 PM
To: GCC Patches; r...@cebitec.uni-bielefeld.de; mikest...@comcast.net
Cc: nd
Subject: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

Hi all,

A glibc update recently broke this test by adding a CPP
macro that uses the ## string function which traditional-cpp
does not support.
The change in glibc that made the test fail is from
6962682ffe5e5f0373047a0b894fee7a774be254.

This fixes (PR78136) by changing the test to use a local
include file instead of one from glibc.
The intention of the test is to test that traditional-cpp does
not expand values inside <> blocks of #includes.
As such the include has to be included via <> syntax. To do this
the .exp has been modified to add the test directory to the
Include search path.

Ran regression tests on aarch64-none-linux-gnu.

Ok for trunk?

Thanks,
Tamar

gcc/testsuite/

2016-10-31  Tamar Christina  <tamar.christ...@arm.com>

PR testsuite/78136
* gcc.dg/cpp/trad/trad.exp
(dg-runtest): Added $srcdir/$subdir/ to Include dirs.
* gcc.dg/cpp/trad/include.c: Use local header file.

[PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

[Tamar Christina]

Hi all,

A glibc update recently broke this test by adding a CPP
macro that uses the ## string function which traditional-cpp
does not support.
The change in glibc that made the test fail is from
6962682ffe5e5f0373047a0b894fee7a774be254.

This fixes (PR78136) by changing the test to use a local
include file instead of one from glibc.
The intention of the test is to test that traditional-cpp does
not expand values inside <> blocks of #includes.
As such the include has to be included via <> syntax. To do this
the .exp has been modified to add the test directory to the
Include search path.

Ran regression tests on aarch64-none-linux-gnu.

Ok for trunk?

Thanks,
Tamar

gcc/testsuite/

2016-10-31  Tamar Christina  

PR testsuite/78136
* gcc.dg/cpp/trad/trad.exp
(dg-runtest): Added $srcdir/$subdir/ to Include dirs.
* gcc.dg/cpp/trad/include.c: Use local header file.

pr78136-fix-tradition-cpp
Description: pr78136-fix-tradition-cpp