Re: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and constants
Now with the zipped patch so it reaches the mailing list. Sorry for that. On 07/04/2020 09:57, Kyrylo Tkachov wrote: -Original Message- From: Andre Vieira (lists) Sent: 07 April 2020 09:57 To: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and constants Hi, I rebased this patch and made some extra fixes. This patch merges some polymorphic functions that were uncorrectly separating scalar variants. It also simplifies the way we detect scalars and constants in mve_typeid. I also fixed some polymorphic intrinsics that were splitting of scalar cases. Regression tested for arm-none-eabi. Is this OK for trunk? Ok. Thanks, Kyrill 2020-04-07 Andre Vieira * config/arm/arm_mve.h (vsubq_n): Merge with... (vsubq): ... this. (vmulq_n): Merge with... (vmulq): ... this. (__ARM_mve_typeid): Simplify scalar and constant detection. 2020-04-07 Andre Vieira * gcc.target/arm/mve/intrinsics/vmulq_n_f16.c: Fix test. * gcc.target/arm/mve/intrinsics/vmulq_n_f32.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_s16.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_s32.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_s8.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_u16.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_u32.c: Likewise. * gcc.target/arm/mve/intrinsics/vmulq_n_u8.c: Likewise. On 02/04/2020 10:58, Kyrylo Tkachov wrote: -Original Message- From: Andre Vieira (lists) Sent: 02 April 2020 09:22 To: gcc-patches@gcc.gnu.org Cc: Kyrylo Tkachov Subject: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and constants Hi, This patch merges some polymorphic functions that were incorrectly separating scalar variants. It also simplifies the way we detect scalars and constants in mve_typeid. Regression tested for arm-none-eabi. Is this OK for trunk? Ok. Thanks, Kyrill 2020-04-02 Andre Vieira * config/arm/arm_mve.h (vsubq_n): Merge with... (vsubq): ... this. (vmulq_n): Merge with... (vmulq): ... this. (__ARM_mve_typeid): Simplify scalar and constant detection. <>
RE: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and constants
> -Original Message- > From: Andre Vieira (lists) > Sent: 07 April 2020 09:57 > To: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and > constants > > Hi, > > I rebased this patch and made some extra fixes. > > This patch merges some polymorphic functions that were uncorrectly > separating scalar variants. It also simplifies the way we detect > scalars and constants in mve_typeid. > > I also fixed some polymorphic intrinsics that were splitting of scalar cases. > > Regression tested for arm-none-eabi. > > Is this OK for trunk? Ok. Thanks, Kyrill > > 2020-04-07 Andre Vieira > > * config/arm/arm_mve.h (vsubq_n): Merge with... > (vsubq): ... this. > (vmulq_n): Merge with... > (vmulq): ... this. > (__ARM_mve_typeid): Simplify scalar and constant detection. > > 2020-04-07 Andre Vieira > > * gcc.target/arm/mve/intrinsics/vmulq_n_f16.c: Fix test. > * gcc.target/arm/mve/intrinsics/vmulq_n_f32.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_s16.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_s32.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_s8.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_u16.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_u32.c: Likewise. > * gcc.target/arm/mve/intrinsics/vmulq_n_u8.c: Likewise. > > On 02/04/2020 10:58, Kyrylo Tkachov wrote: > > > >> -Original Message- > >> From: Andre Vieira (lists) > >> Sent: 02 April 2020 09:22 > >> To: gcc-patches@gcc.gnu.org > >> Cc: Kyrylo Tkachov > >> Subject: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and > >> constants > >> > >> Hi, > >> > >> This patch merges some polymorphic functions that were incorrectly > >> separating scalar variants. It also simplifies the way we detect > >> scalars and constants in mve_typeid. > >> > >> Regression tested for arm-none-eabi. > >> > >> Is this OK for trunk? > > Ok. > > Thanks, > > Kyrill > > > >> 2020-04-02 Andre Vieira > >> > >> * config/arm/arm_mve.h (vsubq_n): Merge with... > >> (vsubq): ... this. > >> (vmulq_n): Merge with... > >> (vmulq): ... this. > >> (__ARM_mve_typeid): Simplify scalar and constant detection.
RE: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and constants
> -Original Message- > From: Andre Vieira (lists) > Sent: 02 April 2020 09:22 > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov > Subject: [PATCH][GCC][Arm]: MVE: Fix polymorphism for scalars and > constants > > Hi, > > This patch merges some polymorphic functions that were incorrectly > separating scalar variants. It also simplifies the way we detect scalars and > constants in mve_typeid. > > Regression tested for arm-none-eabi. > > Is this OK for trunk? Ok. Thanks, Kyrill > > 2020-04-02 Andre Vieira > > * config/arm/arm_mve.h (vsubq_n): Merge with... > (vsubq): ... this. > (vmulq_n): Merge with... > (vmulq): ... this. > (__ARM_mve_typeid): Simplify scalar and constant detection.
