Re: [PATCH] [JAVA] patch for Java on RTEMS
On 08/14/2011 03:03 PM, Jie Liu wrote: Hi, I have add the boehm-gc patch and the configure for gcc patch to the patch attached. So we can add this patch and then compile gcj for RTEMS. Best Regards, Jie --- boehm-gc/include/private/gcconfig.h (revision 172224) +++ boehm-gc/include/private/gcconfig.h (working copy) .. @@ -1297,6 +1302,19 @@ # define STACKBOTTOM ((ptr_t)0xc000) # define DATAEND /* not needed */ # endif +# ifdef RTEMS +# define OS_TYPE "RTEMS" +# include Why sys/unistd.h? sys/unistd.h is not supposed to be accessed directly. This likely should be a plain simple "#include " Ralf
Re: [PATCH] [JAVA] patch for Java on RTEMS
* Jie Liu wrote on Mon, Aug 15, 2011 at 04:07:36PM CEST:
> > Looks OK, but there is no ChangeLog. Do you have copyright
> > assignment?
>
> Have added ChangeLog to the patch, please see the attachment. And I
> think I have copyright assignment, because I have Free Software
> Foundation paperwork, as "ASSIGNMENT - GNU GCC ... JIE RT688742"
The build-system specific parts of the patch are OK, provided
that they have been sufficiently tested. When committing
top-level changes, please make sure they are synced to the
src repository; if you don't have write access to src, please
ask someone who has to do that for you.
I think you still need approval for the boehm-gc related changes.
Please also try to send patches with some text MIME type.
Thanks,
Ralf
> --- boehm-gc/ChangeLog(revision 172224)
> +++ boehm-gc/ChangeLog(working copy)
> @@ -1,3 +1,22 @@
> +2011-08-15 Jie Liu
> + * configure.ac: Add configure for RTEMS.
> + * configure: Add configure for RTEMS.
> + * include/gc_config.h.in: Add GC_RTEMS_PTHREADS for RTEMS.
> + * mach_dep.c (GC_with_callee_saves_pushed): Use setjmp for
> + RTEMS.
> + * include/gc_config_macros.h: Define GC_PTHREADS for rtems.
> + * include/private/gcconfig.h: Add configure for RTEMS/i386;
> + Use calloc for RTEMS to GET_MEM.
> + * pthread_stop_world.c (GC_stop_init): Add judge SA_RESTART
> + for operating system; Use sigprocmask unblock the signal
> + for RTEMS.
> + * pthread_support.c: Define USE_PTHREAD_SPECIFIC for RTEMS;
> + Do not include sys/mman.h for RTEMS; Add default GC_nprocs
> + for RTEMS.
> + * gc_dlopen.c: Do not include dlfcn.h for RTEMS.
> + * os_dep.c: Do not use auxiliary routines for obtaining
> + memory from RTEMS.
> --- ChangeLog (revision 172224)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2011-08-15 Jie Liu
> +
> + * configure.ac (*-*-rtems*): Remove ${libgcj} in nonconfigdirs.
> + * configure: Regenerate.
> --- libjava/ChangeLog (revision 172224)
> +++ libjava/ChangeLog (working copy)
> @@ -1,3 +1,13 @@
> +2011-08-15 Jie Liu
> +
> + * configure.ac (THREADS): Add configuration for RTEMS.
> + * configure.host (host): Add configuration for RTEMS.
> + * include/config.h.in: Add RTEMS_PTHREADS for RTEMS.
> + * configure: Add configure for RTEMS.
> + * classpath/native/fdlibm/mprec.c: Remove _mprec_log10 for RTEMS.
> + * posix-threads.cc: Use SIGHUP for INTR on RTEMS.
> + * java/lang/natClass.cc: Undef HAVE_TLS for RTEMS.
Re: [PATCH] [JAVA] patch for Java on RTEMS
On 08/15/2011 03:07 PM, Jie Liu wrote: >> Looks OK, but there is no ChangeLog. Do you have copyright >> assignment? > > Have added ChangeLog to the patch, please see the attachment. And I > think I have copyright assignment, because I have Free Software > Foundation paperwork, as "ASSIGNMENT - GNU GCC ... JIE RT688742" Good. The libjava parts are OK; I can't approve the top-level part, but it looks fine. Andrew.
Re: [PATCH] [JAVA] patch for Java on RTEMS
> Looks OK, but there is no ChangeLog. Do you have copyright > assignment? Have added ChangeLog to the patch, please see the attachment. And I think I have copyright assignment, because I have Free Software Foundation paperwork, as "ASSIGNMENT - GNU GCC ... JIE RT688742" Best Regards, Jie gcj-rtems.patch Description: Binary data
Re: [PATCH] [JAVA] patch for Java on RTEMS
On 08/10/2011 06:00 PM, Jie Liu wrote: > For the previous analysis "libjava patches for RTEMS"[1], there are 6 > cases need to pay more attention. PR18699, TLtest, Thread_Interrupt, > Thread_Sleep_2, Throw_2 and bclink. > > After add patch to bdwgc for RTEMS pthread support[2]: > PR18699PASS after Modify [A bug in boehm-gc on > RTEMS, not related to libjava] > TLtestPASS > Thread_Interrupt PASS > > For the other 3 cases: > Thread_Sleep_2 PASS [After add patch to rtems] > Throw_2 PASS [After add patch to > libjava, still need some work][3] > bclinkUnSupport > [-findirect-dispatch do not support in this case] > > I think it's time to send out the patch for review, because it may > need much time to modify. The patch is attached. Looks OK, but there is no ChangeLog. Do you have copyright assignment? Andrew.
Re: [PATCH] [JAVA] patch for Java on RTEMS
Hi, I have add the boehm-gc patch and the configure for gcc patch to the patch attached. So we can add this patch and then compile gcj for RTEMS. Best Regards, Jie gcj-rtems.patch Description: Binary data
[PATCH] [JAVA] patch for Java on RTEMS
Hi, For the previous analysis "libjava patches for RTEMS"[1], there are 6 cases need to pay more attention. PR18699, TLtest, Thread_Interrupt, Thread_Sleep_2, Throw_2 and bclink. After add patch to bdwgc for RTEMS pthread support[2]: PR18699PASS after Modify [A bug in boehm-gc on RTEMS, not related to libjava] TLtestPASS Thread_Interrupt PASS For the other 3 cases: Thread_Sleep_2 PASS [After add patch to rtems] Throw_2 PASS [After add patch to libjava, still need some work][3] bclinkUnSupport [-findirect-dispatch do not support in this case] I think it's time to send out the patch for review, because it may need much time to modify. The patch is attached. How to mark those unsupported cases as expected failures on *-*-rtems* ? [1]http://gcc.gnu.org/ml/java-patches/2011-q3/msg00016.html [2]http://gcc.gnu.org/ml/java-patches/2011-q3/msg00042.html [3]http://gcc.gnu.org/ml/java-patches/2011-q3/msg00037.html Thanks, Jie libjava.patch Description: Binary data
