Re: [PATCH] [gcc, testsuite] Don't xfail on s390.
On 03/29/2017 12:23 PM, Dominik Vogt wrote: > The attached patch removes the XFAIL in attr-alloc_size-11.c on > s390. (PR 79356). > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79356 Applied. Thanks! -Andreas-
Re: [PATCH] [gcc, testsuite] Don't xfail on s390.
On Fri, Mar 31, 2017 at 03:37:33PM -0600, Martin Sebor wrote: > On 03/29/2017 04:23 AM, Dominik Vogt wrote: > >The attached patch removes the XFAIL in attr-alloc_size-11.c on > >s390. (PR 79356). > >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79356 > > > >Untested. > > It looks like the only target the test does fail on is x86. > > The attached patch simplifies the test to XFAIL just those. > It passes with cross-compilers for arm-linux-gnueabi-*-*, > i386-pc-solaris2.11, powerpc64le-*-*, sparcv9-solaris2.11, > and s360*-*-*. > > I don't have ready access to an s390 machine. I assume you > do. Does it work for you? Yes. > diff --git a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c > b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c > index e5f2157..19e8680 100644 > --- a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c > +++ b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c > @@ -47,8 +47,8 @@ typedef __SIZE_TYPE__size_t; > > /* The following tests fail because of missing range information. The xfail > exclusions are PR79356. */ > -TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 > range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range > info for signed char" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* > powerpc*-*-* sparc*-*-* s390x-*-* } } } } */ > -TEST (short, SHRT_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range > \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for > short" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* > sparc*-*-* s390x-*-* } } } } */ > +TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 > range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "bug 80086" { > xfail { i?86-*-* x86_64-*-* } } } */ > +TEST (short, SHRT_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range > \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "bug 80086" { xfail { > i?86-*-* x86_64-*-* } } } */ > TEST (int, INT_MIN + 2, ALLOC_MAX);/* { dg-warning "argument 1 range > \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ > TEST (int, -3, ALLOC_MAX); /* { dg-warning "argument 1 range > \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ > TEST (int, -2, ALLOC_MAX); /* { dg-warning "argument 1 range > \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany
Re: [PATCH] [gcc, testsuite] Don't xfail on s390.
On 03/29/2017 04:23 AM, Dominik Vogt wrote: The attached patch removes the XFAIL in attr-alloc_size-11.c on s390. (PR 79356). https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79356 Untested. It looks like the only target the test does fail on is x86. The attached patch simplifies the test to XFAIL just those. It passes with cross-compilers for arm-linux-gnueabi-*-*, i386-pc-solaris2.11, powerpc64le-*-*, sparcv9-solaris2.11, and s360*-*-*. I don't have ready access to an s390 machine. I assume you do. Does it work for you? Martin diff --git a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c index e5f2157..19e8680 100644 --- a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c +++ b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c @@ -47,8 +47,8 @@ typedef __SIZE_TYPE__size_t; /* The following tests fail because of missing range information. The xfail exclusions are PR79356. */ -TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for signed char" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* sparc*-*-* s390x-*-* } } } } */ -TEST (short, SHRT_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for short" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* sparc*-*-* s390x-*-* } } } } */ +TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "bug 80086" { xfail { i?86-*-* x86_64-*-* } } } */ +TEST (short, SHRT_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "bug 80086" { xfail { i?86-*-* x86_64-*-* } } } */ TEST (int, INT_MIN + 2, ALLOC_MAX);/* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ TEST (int, -3, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ TEST (int, -2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */
[PATCH] [gcc, testsuite] Don't xfail on s390.
The attached patch removes the XFAIL in attr-alloc_size-11.c on s390. (PR 79356). https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79356 Untested. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/testsuite/ChangeLog-attr-alloc-size-11 PR testsuite/79356 * gcc.dg/attr-alloc_size-11.c: Don't xfail on s390. >From 7a11e38485db879b499099292d7bd29bf3085775 Mon Sep 17 00:00:00 2001 From: Dominik Vogt <v...@linux.vnet.ibm.com> Date: Wed, 29 Mar 2017 11:21:07 +0100 Subject: [PATCH] [gcc, testsuite] Don't xfail on s390. --- gcc/testsuite/gcc.dg/attr-alloc_size-11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c index e5f2157..47584f5 100644 --- a/gcc/testsuite/gcc.dg/attr-alloc_size-11.c +++ b/gcc/testsuite/gcc.dg/attr-alloc_size-11.c @@ -47,7 +47,7 @@ typedef __SIZE_TYPE__size_t; /* The following tests fail because of missing range information. The xfail exclusions are PR79356. */ -TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for signed char" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* sparc*-*-* s390x-*-* } } } } */ +TEST (signed char, SCHAR_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for signed char" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* sparc*-*-* s390*-*-* } } } } */ TEST (short, SHRT_MIN + 2, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" "missing range info for short" { xfail { ! { aarch64*-*-* arm*-*-* ia64-*-* mips*-*-* powerpc*-*-* sparc*-*-* s390x-*-* } } } } */ TEST (int, INT_MIN + 2, ALLOC_MAX);/* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ TEST (int, -3, ALLOC_MAX); /* { dg-warning "argument 1 range \\\[13, \[0-9\]+\\\] exceeds maximum object size 12" } */ -- 2.3.0