On Fri, 17 Feb 2023, 07:40 Alexandre Oliva via Libstdc++, <
libstd...@gcc.gnu.org> wrote:
>
> vxworks ignores O_EXCL in open, so noreplace open succeeds when it is
> expected to fail. xfail the tests.
>
> Regstrapped on x86_64-linux-gnu.
> Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install?
>
OK, thanks.
(We need a similar change for hp-ux and Solaris, at least. Which means we
need to change the impl to not assume it works.)
> for libstdc++-v3/ChangeLog
>
> * testsuite/27_io/basic_ofstream/open/char/noreplace.cc: xfail
> on vxworks.
> * testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc:
> Likewise.
> ---
> .../27_io/basic_ofstream/open/char/noreplace.cc|2 +-
> .../27_io/basic_ofstream/open/wchar_t/noreplace.cc |2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> index 56ff2d7cead3c..2e99707df86d0 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/char/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include
>
> diff --git
> a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> index f0425cdab3d23..ddb7fd691608c 100644
> --- a/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> +++ b/libstdc++-v3/testsuite/27_io/basic_ofstream/open/wchar_t/noreplace.cc
> @@ -1,4 +1,4 @@
> -// { dg-do run }
> +// { dg-do run { xfail *-*-vxworks* } }
>
> #include
>
>
> --
> Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/
>Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about
>
